Time  Nick      Message
06:26 nerzhul   merging #5467
06:26 ShadowBot https://github.com/minetest/minetest/issues/5467 -- [CSM] Fix errors in and improve the CSM documentation. by red-001
06:28 nerzhul   celeron55, do you have set master branch to be protected ? https://github.com/minetest/minetest/settings/branches if not could be good :)
06:29 nerzhul   disable force push is sufficient :)
06:33 celeron55 i don't think we want that because there's no option to implement our "you can force push within a few minutes" rule and also it's just as easy to screw up a branch by adding unwanted commits to it as it is to remove commits from it
06:34 celeron55 and everyone has a copy anyway
06:36 nerzhul   celeron55, okay, it's a very marginal usecase, but an interesting usecase
06:37 celeron55 it would be nice if github supported that
06:37 celeron55 i don't think they would be willing to add it though
06:38 nerzhul   i think they should add like gitlab, approval reset on push
06:39 nerzhul   this will permit to remove our approval system using labels properly and use github approval
08:04 nrzkt     hello, can someone add a second approval on #5457 ?
08:04 ShadowBot https://github.com/minetest/minetest/issues/5457 -- GUI: Allow texture packs to customize the mouse pointer by kilbith
09:13 nrzkt     OldCoder should really be less crazy... anyway, go back to work.
09:16 kilbith   OldDick came come here, I'll smack him as never before
09:17 kilbith   *can
09:21 shivajiva can I watch?
09:22 VanessaE  man, wtf
09:22 VanessaE  I step away for a couple hours to watch a movie and all hell breaks loose.
09:23 nerzhul   it's not a combat channel but a dev channel, please do your combat using minetest :p
09:30 VanessaE  well there ain't much dev going on right now :)
10:27 Zeno`     wow
10:28 VanessaE  yeah.
10:28 nerzhul   Zeno`: maybe you will prefer aion ?
10:28 Zeno`     nerzhul, who? :)
10:29 Zeno`     I'm just reading -project and I don't know what to say lol
10:29 nerzhul   you said wow :p i said aion, or rift :p
10:29 nerzhul   Zeno`: it's crazy yeah, no need for weed just reading :p
10:30 cheapie   Meh, maybe that sort of thing will drive discussion back out of OC's "pet channel" #-project and back into here and #minetest.
10:31 nrzkt     erf i killed my irc client
10:33 nerzhul   cheapie: seems reasonable
10:34 cheapie   I've always been more or less opposed to the idea of a moderated channel like that, but I stayed there (until now) since that's where the discussion was.
11:02 kaeza     the moderated flag should really go IMHO. there is no reason for it in there
11:03 kaeza     problem users can just be muted/kicked/whatever like everywhere else
11:03 cheapie   +math.huge
11:03 kaeza     but requiring somebody to voice users is silly
11:04 kaeza     -but
11:07 shivajiva I see he's pulled the public logs for project...
11:07 kaeza     there are logs in irc.minetest.net now
11:07 VanessaE  http://irc.minetest.net/minetest-project/
11:08 shivajiva ty
11:17 shivajiva anybody who doesn't understand why I posted it is welcome to pm me
11:17 VanessaE  you mean the pasted PMs?
11:17 shivajiva mhm
11:21 cheapie   celeron55: <celeron55> [...]you kind of make the impression that it's best to just not use [#minetest-project] anymore
11:21 cheapie   +1
11:43 nerzhul   this chan is for dev, but it's also for roadmap discussions with devs, project maybe doesn't have many sense, it should be better to revive minetest-mods and have free mods discussions over there
11:44 nerzhul   without any more privs than -dev
11:49 kaeza     I can agree to that
11:49 kaeza     * Has sido expulsado de #minetest-mods por ChanServ (Invite only channel)
11:52 kaeza     c55 and xyz are +F there
11:52 nerzhul   oh :p
11:52 sfan5     kaeza: the problem is that you've set your client to a foreign language :)
11:52 kaeza     heh
11:53 VanessaE  heh
11:53 cheapie   heh
12:29 Fixer     sfan5: -mwindows helps, can confirm https://github.com/minetest/minetest/pull/5416#issuecomment-289750207
12:30 nerzhul   sfan5: i think #5457  is okay for a merge
12:30 ShadowBot https://github.com/minetest/minetest/issues/5457 -- GUI: Allow texture packs to customize the mouse pointer by kilbith
12:41 kilbith   this commit causes a regression : https://github.com/minetest/minetest/commit/dd2f1d7
12:41 kilbith   before we could passes a number to core.colorize, now it enforces a string
12:41 kilbith   *pass
12:42 kilbith   line 670 just needs `tostring(message):split`
12:45 nerzhul   red-002: ^
12:48 nerzhul   i reproduced it, will push the trivial fix now
12:50 nerzhul   done
14:13 nerzhul   sfan5: or another modern dev, can you look at #5471 ? thanks
14:13 ShadowBot https://github.com/minetest/minetest/issues/5471 -- Add CPP11 header to define nullptr & constexpr by nerzhul
14:14 nerzhul   this header will permit partial backward compat & write C++11 keywords constexpr & nullptr to have nicer pointers & compilation time evaluation for some variables :)
14:14 nerzhul   (in cpp11 builds only)
14:15 nerzhul   hmm wrong mail in commit, amending
14:19 kaeza     nerzhul, can you use `#if __cplusplus < 201103L || _MSC_VER < 1600` ? or is that not portable?
14:27 nerzhul   kaeza: i did like in cpp11_containers.h i think it should work, i can try it
14:27 nerzhul   i force pushed, we will see on CI
14:29 kaeza     either way works I guess
14:38 nerzhul   kaeza: https://travis-ci.org/minetest/minetest/builds/215960635
14:38 nerzhul   Ci seems happy
14:49 nerzhul   travis is happy, it's nice
15:26 sfan5     nerzhul: please do some performance profiling
15:26 sfan5     because this looks to me like useless work
15:27 sfan5     constexpr is something most likely done by the compiler on its own
15:27 sfan5     and why would we want nullptr?
15:28 nerzhul   nullptr is just the keyword of null which solve the paradigm with NULL = 0 = int = pointer null
15:28 sfan5     i don't see a problem there
15:28 nerzhul   modern and quality C++11 and over is to use nullptr
15:29 sfan5     yes but we are not targeting c++11
15:29 nerzhul   we should target it
15:29 nerzhul   debian 9 will be out in less than 1 year
15:30 sfan5     right now i think this change does not add anything useful
15:44 nerzhul   adding it now permits to start the C++11 layer compat before being C++11 minimum version
15:45 nerzhul   C++11 has 6 years, only Debian 8 doesn't support is nowadays, other OS are not supported anymore
15:46 nerzhul   err: debian 8 support it partially via clang 3.5
15:46 nerzhul   i don't tell, go start to use lambda, for_each, std::find_if etc , which can be only nice for minetest, but it's like std::mutex and std::thread support in core, it's useful for C++11 itself
15:58 nerzhul   sfan5: for just me, why are you against C++11, C++17, i can understand, C++14 why not (because without using C++11 C++14 beneficts are null like a nullptr), we are not in 2011 anymore, compilers support the norm, and <algorithm> header is a very nice header which contain many optimized functions for STL containers using lambdas if needed
17:02 sfan5     nerzhul: i'm not against c++11, i just dont think adding this much c++11 specific stuff to minetest is useful (yet!)
17:05 nerzhul   sfan5, the main problem is the yet and the fact at a point we will said okay now C++11 is the default, we don't have any work prepared before and the amount of work to benefit from C++11 would be huge as we have not started trivial portages like this, i just want to prepare stuff for earning some time later :)
17:11 nerzhul   i just plan to permit a nicer C++11 transition, with less developpers effort :)
17:13 nerzhul   oh, github suggest reviewers depending on who reviewed recently
17:18 nerzhul   sfan5, can you make #5457 a mergeable reality by adding your benediction please ? p
17:18 nerzhul   :p
17:18 ShadowBot https://github.com/minetest/minetest/issues/5457 -- GUI: Allow texture packs to customize the mouse pointer by kilbith
19:22 paramat   i'd like to merge #5470 in a few hours since it's important, will do if no objections
19:22 ShadowBot https://github.com/minetest/minetest/issues/5470 -- Fix sneaking bugs (yet again) by sfan5
19:42 paramat   then i'm going to experiment to see if simple sneak ladder can be made to work
19:55 nerzhul   merging #5472
19:55 ShadowBot https://github.com/minetest/minetest/issues/5472 -- Add functions to strip color information. by kaeza
20:56 paramat   glass having a liquid inside from param2, is this actually documented anywhere? also, there isn't a paramtype2 for it =/
20:57 paramat   paramtype2 == "liquid_tank_leveled"
20:59 paramat   sloppy :] i might have to sort this out
21:00 sfan5     paramat: game#1558 could use another review
21:00 ShadowBot https://github.com/minetest/minetest_game/issues/1558 -- 用creative.is_enabled_for替换minetest.setting_getbool("creative_mode") by zaoqi
21:01 sfan5     also the pr title translates to use creative.is_enabled_for instead of minetest.settings_getbool("creative_mode")
21:03 paramat   i've looked but am unsure about that PR, also rubenwardy possibly has an issue with it
22:22 paramat   but yes i'll look at it again
23:35 Fixer     https://forum.minetest.net/viewtopic.php?f=14&t=17113
23:36 Fixer     ^^ minetest alternative client based on Urhosharp game engine announced (kinda)
23:37 Fixer     for low mem devices
23:43 paramat   merging #5470 over the next few minutes, will do the codestyle fix during merge
23:43 ShadowBot https://github.com/minetest/minetest/issues/5470 -- Fix sneaking bugs (yet again) by sfan5