Time  Nick         Message
01:47 paramat      #5289 now tested, any comments?
01:47 ShadowBot    https://github.com/minetest/minetest/issues/5289 -- Dungeongen: Add and improve parameters by paramat
17:01 nore         #5283 has >= 2 approvals now
17:01 ShadowBot    https://github.com/minetest/minetest/issues/5283 -- Fix wrong meta key in item meta on ItemStack construction by rubenwardy
17:02 nore         sofar: maybe you could look at it since rubenwardy requested a review from you, though
19:47 sofar        geesh the beds mod is a disaster
19:47 sofar        like, just looking at it I want to remove all the code and just write something from scratch
19:47 Krock        burn the beds :3
19:48 Krock        depending on the current code style and structure it could indeed be a help to have it rewritten
19:48 VanessaE     well if you rewrite it, try to make it compatible with homedecor's beds :P
19:51 QwertyDragon to be able to make beds of other colors than red would be nice to to built in on the default beds mod in minetest_game  :)
19:54 VanessaE     homedecor's beds can do that.
19:55 sofar        oh gawd no, please stop begging for colored beds already
19:56 sofar        please, stand behind in line behind the hordes waiting for decent monsters/npcs
19:56 VanessaE     heh
19:59 sofar        lay_down(player, nil, nil, false, true)
19:59 sofar        who writes stuff like that?
20:07 sofar        local pi = math.pi
20:07 sofar        first line
20:07 sofar        you know the code quality is going to suck if that's your first line of code
20:09 sofar        player_in_bed -> name for a counter
20:09 sofar        yeah, let's use singular for a counter...
20:17 sofar        argh, I'm not touching this
20:17 sofar        & git reset --hard
20:40 nerzhul      sofar, heh
21:17 paramat      mtgame prs have just gone into double pages (26), my aim is to keep these to 1 page
21:22 Calinou      eventually, the number of open PRs will no longer fit in a 32-bit float
21:22 Calinou      int*
21:22 Calinou      :)
21:23 Fixer        minetest achives singularity
21:27 paramat      we certainly need more reviewers, hopefully we can add new engine devs before too long (lhofhansl)
21:47 twoelk       mh, long time ago, after a discussion on irc about the futur of minetes-game, I added to the wiki "Function: As collection of modding examples; Although this may seem trivial this function of the Minetest game should not be forgotten as it often offers the first example of how to code things for modders. "
21:47 twoelk       maybe I should tone that done somewhat :-D
21:49 paramat      nore sfan5 ShadowNinja what are your opinions on game#1552 ? it has 2 approvals but since it is a significant change that causes some disruption for mods your involvement would be good. rubenwardy any objection to the PR?
21:49 ShadowBot    https://github.com/minetest/minetest_game/issues/1552 -- Leafdecay: node timer based implementation, API. by sofar
22:00 paramat      sofar do you want to edit the conditionals in this https://github.com/minetest/minetest_game/pull/1563#pullrequestreview-21405103 before i merge it?
22:03 sofar        yes, that's on my list to update
22:05 paramat      i can merge that later if you update, with game#1574
22:05 ShadowBot    https://github.com/minetest/minetest_game/issues/1574 -- Torches: Reduce light source level from 13 to 12 by paramat
22:06 paramat      sorry you're probably at work
22:06 sofar        yeah, my wife is also out of town for a whole week so I have kids to deal with while working
22:11 paramat      ok no rush
23:06 Fixer        can we integrate minimap into minetest_game logic itself? say, crafting some kind of map/compass and holding it in hand will allow to see a minimap :}
23:09 paramat      an API is intended to allow that usage
23:36 Fixer        added "debug_log_level = verbose", yet all info goes to debug.txt, avoiding console window (in windows)