Time Nick Message 00:37 Fixer !tell paramat trying out those new lamps, from some distance I get some nongood render: https://i.imgur.com/r9A0LgJ.png (when looking at edge of lamp), do you see it on your hardware? 00:37 ShadowBot Fixer: O.K. 01:18 paramat will merge game#1560 game#1562 in a moment 01:18 ShadowBot https://github.com/minetest/minetest_game/issues/1560 -- Fix waterlily flickering (#1551) by octacian 01:18 ShadowBot https://github.com/minetest/minetest_game/issues/1562 -- Visual scale: Update plantlike nodes to post-bugfix values by paramat 01:31 paramat merging 01:48 paramat will merge #5199 #5208 in a moment 01:48 ShadowBot https://github.com/minetest/minetest/issues/5199 -- Footsteps: Fix offset footstep and shallow water sound bugs by paramat 01:48 ShadowBot https://github.com/minetest/minetest/issues/5208 -- Make colourized mainmenu text more readable by HybridDog 01:59 paramat merging 02:03 paramat done 02:04 paramat wow suddenly we're way past 800 issues 02:52 sofar we need paramat's deduplication senses 11:19 Krock Quick fix: game#1564 11:19 ShadowBot https://github.com/minetest/minetest_game/issues/1564 -- register_rail: Fix the table overwrite behaviour by SmallJoker 12:55 Zeno` paramat: https://github.com/minetest/minetest/commit/1de08e196182498a931b496f79b1c1eaf3de7ca4#diff-70868aa6d6b96c0c1623c761500d23c4R1616 12:55 Zeno` should that use round() ? 12:55 Zeno` i.e. compatible_visual_scale = round(sqrt(visual_scale)); 12:59 Zeno` not that exactly of course, but to 1st decimal place 13:01 Krock why round? That would make the scaling factor more unpercise 13:02 Zeno` well, because many old mods use 1.2 for plantlike visual scale 13:03 Zeno` so compatible_visual_scale = round(sqrt(visual_scale)*100)/100; should then return 1.2 if 13:03 Zeno` I dunno... I'm not sure how this part of the code works 13:03 Zeno` like 1.18 might be close enough to 1.2 I dunno 13:04 Krock it'd be *10 and then /10 for 1 decimal place 13:04 Zeno` err yeah 13:04 Zeno` sorry 13:04 Zeno` just talking, not really meant for implementation 13:04 Krock IMO this shouldn't be rounded. that difference isn't significant enough 13:05 Zeno` that's my question though 13:05 Zeno` do visual scales 1.18 and 1.2 look pretty much the same on old clients? 13:05 Krock good question 13:05 Zeno` and I don't know the answer because I haven't looked :) 17:10 red-001 rebased #5152 17:10 ShadowBot https://github.com/minetest/minetest/issues/5152 -- [CSM] Add `get_wielded_item` by red-001 17:41 rubenwardy Hey nerzhul, I was just wondering how many users have the official Minetest app installed on their device right now, according to Google Play 17:42 red-001 that's a pretty good question 17:43 rubenwardy (you can find out in the play console app, or under "ACTIVE" in the app table at https://play.google.com/apps/publish/) 17:44 nore rubenwardy: though, beware that the official app on f-droid probably won't count in those stats 17:44 rubenwardy I know 17:45 rubenwardy My mod manager app has ~500, I was wondering what % I have 17:45 rubenwardy I'm guessing ~1/2% 17:46 rubenwardy (1 or 2, not 0.5) 17:51 red-001 A large number of mt installs on android are going to be something like multicraft or worldcraft 17:52 rubenwardy yeah 17:52 rubenwardy but my app pretty much only supports the offical Minetest 18:50 paramat !tell Zeno` rounding (to 0.1 or .01) the visual scale sent to old clients would cause plantlike scale to be different from what they saw before, and different from the intended scale seen on new clients 18:50 ShadowBot paramat: O.K. 18:55 paramat est31 nerzhul nore sfan5 ShadowNinja sofar Zeno` please can we get #4682 moving? this is the first half of fixing all lighting bugs :O and has been waiting 4 months. top priority for review, well tested 18:55 ShadowBot https://github.com/minetest/minetest/issues/4682 -- Fix water flooding onto lava by juhdanad 18:57 paramat this and the 2nd half #4967 are also delaying other lighting work the author wishes to do 18:57 ShadowBot https://github.com/minetest/minetest/issues/4967 -- New bulk node light update by juhdanad 18:58 paramat oh, rubenwardy too ^^ 18:59 paramat please can rubenwardy be OPed? so that his name appears with all other devs in my IRC client? it's difficult to see when he's around 19:00 * paramat would like to give rubenwardy his own little blue dot 19:02 paramat i'll merge #5215 later as it's fairly trivial and similar to the plantlike fix 19:02 ShadowBot https://github.com/minetest/minetest/issues/5215 -- Firelike drawtype: Fix visual_scale being applied squared by paramat 19:09 nore paramat: commented on #4682 19:09 ShadowBot https://github.com/minetest/minetest/issues/4682 -- Fix water flooding onto lava by juhdanad 19:10 paramat thanks for looking 19:10 sofar 4967 conflicts with 4862? 19:11 sofar I cant apply both 19:11 paramat the latter is based on the former 19:12 nore I guess 4967 will be rebased when 4862 is merged 19:12 paramat but the 2nd includes the first 19:13 paramat see https://github.com/minetest/minetest/pull/4967#issuecomment-269698505 19:16 paramat the 2nd PR even fixes dark shadows caused by moretrees in mgv7 :O 19:22 Fixer those fixes are very important 19:24 paramat MT's number 1 bug, even growing saplings causes shadows sometimes, any use of schematic or voxelmanip 19:25 sofar well merge the first and have him rebase the second 19:25 paramat yeah 19:25 sofar needs a squash too, but that you can just do on merge. 19:26 paramat let's see the response to nores comment before merge 19:29 sofar I'm not sure that is a good idea, are you going to record a bit for each mapblock? 19:31 paramat nore ^ 19:33 nore sofar: hmm, what I was suggesting was just to initialize m_lighting_idontrememberwhat to 0 instead of 0xFFFF for old mapblocks 19:33 Krock *expired 19:33 nore Krock: no, that was the old name 19:33 Krock oh right, that was changed. 19:36 sofar hm, that may work, but tbh you're gonna force every block to be updated then once 19:36 sofar not sure it's worth the cost 19:45 paramat hm i'm not keen on recomputing either (author has replied) 19:46 paramat so i'll merge this later yes? 19:47 paramat these block border bugs are rare anyway 19:48 paramat yes i will, in 1-2hrs 19:49 paramat now we need to review the 2nd half hehe 20:00 Fixer i though we have proper stairs in dungeons... https://i.imgur.com/2j7vhOY.png 20:01 paramat stairs in all dungeons do now sometimes appear, but they usually fail due to other issues 20:01 paramat there's a comment in the code by c55 about how difficult it is to get them working 100% 20:02 paramat however i did fix these such that, when they do work, they are full-width in 2+ wide corridors 20:02 paramat i *might* attempt to get them working all the time, but i can tell it will be very difficult 20:16 paramat new leafdecay method #1552 +1 from me. nore sfan5 ShadowNinja 20:16 ShadowBot https://github.com/minetest/minetest/issues/1552 -- Holding the Jump key on a bouncy block makes you jump too high 20:16 paramat game#1552 20:16 ShadowBot https://github.com/minetest/minetest_game/issues/1552 -- Leafdecay: node timer based implementation, API. by sofar 20:18 paramat rubenwardy too 20:37 Thomas-S Could someone please review game#1559 ? Thanks in advance! 20:37 ShadowBot https://github.com/minetest/minetest_game/issues/1559 -- Globalize and rename has_locked_chest_privilege by Thomas--S