Time Nick Message 00:19 rubenwardy octacian, I doubt it given freeze is in 2 days 00:20 octacian true. 01:37 rubenwardy merging game#1429 in 20 minutes... (sfan5 paramat sofar) 01:37 ShadowBot https://github.com/minetest/minetest_game/issues/1429 -- Add sfinv.get_homepage_name() by rubenwardy 01:39 paramat fine by me, if possible could you also merge #1442 ? 01:39 ShadowBot https://github.com/minetest/minetest/issues/1442 -- Colliding with unloaded blocks at high velocities is problematic 01:39 paramat game#1442 01:39 ShadowBot https://github.com/minetest/minetest_game/issues/1442 -- Snappy group: Remove beds and cactus from group by paramat 01:39 rubenwardy sure 01:44 paramat Zeno` if possible could you review #4061 ? it's well tested, needs one more approval 01:44 ShadowBot https://github.com/minetest/minetest/issues/4061 -- Add loaded blocks to transforming_liquid-queue similar to updateLiquid by MillersMan 01:47 Zeno` It might take a while, but ok 01:49 paramat no problem, and thanks, it's been difficult to find a reviewer 01:50 rubenwardy merging... 01:51 rubenwardy done 02:02 Zeno` paramat, have the points MillersMan made on 26 Oct been addressed? I can't see where/if he said they have been, or if something has made him change his mind since then 02:02 paramat checking 02:08 paramat indeed the thread isn't clear if he is happy now. we have chatted a lot on IRC recently, starting 7 days ago, and he is happy with his new code. reading those points i'm fairly sure the new code addresses almost all of them, at least the important ones 02:09 Zeno` Ok, best make sure when he's next on I guess 02:09 Zeno` The code looks good so far 02:09 paramat yes i'll double check and let you know 02:10 paramat http://irc.minetest.net/minetest-dev/2016-11-27#i_4751360 and onwards 02:11 paramat he was away for a while but suddenly returned with new code 02:12 paramat or rather, improved code 02:12 Zeno` has he been around lately on IRC? 02:12 paramat yes 02:12 Zeno` anyway, based on what I've looked at so far (nearly all of it) I'll +1 it once the small clarification is made. The IRC does indeed suggest he's happy with it now 02:13 paramat ok thanks i'll check with him and send you a message or something 02:14 Zeno` I've +1 it pending a response 02:14 paramat his last relevant post http://irc.minetest.net/minetest-dev/2016-12-01#i_4754435 02:14 paramat last time he mentioned the PR 02:15 paramat you're my hero now 02:18 Zeno` I'll keep testing in the meantime but it's tricky to find the edge cases. It seems Fixer and you did quite a lot of gameplay testing anyway 02:18 Zeno` btw, that rivers thing looks awesome 02:19 Zeno` the map does anyway... haven't seen in-game 02:20 paramat yes good map, messy in-game but very interesting 02:20 Zeno` well, it's still proof of concept stage so you'd expect it to be unpolished 05:09 paramat sofar i'm beginning to think you were right and that fire sounds cannot be done well enough in lua to be included in mtgame, see https://github.com/minetest/minetest_game/pull/1436#issuecomment-264763715 onwards 05:10 paramat fire sounds will probably have to be removed, unfortunately 05:13 paramat until we add new dedicated engine code for ambience 05:23 sofar paramat: I must admit, I have been following your progress on fire sounds and hoping you'd come up with a decent method 05:28 paramat instead, i can provide optional mods with my code for those who want sounds 05:29 Zeno` PR incoming "Add groin bulge" to Sam 05:29 Zeno` it will be my first -game PR 05:34 paramat heh 05:36 sofar paramat: I think it's entirely possible to do it nicely in lua though, and it will even sound realistic, but it will just come at the cost of network packets 05:39 paramat yes, but to do it acceptably needs very intensive code 05:39 sofar yup 05:39 sofar we've got 2 possible solutions that are far better 05:39 sofar 1) client side node sounds - a way to attach an always-playing sound to a node that just loops 05:39 sofar 2) client-side lua 05:41 sofar a bit of logic would make 1) quite feasible 05:53 paramat game#1444 05:53 ShadowBot https://github.com/minetest/minetest_game/issues/1444 -- Fire: Remove flame sound code by paramat 05:53 * paramat hides 18:35 sofar paramat: FYI with current HEAD for minetest_game I don't see any mipmap issues... 20:51 paramat sofar mip-map visual bugs seem to be GPU dependent, i get bugs with either RGBA or indexed alpha textures, as does Fixer 21:26 paramat #4682 had an update 21:26 ShadowBot https://github.com/minetest/minetest/issues/4682 -- Fix water flooding onto lava by juhdanad 21:32 sofar paramat: yeah, I tested on Intel in the office today 21:32 sofar didn't see any issues 21:48 PR4061Lives sfan5: reproduced :} 21:48 sfan5 what's the error? 21:49 PR4061Lives sfan5: serialisation blabla: could not read all chars 21:49 sfan5 just copy the full error 21:49 sfan5 i know what a serialization error looks like 21:49 PR4061Lives full one? how? 21:50 PR4061Lives i got only this: 21:50 PR4061Lives ERROR[Main]: Client::handleCommand_ActiveObjectMessages: caught SerializationError: deSerializeString: couldn't read all chars 21:50 sfan5 that's what i meant 21:50 sfan5 hm 21:50 paramat PR4061Lives could you perhaps test 4682? 21:50 sfan5 that should be the one that was recently fixed 21:50 PR4061Lives sfan5: yeah, thats why i got suspicious because server was running newer version and still got those errors 21:51 PR4061Lives paramat: i can 21:51 sfan5 i'm pretty sure the pr changed something on the client too 21:51 sfan5 please try to reproduce it in singleplayer too 21:52 PR4061Lives sfan5: that error was in singleplayer 21:52 PR4061Lives with PilzAdam mob fork I believe 21:52 PR4061Lives engine 8a7dc83 21:52 PR4061Lives newest one 21:53 PR4061Lives i will open an issue and explain how to reproduce with subgame 22:04 PR4061Lives created 22:06 paramat ~tell Zeno` 4061 is go https://github.com/minetest/minetest/pull/4061#issuecomment-264992163 22:06 ShadowBot paramat: O.K. 22:07 paramat #4061 is now approved :] 22:07 ShadowBot https://github.com/minetest/minetest/issues/4061 -- Add loaded blocks to transforming_liquid-queue similar to updateLiquid by MillersMan 23:05 ShadowNinja Final (?) security fix/compatability improvement: #4849 23:05 ShadowBot https://github.com/minetest/minetest/issues/4849 -- Mod security: Allow read-only access to all mod paths by ShadowNinja 23:07 garywhite Hi ShadowNinja 23:09 ShadowNinja o/ 23:16 PR4061Lives \o 23:20 est31 \o/