Time  Nick          Message
02:12 paramat       new biomes are tested https://github.com/minetest/minetest_game/pull/1432 can anyone give approval? sofar ? if merged i will merge the corresponding engine change too https://github.com/minetest/minetest/pull/4831
02:13 paramat       game#1432
02:17 AcidNinjaFWHR hi
02:18 AcidNinjaFWHR oh damn this 0.4.15 will be really good
03:55 Rincewind`    hi lhofhansl
03:55 Rincewind`    lhofhansl, if you're happy with the wording of #4827 I'll merge
03:55 Rincewind`    err
04:13 lhofhansl     Looks good. Thanks!
04:23 Zeno`         np
05:03 garywhite     To the devs: https://forum.minetest.net/viewtopic.php?f=3&t=15972
05:13 est31         replied
05:13 est31         but its not really dev related
05:44 paramat       est31 if possible could you look at https://github.com/minetest/minetest/pull/4826 'Optimize block sent: Fix rendering issue'?
09:40 Amaz          If any devs could look at #4833, which fixes #4832, I'd appreciate it!
09:56 Zeno`         qwok, done
09:56 Zeno`         qwok!
09:56 Zeno`         I meant ok lol
10:11 Amaz          Thanks :)
10:20 Zeno`         merging #4830
10:26 nrzkt         what is that ? bot is away
10:35 Zeno`         https://github.com/minetest/minetest/commit/144da5f522bf057ac612ef1fa09478d0215f6d0d
10:35 Zeno`         i.e. nothing significant
11:18 IKRadulov     Modding : I am tring to use the player:attach() method . I give for first param [parent] minetest.get_node(pos) . But it trows me a error that userdata is expected . How can I resolve this ?
11:19 nrzkt         Kulgan`: trivial
15:56 VanessaE      as I figured, those sawtooth patterns in my servers' memory usage weren't coming from Minetest, they were coming from log files being written to /dev/shm (just goes to show how big they are).
15:58 est31         interesting
15:59 Fixer_        aha
16:03 juhdanad      Hi! May I also be mentioned in #4827?
16:04 est31         yes!
16:05 est31         thanks for pointing out
16:05 * VanessaE    pokes ShadowBot
16:09 juhdanad      Me thanks too!
16:11 juhdanad      I also need your opinion: my lighting code is one level brighter than the old one, which means the light spreads one node further from sun.
16:11 juhdanad      This is basically good, but makes the two versions incompatible.
16:12 juhdanad      When playing on an old server with a new client, there are extra computations because the server always re-sends blocks with dimmer light.
16:13 juhdanad      Should I make sunlight dimmer again?
16:17 est31         the extra computations are only if the server is old and the client is new?
16:18 est31         juhdanad: ^
16:18 juhdanad      Or if the server is new and the client is old (but I have to test this one)
16:18 juhdanad      Testing.
16:24 juhdanad      est31: yes, there are extra computing but I couldn't make the game crash.
16:24 juhdanad      *is
16:24 est31         then its no big deal
16:24 est31         most servers are up to date
16:25 juhdanad      Okay, thanks!
16:26 est31         the reverse is far more often to be found
16:26 est31         old client vs new server
16:27 est31         18 servers on the serverlist don't use 0.4.14 or later
16:28 est31         all other servers use >= 0.4.14
16:28 est31         (in total, there are 164 servers on the serverlist)
16:28 est31         if you want to see more stats, look at: https://gist.github.com/est31/66602d589b225b27afd5
16:29 juhdanad      Why is it secret?
16:29 est31         I just dont want it to be listed
16:30 est31         most of my github gists are secret :)
16:30 est31         feel free to share it, its public info
16:31 Fixer_        anyone seen this? https://i.imgur.com/WGT6waX.png
16:32 Fixer_        i think it is specific to vanessa's server only
16:34 VanessaE      probably some mod texture
16:35 Fixer_        yeah, could be
16:52 juhdanad      Fixer_: yes, I also observed that some of my inventory slots were distorted (in the hotbar) on VanessaE's creative server.
17:55 red-001       updated #4474
17:55 red-001       the code is even simpler now
19:01 paramat       juhdanad, this light level issue may be a problem, needs consideration
19:02 juhdanad      It is easy to make the world 1 level dimmer, if you want.
19:04 juhdanad      paramat: If you wish to experiment, create an old server, connect with a new client, dig a horizontal 1x2 tunnel and place a node to the entrace.
19:05 juhdanad      paramat: You will see two light updates instead of one: first the client decreases light, then you get the even dimmer block from the server.
19:12 paramat       does this happen on single-node light updates only?
19:13 juhdanad      Yes, if liquid flow counts as single node.
19:13 paramat       light levels are critical and the values are used to control behaviours
19:14 paramat       so, if there is a single column of light-sun (15) falling in a cave, the face-neighbours must have 14, not 15
19:15 juhdanad      This is what my new code does.
19:15 paramat       14 or 15?
19:15 juhdanad      The old gave face-neighbors 13.
19:16 paramat       weird
19:16 juhdanad      Mine is 14.
19:16 paramat       so the old code was wrong
19:17 sofar         yeah, doesn't surprise me
19:17 paramat       and a meselamp of 14 will have face-neighbours of 13?
19:17 juhdanad      Yes, and I didn't notice it while writing the new code.
19:18 juhdanad      And yes, a meselamp's neighbors will be 13 in both implementations.
19:18 paramat       ahh
19:18 paramat       so your change is specific to level 15?
19:19 juhdanad      Yes, it is.
19:19 paramat       ok i'm less worried now
19:21 juhdanad      https://github.com/minetest/minetest/blob/master/src/light.h#L43 You can see the old code did not create air with light level 14.
19:29 paramat       juhdanad may not be relevan but see https://github.com/minetest/minetest/commit/7233a1228eb161cbcbb46c6e801cabd89ef3d2ab this is mapgen lighting update, and was brightened by 1 here
19:29 paramat       just mentioning it because i thought of this
19:31 juhdanad      The intended light level was increased, bus as I see, diminish_light() filtered out everything above 13.
19:33 paramat       that commit seems correct though because 'lightspread()' above reduces by 1 before spreading
19:34 paramat       anyway this is no issue, just mentioned it because i remembered a light level change commit :)
19:36 paramat       est31 please could you look at #4826 ? needs merging
19:36 paramat       https://github.com/minetest/minetest/pull/4826 Optimize block sent: Fix rendering issue
19:36 est31         not today, sorry
19:37 paramat       ok
19:39 paramat       hmmmm nore nrzkt sfan5 sofar rubenwardy please can someone check https://github.com/minetest/minetest/pull/4826 'Optimize block sent: Fix rendering issue' high priority fix
19:40 paramat       small commit and some of it is already approved
19:42 octacian      I think mod security is broken again...
19:42 paramat       5 days to freeze btw
19:43 octacian      I can't open files in world directory now.
19:44 paramat       please can anyone review https://github.com/minetest/minetest/pull/4061 'Add loaded blocks to transforming_liquid-queue similar to updateLiquid'? well tested, needs another +1
19:48 paramat       sofar rubenwardy please could you add your approvals to newbiomes https://github.com/minetest/minetest_game/pull/1432 and the engine commit https://github.com/minetest/minetest/pull/4831 ?
19:48 paramat       sfan5 i will probably merge new biomes later
19:49 paramat       i'd still like approval though
19:51 rubenwardy    I can't comment on the code, but when I tried `newbiomes` I quite liked it
19:52 paramat       it's the same as that mod
19:54 paramat       sofar seems to like it too, so i will merge later if no objections
19:57 rubenwardy    am I right in thinking that there's currently no biome backwards compatibility, apart from reverting the file?
19:58 rubenwardy    Might be worth storing biome defs in the world to stop breakages. Not my area though, so feel free to ignore me :P
19:58 paramat       it will create straight biome borders between old and newly generated world
19:58 rubenwardy    what about big cliffs?
19:58 paramat       indeed biome defs are not stored per-world
19:59 paramat       nooo terrain is unchanged
19:59 paramat       :)
19:59 rubenwardy    oh good
19:59 rubenwardy    not so bad then
19:59 paramat       mgv7 terrain is stable now
19:59 paramat       the biomes are officially unstable
20:17 sfan5         paramat: can you give a very short tl;dr of what changed?
20:17 sfan5         afaik there's the silver sand(?) is now used with the biome pr
20:17 sofar         yes, and most of the biome points have moved
20:17 paramat       first post in https://github.com/minetest/minetest_game/pull/1432
20:17 sofar         so distribution is different now
20:18 paramat       silver sand is used for cold desert
20:18 sfan5         ah sorry
20:18 sfan5         reading that now
20:18 sfan5         wait we have swamp biomes?
20:18 paramat       also more details and screenshots in #1022
20:19 paramat       swamp is the part of rainforest that is in shallow water
20:19 sfan5         sounds pretty nice from the description
20:19 paramat       the jungletrees now spawn in 1 or 2 deep water so the swamps are bigger
20:19 sfan5         you have my +1
20:19 paramat       phew thanks
20:22 paramat       wow 8 months of work
20:24 paramat       so i'll merge lots of stuff later, including Optimize block sent: Fix rendering issue #4826 it can't wait any longer
20:29 red-001       updated #4472
20:29 red-001       @@
20:30 red-001       "Make serverlist searchable"
20:50 garywhite     So does that mean that the server list will be searchable in 0.4.15?
20:51 Krock         if merged, yes
20:51 red-001       if it gets one more approval
23:12 sfan5         merging https://github.com/minetest/minetest/pull/4474 (>= 2 approvals)
23:19 paramat       i'll merge games 1432 1434 and engine 4831 later
23:23 paramat       and maybe 4826 too, allthough i'd like someone to check it
23:24 paramat       i'll have another look at it
23:48 paramat       +1 for 4826 will merge later
23:49 paramat       ^ lhofhansl