Time  Nick        Message
01:58 paramat     bush distribution for new biome system https://github.com/minetest/minetest_game/pull/1022#issuecomment-262411759
01:59 paramat     new system is near ready for merge, you can test it by running my 'newbiomes' mod
02:30 paramat     i wonder if it's acceptable to have dry shrubs growing on the sandstone of sandstone desert ..
03:13 Wayward_One Perhaps they could be growing through cracks/crevices in the sandstone
03:14 paramat     it might be reasonable, perhaps some shrubs can live on stony surfaces
03:22 paramat     testing carts on a long upward slope, continuous power rails, i'm finding sometimes the cart will stop and go down again
03:24 paramat     if 'jiggles' and slows down, then reverses direction
03:33 paramat     sound level is ok
03:36 paramat     climbing bug seems worse at low speeds
03:40 paramat     setting power rail to acc 9 seems to help. maybe the problem is the interaction betweem gravity acc and power rail acc
03:55 paramat     anyway, accelerating the cart to max speed before hitting the base of the climb seems to help
03:58 paramat     .. which is what you would want anyway as speed at base = climb speed
04:16 paramat     each jiggle slows the cart on a climb. because power rail acc = gravity acc the lost speed is not recovered, it may be necessary to raise power rail acc to 5 to help with this bug
05:22 paramat     game#1407
05:22 ShadowBot   https://github.com/minetest/minetest_game/issues/1407 -- Carts: Slowing and reversal on long climbs
14:34 rubenwardy  sofar, sfan5, nore: What do you think of game#1229? It dries the code out a bit
14:34 ShadowBot   https://github.com/minetest/minetest_game/issues/1229 -- Bones: Iterate player inventory lists dynamically. by t4im
14:37 sfan5       code seems fine to me
15:26 rubenwardy  What is the opinion on variable initialisation inside if statements? I know nrzkt is in favour. I don't like them as they're easy to confuse with equivalence
15:27 Zeno`       example?
15:27 rubenwardy  https://github.com/minetest/minetest/pull/2827/files#diff-da1e28445fc732755d2b64683bd94ee4R1284
15:28 rubenwardy  I'm probably closer to neutral than against really
15:32 rubenwardy  if think lines like if (variable = getVariable()) should be banned, however if (Type variable = getVariable()) isn't so bad
15:40 nrzkt       in fact having it permit to affect + check the null directly + limit the scope of the variable and it doesn't affect C++ code readers :)
15:41 hmmmm       very bad
15:41 hmmmm       in fact i think it's banned
15:41 sfan5       ^ same
15:42 sfan5       !tell paramat please re-review https://github.com/minetest/minetest/pull/4774
15:42 ShadowBot   sfan5: O.K.
15:42 hmmmm       nrzkt keeps trying to insert it into his PRs
15:42 hmmmm       he's the only one i know who does this
15:42 sfan5       i didnt even know you could do that
15:43 sfan5       is that a recent addition to some standard?
15:45 hmmmm       http://en.cppreference.com/w/cpp/language/if
15:46 hmmmm       it appears to have been there for some length of time
15:46 nrzkt       sfan5: no you can do this since a very very very long time, you can do this in pure C too
15:47 nrzkt       oh we can do if constexpr too, interesting :)
15:47 nrzkt       (for C++11 and more)
15:52 Zeno`       you mean "if (Inventory *inv = getInventory()) {" ?
15:52 Zeno`       there is no point to doing that
15:53 Zeno`       if (variable = getVariable())       is actually more acceptable in my book
15:53 sfan5       both are horrible
15:53 Zeno`       (with proper parenthesis
15:53 Zeno`       yeah they are
15:53 Zeno`       there is no point to either of them
15:55 Zeno`       although (var = func()) is pretty common and accepted
15:55 hmmmm       more acceptable for while statements i'd argue
15:56 Zeno`       e.g. if ((fp = fopen(SKJFKSJFKSJFKSJF)) != NULL)
15:56 Zeno`       I can't say I'd argue with code like that
15:57 Zeno`       s/with/about
15:58 Zeno`       or malloc() etc etc etc etc
15:59 hmmmm       yeah but you can do it just as cleanly with foobar = malloc();
15:59 hmmmm       if (foobar == blah) { ...
15:59 hmmmm       even cleaner because there's less stuff going on in the same line
16:00 rubenwardy  hmmmm, it's not currently explicitly disallowed in the code guidelines wiki or kernel code style
16:00 rubenwardy  I'm glad I'm not the only one that dislikes it
16:02 Zeno`       hmmmm, yeah, of course. But the idiom for malloc and fopen etc is pretty widespread and common
16:02 Zeno`       nearly every single C and C++ book will use that form as well (e.g. K&R)
16:03 Zeno`       I rarely, if ever, see if (int a = ...
16:04 Zeno`       declaration within the expression is a whole different ballgame to assignment imo
16:04 rubenwardy  I suggest discouraging it, but allowing it if you surround it with    (  ) != null
16:05 Zeno`       rubenwardy, in the case of assignment but not declaration it's pretty hard to say "nah" because that is what textbooks use
16:05 rubenwardy  *at the very least
16:06 rubenwardy  It's still too easy to miss the `=` not `==`. Text books don't necessarily define the best way
16:07 Zeno`       if there parenthesis are there then there is no problem. And every single compiler since about 1989 has warned if the parenthesis are not there anyway :)
16:07 Zeno`       "suggest parenthesis" warning
16:08 Zeno`       but if someone were to write what hmmm wrote, I would not object either
16:08 Zeno`       it's the declaration of an object within an expression I dislike
16:11 Zeno`       The C and C++ standards have examples of assignment within an expression!
16:11 Zeno`       it's kinda hard to say it's bad when the practice for some functions (fopen, malloc, etc) is so widespread
16:12 Zeno`       and has been since 1972
16:15 Zeno`       anyway, I'm fine with those common usages. nrzkt: I'm not fine with a declaration in an expression
16:15 Zeno`       mainly because it makes no sense to me
16:16 Zeno`       I mean I understand it, but it's not something with a history as long and established as the fopen/malloc practices
16:17 Zeno`       I'm not even sure if scope is changed
16:17 Zeno`       but I'd have to look that up
16:17 Zeno`       surely "if (const InventoryList *hlist = inv->getList("hand"))" emits a warning anyway
16:17 Zeno`       and we avoid warnings
16:18 Zeno`       maybe it doesn't because I've never written code like that hehe
16:24 asl97       3 1a
16:24 Zeno`       ohhhh a code!
16:24 * Zeno`     loves codes
16:24 * Zeno`     tries to crack it
16:25 Zeno`       it's a tough one :/
16:26 Zeno`       I've decoded it, asl97!
16:26 Zeno`       "HODOR"
16:26 asl97       wat
16:26 Zeno`       is that not correct?
16:27 Zeno`       maybe I forgot to carry the zero
16:27 asl97       uh... must have accidentlly hit some key when i place my tablet on the keyboard >.>
16:27 Zeno`       if I carry the zero I get "ROGER"
16:29 Zeno`       you'd think that with simple arithmetic I'd remember to carry the zero, but often I forget :(
16:46 milllersman a good use case for declaration in if is: } else if(YetAnotherType *yat = dynamic_cast<YetAnotherType*>(ptr)) {
16:47 milllersman this allows to keep alternative tests flat, otherwise either all dynamic_casts have to be done before the if-else-if block or there is deep nesting
16:48 milllersman but it's the only use-case i know
16:49 milllersman not to speak about the evilness of dynamic_cast
17:09 Fixer       Why I hate new chat: https://i.imgur.com/mmGPaeO.png
17:10 rubenwardy  #4805
17:10 ShadowBot   https://github.com/minetest/minetest/issues/4805 -- Block spam messages before calling on_chatmessage callbacks by rubenwardy
17:10 rubenwardy  ShadowNinja ^
17:44 rubenwardy  reviewed and tested #4472
17:44 ShadowBot   https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001
19:36 milersman   paramat, Fixer: good news, reflow works, has no black-outs and is gap free... only code cleanup and performance optimization needed before it can be merged
19:36 Fixer       milersman: thats amazing
19:37 Fixer       that is one of the bug fixes I waited since "The Beginning of Minetest"
19:39 milersman   i hope that its performance is good enough
19:40 milersman   the first version i push will contain output of scan statistics to cout
19:41 Fixer       ok
20:02 milersman   was to early to celebrate: under rare circumstances some columns don't fall to the ground... seams like its when the whole column is approach from below
20:27 milllersman Fixer: At least the lava falls in your world don't show any mistakes
20:50 Fixer       Fixer: Little update re 0,0,0: TPS Lego is now definitely experiencing it as well. I get about 20 seconds delay and others are reporting it too. Seems no server is safe now :(
20:50 Fixer       can anyone look at this bullshit?
20:50 Fixer       at least 3 servers experience it
20:51 Shara       Certainly more than three.
20:52 Shara       VE servers, RedCat, Xanadu, TPS, ...got report from TenPlus1 yesterday that DarkLands (my non-public server on latest dev) also had it for him.
20:53 asl97       you quote yourself xD
20:53 asl97       what delay are we talking about?  is it #2832
20:53 ShadowBot   https://github.com/minetest/minetest/issues/2832 -- Client desync
20:53 Shara       Fixer quoted me, but without the bit to show it was me :)
20:53 Fixer       https://github.com/minetest/minetest/issues/4403 this one
20:53 Shara       Fixer: It seems like there are actually two seperate issues with this bug?
20:54 asl97       oh, that old spawn bug
20:54 Shara       One that locks up privs/chat/everything and one that is simple failure to get coords.
20:54 Fixer       Shara: one issue was present in -dev for week or more and was fixed, this one is much older
20:54 Fixer       Shara: right
20:55 Shara       Didn't test much in past week, but I know Xanadu seemed to have both a little while back... (wait long enough and you could /spawn to get out, but initially that wouldn't work... wait even longer and it would teleport you)
20:55 Shara       Xanadu still has at least one of them since.. I think whatever was meant to fix it.
20:56 Shara       But Xanadu had no issues at all until the past month maybe.
20:56 Fixer       i think Xanadu one was coord bug, that was fixed recently
20:56 Shara       So it was present in stable release... then skipped for a while, then came back?
20:56 Fixer       your bug is not fixed
20:56 Shara       No, Xanadu still had this issue last night anyway.
20:56 Shara       They tested fix after updating... didn't work
20:57 Fixer       i had no problems with 0 0 0 on xanadu, but on vanessas and redcat - for sure
20:57 Fixer       up to 15 minutes wait time
20:57 Shara       I still don't ever go to 0,0,0 on RC myself, but on Xanadu I am there for 10+ seconds every time. Some people (Sokomine for example) have had it much worse
20:58 Shara       Who gets it on which servers doesn't seem to make any sense :(
20:58 Fixer       ok
20:58 Fixer       i think we motivated devs enough /me hides
20:59 * Shara     hides and hopes
21:02 Fixer       if only we had some debug info on this
21:04 Shara       I wouldn't know where to start. If I did, I'd try.
21:09 paramat     hi milllersman can you fix the join / leave spam from your connection? perhaps disable auto-join?
21:10 milllersman paramat: sorry, my problem is the very unstable WLAN connection on windows systems, which results in a minute-long disconnects every few minutes
21:11 paramat     ok :)
21:12 milllersman is there a good web-irc tool? maybe this would be more stable under this cirumstances
21:13 asl97       milllersman: there is the irccloud service, if you have a server, you can use a irc bouncer like znc
21:13 asl97       milllersman: there is the irccloud service, if you have a server, you can use a irc bouncer like znc
21:14 milllersman asl97: no need to repost, i'll follow the discussion in the log ^^... unfortunately i don't have a server :(
21:16 millersman  trying kiwiirc.com... hopefully this is more stable
21:17 asl97       isn't kiwiirc just a web irc client?  i am pretty sure they will disconect you from the network when you disconnect from them
21:22 millersman  asl97: i hope that the http-protocol hides the disconnects from the server, it's just a wlan internal issue, all systems (including mobile) except for linux get extremely often disconnected by the router
21:23 sfan5       you should buy a new routers
21:26 millersman  and also switch the dsl provider
21:27 garywhite   Does anyone remember if there's any possible fix for the 0,0,0 bug?
21:27 Shara       garywhite: scroll up and read :)
21:34 paramat     nore sfan5 sofar new biome system is ready you can test it by running https://github.com/paramat/newbiomes details of changes are in first post game#1022
21:34 ShadowBot   https://github.com/minetest/minetest_game/issues/1022 -- Default: New biomes, improve biome points by paramat
21:40 paramat     i'll merge that within a few days
21:41 rubenwardy  are overhanging/3d noise mountains a newish thing, or am I just not following mapgen very well?
21:42 garywhite   Is there any way to fix #4403?
21:42 ShadowBot   https://github.com/minetest/minetest/issues/4403 -- Players helplessly stuck at 0,0,0 for minutes (spawn bug)
21:43 garywhite   I dunno if something is in development, but I think this needs to become some kind of priority cause it seems to be getting worse
21:43 paramat     3D noise mountains have always been in mgv5 and mgv7
21:43 paramat     as well as overhangs and floaty stuff
21:44 garywhite   wb millersman
21:44 paramat     but when i tuned mgv7 a year ago i made mountains higher, so the crazy stuff is more common
21:46 paramat     should the stony sandstone desert have dry shrubs growing on the stone? am unsure
21:47 rubenwardy  http://pasteboard.co/1xBLWbxJ4.png
21:50 Fixer       more amplified
21:52 Fixer       v5 is maximum amplified, v7 - low stuff + amplified
21:52 Fixer       rubenwardy: use valleys :)
22:00 paramat     lovely
22:01 rubenwardy  looks good, paramat. I like all the biomes I've seen so far
22:02 millersman  found a few smaller issues in utility functions like Map::isValidPosition throwing an exception instead of returning false for invalid ones
22:02 paramat     cool
22:03 millersman  should i create a separate PR or just include it in the reflow fix, i only use it for debugging and it won't be called in the final version
22:03 paramat     separate commit, but can be the same PR
22:05 millersman  ok
22:07 paramat     i'll add news in the forum of a forthcoming change in biomes, it will cause straight-edged biome borders
22:07 millersman  i'll also found a strange behavior in transformLiquid: it looks like flowing liquids with level 0 above other flowing liquids prevents proper flowing away of the column
22:08 millersman  will try to find the reason for this, otherwise reflow should be fixed... this was the only issue i could find
22:08 garywhite   Does anyone remember the code for sending text from a luacontroller to a digilines LCD?
22:30 paramat     hi hmmmm please could you add your initial comments to #4774 ? let us know if you want us to wait for your full review, if you intend to do one
22:30 ShadowBot   https://github.com/minetest/minetest/issues/4774 -- Adding particle blend, glow and animation by sfan5
23:04 Fixer       paramat: no more biome blend?
23:05 paramat     biome blend continues
23:05 paramat     was my forum post unclear?
23:07 Fixer       no idea, will read it
23:07 paramat     oh, thought you were reacting to that
23:08 Fixer       paramat: i had no issues with long climbs up if going at high speed, but some random lua lag can potentially cause some unwanted slowdown
23:08 paramat     ok
23:10 rubenwardy  #4806
23:10 ShadowBot   https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy
23:11 rubenwardy  is it possible to programmically expand a tree list?
23:12 rubenwardy  ah tableoptions[opendepth=<value>]
23:13 Fixer       paramat: my guess is add more acceleration?
23:14 paramat     yes
23:15 paramat     after 1-2 hours of editing code that seems the best thing to do
23:16 rubenwardy  opendepth=100 doesn't seem to work
23:16 rubenwardy  maybe I should set selected_setting to the best match somehow
23:17 Fixer       "The 'biome points' (heat point, humidity point) are being changed so on changeover you will get straight biome borders between old and new."
23:17 rubenwardy  added screenshot to #4806
23:17 ShadowBot   https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy
23:18 Fixer       paramat: i'm not sure if it is clear enough about this biome borders
23:20 paramat     will improve
23:26 paramat     done
23:29 rubenwardy  updated #4806 to auto select first result
23:29 ShadowBot   https://github.com/minetest/minetest/issues/4806 -- Add search to advanced settings by rubenwardy
23:30 sofar       boom, 3d torches, yall
23:30 * sofar     merges
23:31 paramat     good
23:32 Fixer       btw
23:32 Fixer       i've played on Liberty Land and it had like custom 0.4.12 game, and I can swore boat aligned with player at placing
23:33 Fixer       so it was probably broken later and fixed again now
23:33 Fixer       sofar: i've played with torches a bit, and they seem fine
23:36 est31       wohoo minetest has actual non broken torches now!
23:38 sofar       now, for thanksgiving, I'm going to be really thankful for having Animated Particle spawners that can glow and are attached to objects!
23:38 sofar       right!
23:38 sofar       right?
23:39 sofar       no?
23:39 sofar       :/
23:39 kaeza       rubenwardy, can you also search in the setting description? the setting (technical) name and (possibly localized) description may have nothing in common
23:39 kaeza       other than that, looks excellent
23:39 rubenwardy  descriptions :PO
23:39 rubenwardy  * :O
23:40 rubenwardy  ah, entry.comment
23:41 kaeza       what I mean is, if say a spanish user searches for "pant[alla completa]" ("full screen"), it finds nothing
23:42 * kaeza     'd also like to suggest "category:graphics" :P
23:43 rubenwardy  added
23:43 * kaeza     tests
23:43 rubenwardy  that would be nice - but quite harder
23:43 rubenwardy  future pr? :P
23:45 est31       kaeza: welcome back btw
23:45 kaeza       rubenwardy, does not seem to work :( http://imgur.com/a/DSDGZ
23:46 kaeza       est31, thank you, but, did I go away?
23:46 kaeza       maybe you meant kahrl?
23:46 est31       you were a bit less active, no?
23:47 rubenwardy  kaeza: are you missing an accent or something? Does "pant" definitely exist?
23:47 rubenwardy  ohhhhhh
23:47 kaeza       est31, a bit yes. busy with IRL stuff
23:47 rubenwardy  it needs to be fgettext(setting.name) not setting.name
23:47 rubenwardy  to deal with translations
23:49 rubenwardy  updated, kaeza
23:50 kaeza       rubenwardy, now it works, but just noticed this: 2016-11-23 20:50:08: ERROR[Main]: MAINMENU ERROR: Runtime error from mod '' in callback handleMainMenuButtons(): ...netest/bin/../builtin/mainmenu/dlg_settings_advanced.lua:372: malformed pattern (missing ']')
23:50 kaeza       input string is "[]"
23:51 kaeza       you should probably call `string.find` with `pcall`
23:51 kaeza       or just pass true as third arg to force plain substring search
23:52 kaeza       eh, fourth arg, rather: string.find(haystack, needle, start_pos, plain)
23:54 rubenwardy  why is lua so special
23:56 kaeza       what? don't tell me setting global variables by default, string search using patterns by default, and lack of true integers aren't useful