Time  Nick           Message
00:46 paramat        testing #4745 seems to show not much reduction in mesh updates, so i'm feeling all 'meh' about this now
00:46 ShadowBot      https://github.com/minetest/minetest/issues/4745 -- Digging crack animation: Make crack animation optional by paramat
00:55 paramat        i'll let it sit for a while as low priority
00:56 garywhite      I do think it'd be a good idea, reduce client resources a bit, but I don't think it's needed in 0.4.15
01:06 paramat        surprisingly the reduction in mesh updates is almost insignificant
01:08 OldCoder       <paramat> no need, we already always notify people
01:08 OldCoder       Those announcements include API changes, paramat?
01:08 OldCoder       If so, issue is addressed
01:09 paramat        yes
01:10 est31          I think performance isn't a reason to be in favour of the PR
01:11 est31          I don't like it much
01:11 est31          but it doesn't change the default, so I'm not against it
11:42 celeron55      ok i have a seguttions can u make a new site was named www.minetestskins.net
11:42 celeron55      please and make minetest like minecreaft  by making the user need a
11:42 celeron55      minetest account for playing server and chossing skins on
11:42 celeron55      www.minetestskins.net
11:43 celeron55
11:44 celeron55      let's just add this new word to the english language: seguttion
11:44 celeron55      it's like a suggestion, but definitely bad
11:57 red-001        could someone review #4472?
11:57 ShadowBot      https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001
12:49 Krock          celeron55, is that one of your inbox messages?
12:51 Krock          red-001, LGTM
14:18 FallingBugs    wth..... red plants in minetest?
14:19 FallingBugs    sofar: i think that indexed colours change added a bug
14:19 FallingBugs    https://i.imgur.com/GZJ2Le3.png
14:34 FallingBugs    https://github.com/minetest/minetest_game/issues/1397
15:46 Krock          FallingBugs, maybe you should know that long punches are more powerful
15:46 FallingBugs    Krock: maybe, but it still crappy in action
16:25 nrzkt          #6
16:25 ShadowBot      https://github.com/minetest/minetest/issues/6 -- Apples on the trees can not be eaten
16:25 nrzkt          oops sorry :)
18:37 paramat        game#1397 i'll revert the texture changes later if no objections
18:37 ShadowBot      https://github.com/minetest/minetest_game/issues/1397 -- Visual regression after indexed images merge
18:39 paramat        ^ sofar nore sfan5 rubenwardy
19:40 paramat        also i'll quickly fix overly-loud tool break sounds
21:23 paramat        sofar https://github.com/minetest/minetest_game/issues/1397#issuecomment-261739872 i'll get to work on this suggestion if no objections
21:26 sofar          weird though
21:26 sofar          wasn't even auto converted, I just changed the mode in gimp
21:27 sofar          indeed when I flatten aspen leaves the alpha pixels turn to a color, but it's black?
21:27 sofar          sorry, green
21:32 sofar          paramat: can you try this version?
21:32 sofar          http://i.imgur.com/freXpXz.png
21:34 sofar          I wonder if optipng can just fix it automatically
21:37 paramat        ok will try it
21:37 Brikooba       paramat: I tried to clone your repository for swimsounds and I think something is wrong.
21:37 Brikooba       --with my clone.
21:37 paramat        it needs rebase
21:38 paramat        so testing my PR may be problematic
21:40 paramat        sofar yes that aspen texture has no bug
21:40 sofar          so that's saved without the 'color for transparent pixels' option in gimp
21:41 sofar          but, try just running optipng on them
21:41 sofar          I think that does the same thing
21:41 sofar          and may be easier
21:41 sofar          tbh I can't see from the screenshots what the problem entirely is, rails?
21:42 paramat        i can't see a problem with rails
21:42 WaterReflowBug i will explain
21:42 WaterReflowBug look at grass - it turns to red at far distance
21:42 Brikooba       1 problem is with my clone and i figured it out.
21:43 paramat        red and blue
21:43 WaterReflowBug rails - turn to green or dirty - before index change it was turning to black
21:43 sofar          ah
21:43 sofar          heh, so it was wrong before as well
21:43 WaterReflowBug no
21:43 sofar          WaterReflowBug: can you run optipng on them?
21:44 WaterReflowBug no
21:44 sofar          see if that helps?
21:44 WaterReflowBug or
21:44 WaterReflowBug maybe yes
21:44 WaterReflowBug sofar: rails looked good before indexed change, now they look wrong
21:45 WaterReflowBug found optipng bins
21:45 paramat        leaves have to be done manually, programs tend to set the opaque colour wrong
21:45 sofar          they just happened to mipmap to the right color by chance
21:45 paramat        yeah possibly
21:46 paramat        i started using mimap a few weeks ago, and have noticed alpha textures looking odd in the distance
21:46 paramat        but assumed that was expected
21:46 paramat        they may have been bugging out but to a not so problematic colour
21:47 paramat        so perhaps indeed all alpha textures must be RGBA
21:48 paramat        anyway, lets not base our textures on these buggy ones, revert alpha textures first
21:48 Brikooba       I got it now.  Sounds nice. It is a little low compared to footstep sound.
21:48 WaterReflowBug grass 3 4 5 and side optimised, will see
21:48 paramat        yeah might need a little more gain
21:48 Brikooba       It's good.  A touch louder would be better, i think.
21:48 WaterReflowBug 1 and 2 already optimised
21:50 WaterReflowBug sofar: won't help, still red
21:50 sofar          ok, so optipng doesn't remove the alpha pixel color
21:50 sofar          now we just need a list of files affected
21:50 WaterReflowBug https://i.imgur.com/NodChPv.png
21:51 WaterReflowBug i have no idea what is affected, could be everything
21:51 sofar          my eyesight isn't bad, but can you make larger screenshots? lol
21:51 sofar          I know how to fix it now
21:51 WaterReflowBug sofar: ctrl+scroll
21:51 sofar          ctrl-scroll makes it fuzz :P
21:51 WaterReflowBug you will recognise
21:51 WaterReflowBug looks like alpha channel is red
21:51 sofar          it's not actually, I think
21:52 WaterReflowBug or entirely
21:52 sofar          it's light green actually
21:52 Brikooba       Do you want to remove alpha channel on some images?  I've done that from command line.
21:53 Brikooba       Level -o4 is good for optipng.  If you want to burn much CPU, sure go higher.
21:53 WaterReflowBug i did optifine -v *.png
21:54 Brikooba       If you have a cloud computer and don't pay for CPU, you can go brute force all combinations.
21:54 Brikooba       optifine, i don't know yet.
21:55 paramat        so, it's 'save colour from transparent pixels' which is the issue?
21:55 sofar          yup
21:55 Brikooba       What does optifine do?  I see it is related to minecraft.
21:55 paramat        the gaps in leaves need to change to the correct colour when 'opaque', be careful with that
21:55 sofar          Brikooba: optipng
21:56 sofar          Brikooba: optifine is a minecraft hack, unrelated
21:56 WaterReflowBug https://i.imgur.com/N2TYh3k.png when I zoom in, notice reddish part in the middle of grasses (put your glasses on)
21:56 sofar          WaterReflowBug: optipng, not optifine
21:56 WaterReflowBug optipng
21:57 sofar          paramat: so grasses, aspen leaves, rail?
21:57 paramat        yes grass close up shows red if one of the planes is at a small angle to view
21:57 paramat        sofar all alpha textures will need fixing
21:57 WaterReflowBug btw
21:58 WaterReflowBug i've noticed default rail takes longer to dig in creative
21:58 Brikooba       WaterReflowBug: default level is -o2.  difference is o2 does filters 0,5 ; o4 tries filters 0-5.
21:58 WaterReflowBug i thought that was fixed
21:58 paramat        leaves though may have to be RGBA due to the gaps needing a certain colour when 'opaque' is used
22:05 paramat        actually, no, because your aspen leaves texture i tested was ok
22:06 paramat        so to clarify. we can use indexed for all textures, but textures using alpha must not 'save colours from transparent pixels'
22:06 sofar          opaque changes alpha pixels to black I think
22:06 paramat        black is fine for the gaps in leaves in opaque mode
22:07 paramat        i think most leaves do that already, apart from aspen
22:07 paramat        thisis going to be a huge job
22:08 WaterReflowBug why not just reverting this textures back
22:08 WaterReflowBug those
22:08 paramat        i suspect this bug has been present for a while, but was not noticed because the 'bug colour' was not red
22:10 paramat        sofar shall we revert the alpha textures first, to partly fix this quickly?
22:10 paramat        the non-alpha textures are ok afaik
22:18 paramat        sofar it seems to me that all MT textures that use alpha will need to be resaved without 'save colour from transparent pixels', because it is impossible to tell if they were saved correclty originally, and because the bug may be present but visually unnoticeable
22:21 paramat        for now i'll fix tool break gan
22:21 paramat        (gain)
22:26 paramat        ha i've just noticed the bug is present for dry grass, we just didn't notice it before
22:26 paramat        dry grass has been buggy for a year
22:26 paramat        with mipmap on
22:30 paramat        hm resaving as i mentioned didn't fix them though
22:34 paramat        resaving as RGBA does fix them
22:37 paramat        sofar ^ RGBA is necessary after all, it fixes the bug with or without 'save colours from transparent pixels'
22:37 paramat        i just fixed dry grass this way
22:39 paramat        so all indexed alpha textures must be converted to RGBA
22:40 paramat        this can be partly done by reverting the alpha textures just changed (copy them into a PR from an older version)
22:41 paramat        then we can change the others later
22:47 sofar          paramat: I've been looking at auto converting them, but, kids...
22:47 paramat        ugh auto ..
22:48 sofar          reverting is fine, I'm ok with that
22:48 sofar          I can re-fix the invalid srgba profile anyway on a case-by-case bassis
22:48 paramat        i shall revert the alpha ones then
22:49 paramat        within an hour or so
22:49 WaterReflowBug sofar: make kids do it
22:49 WaterReflowBug done
22:50 paramat        lol
22:51 sofar          I wish
22:52 sofar          my 2yr old can barely properly use a tablet, so, not gonna happen any time soon
22:52 sofar          the other 2 aren't into hacking stuff yet
23:00 paramat        #4796
23:00 ShadowBot      https://github.com/minetest/minetest/issues/4796 -- Tool break: Reduce gain of break sounds by paramat
23:01 paramat        i'll revert those textures now
23:12 sofar          great time for freesound.org to be slow as tar
23:35 paramat        game#1398 quick test then will merge
23:35 ShadowBot      https://github.com/minetest/minetest_game/issues/1398 -- Textures: Revert many back to RGBA to fix visual bug by paramat
23:35 sofar          :+1:
23:36 sofar          ugh, I totally know what sound I want for carts, I just can't find it anywhere :()
23:39 paramat        will merge game#1390 too in a moment
23:39 ShadowBot      https://github.com/minetest/minetest_game/issues/1390 -- Boats: Fix Boat yaw when entering boat by pilino1234
23:47 paramat        now merging
23:50 paramat        merged. i'm at 197 commits to game
23:51 paramat        190 in engine, trying to pass 200 in both before release
23:53 sofar          I think I may have found a nice sample for carts!