Time Nick Message 00:18 sofar T4im: just a relatively small circle with a few carts without passengers going around and aroung :) 00:18 sofar still pondering how to do sounds nicely 00:32 paramat i don't think riding sounds are essential, maybe that should wait for clientside mods, but if you do, tenplus1's lightweight ambience mod seems to have a possibly good method for continuous ambience type sounds 00:44 sofar well, even rail placement sounds are missing right now 00:44 sofar so, that at least we should fix 01:38 paramat yeah certainly placement sounds 01:44 sofar footsteps maybe as well, if it actually uses them 01:44 sofar think I can just hook the default metal sounds 01:47 paramat btw i've found a sound for flint and steel, will get that done for 0.4.15 02:18 paramat updated #4573 02:18 ShadowBot https://github.com/minetest/minetest/issues/4573 -- Damage flash: Reduce alpha. Avoid fade overload by paramat 02:18 paramat that's ready to go now 05:27 red-001 why do people dislike globles in lua? 05:29 nrzkt like people dislike it in C/C++ 05:53 garywhite goodnight 18:28 nrzkt does sofar or sfan5 has time for #4612 ? :( 18:28 ShadowBot https://github.com/minetest/minetest/issues/4612 -- Player class cleanup / PlayerSAO - LocalPlayer ownership by nerzhul 18:28 nrzkt thanks in advance :) 18:28 sofar I wish :) 18:28 sofar maybe during lunchtime in a bit 18:29 nrzkt thanks sofar i need this and maybe some other devs too this permit to have a more clear server side playerSAO object than before, maybe permitting to do more things in the future :) 18:29 nrzkt maybe i will get some time at a moment to finish #4155 18:29 ShadowBot https://github.com/minetest/minetest/issues/4155 -- Implement player attribute backend by nerzhul 18:30 Foghrye4__ nrzkt, be a man and merge this already, before it will need a rebase #4611 18:30 ShadowBot https://github.com/minetest/minetest/issues/4611 -- Fix crash on attaching player to entity by Foghrye4 18:31 sofar yeah, your patches open up a lot of good opportunities 18:31 red-001 could someone review #4472 ? 18:31 ShadowBot https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001 18:34 sofar I dunno, 4611 looks fine to me, but I don't see how it fixes the bug :) 18:36 Foghrye4__ sofar, a bug itself caused by assertion call on setting id twice for players. By avoiding calling everything under m_is_player condition it avoid calling assertion. 18:37 sofar ok, I suspected something like that... maybe I just read too fast 18:39 Foghrye4__ And it still save positive effects of previously merged bugfix, preventing attached player models from dissapearing. 19:16 red-001 updated #4642 19:16 ShadowBot https://github.com/minetest/minetest/issues/4642 -- Allow the join/leave message to be overridden by mods. by red-001 19:38 rubenwardy #4647 19:38 ShadowBot https://github.com/minetest/minetest/issues/4647 -- Builtin: Add vector.floor helper function by rubenwardy 19:41 luizrpgluiz can make a block that only one player can see it? for example, only the owner of that block can see it? 19:42 luizrpgluiz or that block is impossible to do? 19:43 red-001 thats impossible as of now 19:44 red-001 what do you need it for? 19:45 luizrpgluiz I'm trying to do a land protection block 20:00 FirePowi Hi here ! I wish to translate some Minetest engine strings, like "Access denied. Reason: " from game.cpp. But that particular string has no "gettext" nor "wgettext" nor "strgettext" and I don't know what are the diffences between those three. May I have some help about "gettext"s functions, please ? 20:01 nrzkt wgettext is for wstrings 20:03 FirePowi so only for "showOverlayMessage" and "wchar_t" and "wstring" texts ? Ok :-) 20:04 nrzkt sofar thanks for your review. If you can do a more investigating issue tell me if it's okay for you then i can merge :) 20:04 red-001 Shouldn't access denied be replaced with a better message at some point? 20:04 red-001 it isn't really correct 20:04 nrzkt red-001, yes, but it's difficult atm 20:05 nrzkt access_denied is also for shutdowns etc 20:05 sofar nrzkt: yeah, perhaps add unittests? 20:05 nrzkt sofar, on which part you want unittests ? it's hardcore to do on playerSAO and remoteplayre 20:06 red-001 it's only correct when it's displayed when connecting to a server 20:07 FirePowi nrzkt, so between strgettext and gettext, there are differences ? When should I use each one, please ? 20:08 sofar nrzkt: I dunno, just thinking out loud :) 20:09 FirePowi Oh… strgettext(text) => gettext(text.c_str()) 20:09 nrzkt FirePowi, yes 20:10 nrzkt sofar, but i'm for unit tests, but on this case it's complicated because our process is not very simple 20:10 nrzkt maybe i can extract save/load player, i could add this test 20:16 FirePowi So… I have to deal with pointers. It's been a while :o 21:53 Fixer anyone wants to rotate some signs? 21:58 sofar mtg signs? 22:01 sofar they don't seem to rotate at all 22:05 T4im they aren't facedir, are they? 22:05 sofar wallmounted 22:06 sofar should I dismiss other people 22:06 sofar 's reviews? 22:06 sofar or should I let them dismiss/close their own reviews? 22:07 T4im do you mean review errors? 22:07 sofar sfan5 posted a "review" to my torch patch 22:08 T4im ah, you mean the "suggested change" that, despite change didn't turn approved? 22:08 sofar I fixed it up, but there's no way to ping sfan5 and say "this was fixed" 22:08 T4im hmm yea 22:08 sofar so I just "dismissed" the review 22:08 sfan5 it's ok 22:08 sofar but I'm not sure that's appropriate, it feels dirty :) 22:12 T4im wait till you get into the position to have potentially dismiss for third party pr's ;) 22:12 T4im if that indeed is persistent until re-approval 22:25 Fixer sofar: yes, mtg signs 22:25 sofar Fixer: they don't rotate, so, what's the problem? 22:25 Fixer sofar: say I want to place it on the table and look like keyboard, but it looks like notepad instead 22:31 paramat too bad, rotate your table :] 22:32 T4im Fixer: that's like wanting bone textures to look different, so you can build streets; it's kudos for creativity, but you if it doesn't work, or breaks one day, you shouldn't be surprised, as it was never meant for that 22:33 Fixer T4im: i don't mind about bone textures 22:34 Fixer paramat: not acceptable 22:34 Fixer paramat: i want my table to stand right there 22:36 Fixer i see "Revert changes to toggleNoClip and toggleFreeMove", is this intended? 22:36 paramat now looking 22:42 paramat ugh those should have been squashed on merge 22:43 Fixer paramat: nevermind, i was confused, it cleared up 22:43 Fixer paramat: i was thinking entire PR was reverted 22:43 paramat yeah it's intended 22:44 Fixer compile time 22:44 sofar savePR4530: I wouldn't mind making signs rotatable... 22:48 savePR4530 sofar: ladders also bothered me 22:48 savePR4530 but I have workarounds to place them as I need 22:48 savePR4530 horizontally or else 22:49 paramat eh horizontal ladders can be a mod thing 22:53 savePR4530 they are already horizontal, but not supported by screwdriver 22:53 paramat oh yeah 22:54 savePR4530 don't even think about disallowing horizontal ladders 22:55 savePR4530 crude example: https://i.imgur.com/YeDAZuG.png 22:56 paramat i won't, it would be more work :] 22:59 T4im fixer: https://xkcd.com/1172/ 23:00 savePR4530 T4im: you need to provide creativity for MTG 23:01 savePR4530 our white blocks as of now: https://i.imgur.com/kERYlQr.png 23:01 paramat sfan5 sofar rubenwardy #4573 has been updated 23:01 ShadowBot https://github.com/minetest/minetest/issues/4573 -- Damage flash: Reduce alpha. Avoid fade overload by paramat 23:01 savePR4530 find new coral one 23:01 savePR4530 and silver sand 23:02 savePR4530 coral one is very good for white walls 23:03 paramat rubenwardy #4632 any comments? 23:03 ShadowBot https://github.com/minetest/minetest/issues/4632 -- Builtin/../falling.lua: Do not call nodeupdate() on node punch by paramat 23:04 T4im i honestly still haven't understood why you actually want to remove it :D too big of a danger for players to bury themselves in? 23:06 savePR4530 paramat: do you think this horizontal ripples should be removed from those squared blocks? https://i.imgur.com/JBbHGiJ.png 23:06 savePR4530 i mean vertical right now 23:06 savePR4530 to make them more uniform in centers 23:06 savePR4530 edges are good 23:07 savePR4530 sandstone is not affected much though 23:13 red-001 could someone add a command to minetest bot for linking to https://xkcd.com/1172/ ? 23:23 paramat they seem ok, i wouldn't want to touch such a classic texture 23:24 paramat i had not noticed the centres until now 23:26 paramat obsidian is especially good as it is