Time  Nick       Message
00:04 Hijiri     #4409
00:04 ShadowBot  https://github.com/minetest/minetest/issues/4409 -- Attached Particle Spawners by raymoo
05:39 nrzkt      merged two PR approved by sfan5 and me this morning
10:44 YuGiOhJCJ  hello, is there an option to force the building process of Minetest to stop the building process when LuaJIT is not found? Currently it is just writing this message: "-- LuaJIT not found, using bundled Lua."
10:46 YuGiOhJCJ  something like '--with-system-luajit' to force using the system LuaJIT
10:46 celeron55  2>&1 | grep -q 'bundled Lua' && exit 1
10:46 celeron55  i.e. i don't think there is
10:46 YuGiOhJCJ  OK
10:47 celeron55  i guess a PR that adds a cmake flag for that might be accepted
10:47 YuGiOhJCJ  PR?
10:48 celeron55  https://help.github.com/articles/about-pull-requests/
10:48 YuGiOhJCJ  OK
10:50 YuGiOhJCJ  if I am not lazy maybe I will :p
12:59 YuGiOhJCJ  celeron55, done: https://github.com/minetest/minetest/pull/4622 I am not so lazy :D
13:00 celeron55  it should probably be called FORCE_SYSTEM_LUAJIT
13:01 celeron55  seems fine otherwise
13:01 YuGiOhJCJ  should I rename it or someone will do it?
13:02 celeron55  it's easiest if you do it
13:03 YuGiOhJCJ  OK
13:21 YuGiOhJCJ  celeron55, I think its done
13:26 YuGiOhJCJ  ShadowNinja suggested "REQUIRE_LUAJIT"
13:26 YuGiOhJCJ  so I am not sure should I use "FORCE_SYSTEM_LUAJIT" or "REQUIRE_LUAJIT"?
13:27 Krock      the one with "SYSTEM" is more percise IMO
13:32 YuGiOhJCJ  OK so I let it like that
16:28 PR0000     why hasn't anything been done about #3900?
16:28 ShadowBot  https://github.com/minetest/minetest/issues/3900 -- Add a button for disabling all mods to world config. by red-001
16:44 Zeno`      PR3900, do people need it?
16:46 Zeno`      it could be made simpler, but I approve
16:47 Zeno`      hmmmm, can I merge that?
16:49 Zeno`      I probably can, it's trivial
16:53 Zeno`      seems the apple build is failing though
16:54 Zeno`      not sure wtf it has to do with this PR though :/
16:58 hmmmm      huh?
16:59 hmmmm      merge what
17:00 Zeno`      trivial disable all mods button
17:00 hmmmm      is it wanted by the users?
17:00 Zeno`      I've restarted the travis build
17:00 Zeno`      I dunno, but it makes sense to have it if we have "enable all mods"
17:00 hmmmm      we do?
17:00 hmmmm      oh definitely then
17:01 hmmmm      who is in charge of the UX design in minetest
17:01 hmmmm      we need to fire them
17:01 hmmmm      one of these days zeno!
17:03 hmmmm      Zeno`:  the formspec stuff inside of the "if enabled_all then ..." looks pretty repetitive to me
17:03 hmmmm      that's my only nit with that PR
17:03 hmmmm      otherwise looks good
17:06 Zeno`      yeah that's what I meant by "it could be simpler"
17:06 Zeno`      but I think it's better just to merge it for now
17:07 Zeno`      I'll wait to see if the clang build passes this time but I'm not sure if the unit test is even applicable to this PR
17:08 Zeno`      (clang for OSX... it failed on something to do with threadId == thread
17:09 hmmmm      bah that same darn unittest
17:09 hmmmm      somebody attempted to fix it before but i guess it didn't work
17:09 Zeno`      oh, it's a known unit test issue?
17:09 hmmmm      yep
17:10 Zeno`      ok, I'll just merge then
17:11 Zeno`      travis doesn't seem to want to schedule the job anyway heh
17:11 Zeno`      done
18:26 paramat    "PR0000 why hasn't anything been done about #3900?" obvious, the usual reason :]
18:27 ShadowBot  https://github.com/minetest/minetest/issues/3900 -- Add a button for disabling all mods to world config. by red-001
18:53 paramat    remember this optimisation by RBA? #3848 est has asked for someone to take over on this
18:53 ShadowBot  https://github.com/minetest/minetest/issues/3848 -- Send only changed node metadata to clients instead of whole mapblock by est31
18:54 Krock      all what's needed is some finetuning, right?
18:55 red-001    thats how it always starts
18:55 paramat    not sure, there's also a comment about a protocol issue
18:56 Krock      yes, it will require a protocol increase
18:58 paramat    sfan5 rubenwardy i've improved game#1320 and added docs, do you still approve?
18:58 ShadowBot  https://github.com/minetest/minetest_game/issues/1320 -- Bucket: Add optional 'force-renew' bool to registration by paramat
19:04 Krock      sfan5, apart from the fact that the code is changed - the functionality is the same ( https://github.com/minetest/minetest/pull/3848/files#r82533295 )
19:05 Krock      why do you think it would be better to keep the old code?
19:05 paramat    proposed new biome system https://github.com/minetest/minetest_game/pull/1022#issuecomment-252805539
19:07 Krock      how does it merge with the current existing worlds? I bet this would cause some ugly borders
19:07 Krock      but there's not much you can do against this
19:08 paramat    yeah straight edged biomes
19:08 red-001    #4472
19:08 ShadowBot  https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001
19:09 Krock      red-001, tab_multiplayer.lua L30 is also a squashed if-then-end line.
19:09 paramat    so i'll be testing this thoroughly and making one change before release, instead of gradual changes
19:09 Krock      I personally don't like those and I think the people here agree with that
19:10 Krock      we'd also need some kind of versioning system for mapgens
19:10 paramat    sure, but biome system is unstable and needs improvement
19:10 Krock      but I might be a bit early with that idea
19:11 red-001    well you might want to consider updating the wiki page http://dev.minetest.net/Lua_code_style_guidelines
19:11 paramat    all mapgens except mgv6 are in version 'unstable' :]
19:12 Krock      I haven't seen a change in mgv5 for weeks
19:12 red-001    : |
19:12 paramat    mgv7 terrain is fairly stable now though
19:12 paramat    oh yeag mgv5 too
19:12 paramat    (yeah)
19:12 Krock      people keed forgetting about it. It's the best mapgen apart from valleys
19:12 Krock      *keep
19:13 red-001    I think it's too abstract
19:13 paramat    flat terrain is stable ha
19:13 red-001    flat terrain++ - even more flat
19:13 Krock      red-001, oh well. looks like it's allowed o.0
19:14 Krock      anyway, testing the pull now
19:15 red-001    suggestions on how to document the filters are welcome
19:16 * Krock    begins with the text:  "test php:on "
19:16 * Krock    turns around and slaps himself
19:17 paramat    part of #4620 is controversial, could do with more dev input
19:17 ShadowBot  https://github.com/minetest/minetest/issues/4620 -- Optimize falling.lua by tenplus1
19:17 red-001    It should show you all the servers with 'test' and 'php:on' in it
19:19 red-001    could someone on thats on android test #4472 ?
19:19 ShadowBot  https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001
19:22 Krock      red-001, it's supposed to say "pvp:on", not "php", as I wrote by accident
19:23 * red-001  *
19:23 Krock      Minetest keeps crashing on my Android, can't test it.
19:23 Krock      but the scaling works fine, so I think this shouldn't be a problem
19:37 red-001    Krock It would be nice to get some input on how the search orders servers
19:38 Krock      aren't they sorted the same way as before?
19:39 Krock      oh. favourites aren't on the top anymore
19:43 red-001    yeah it orders then according to how many keywords are found in the name/description
19:44 red-001    keywords in the name are twice as important
19:45 red-001    then the postion on the server (from the bottom) is divied by five and added
19:46 red-001    serverlist*
21:18 paramat    i'l merge game#1320 later if no objections, it has been updated though
21:18 ShadowBot  https://github.com/minetest/minetest_game/issues/1320 -- Bucket: Add optional 'force-renew' bool to registration by paramat
21:29 Krock      +1
21:38 paramat    i'll complete the docs for game#1078 and merge that too
21:38 ShadowBot  https://github.com/minetest/minetest_game/issues/1078 -- Store registered plant on namespace by bas080
21:39 paramat    sofar game#1285 has been updated with your request
21:39 ShadowBot  https://github.com/minetest/minetest_game/issues/1285 -- Destroy flammable items when in fire or lava by Ferk
21:47 paramat    game 1078 didn't apply despite 'no conflicts'
21:49 red-001    does string.trim only remove trailling whitespaces?
21:50 red-001    and leading
21:50 red-001    or does it also remove tabs,newlines,etc
21:50 rubenwardy tabs and newlines should count as whitespaces
21:50 rubenwardy and so remooved
21:52 red-001    is there any reason to use it over using gsub("%s", "") to remove spaces?
21:52 rubenwardy more readable code
22:51 rubenwardy red-001, reviewed #4472 for you :)
22:51 ShadowBot  https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001
23:11 rubenwardy paramat, merging game#1078 in a few minutes with documentation...
23:11 ShadowBot  https://github.com/minetest/minetest_game/issues/1078 -- Store registered plant on namespace by bas080
23:11 paramat    thanks
23:34 sofar      rubenwardy: thanks
23:58 Hijiri     daily reminder: #4409
23:58 ShadowBot  https://github.com/minetest/minetest/issues/4409 -- Attached Particle Spawners by raymoo
23:59 Hijiri     how will I have anime magic without particle effect
23:59 Hijiri     s