Time  Nick      Message
08:48 tenplus1  Hi folks, could a nice dev please look at game#1286 and give an opinion :)
08:48 ShadowBot https://github.com/minetest/minetest_game/issues/1286 -- Dynamic Dirt to Grass changes by tenplus1
09:56 tenplus1  hi nrz
13:20 gregorycu So, how's my commit doing?
13:36 est       gregorycu: its doing well afaik
13:36 est       idea was to wait one week to let testers ensure there are no bugs
13:36 est       and then to merge it
13:36 gregorycu Hooray \o/
13:37 est       that would be tuesday next week
13:38 est       otherwise it looks good from what I can tell
14:26 sfan5     est: made the macros multiline, take another look
14:27 est       sfan5: thanks, they look much better now
16:55 Fixer     missed upsidedownman
16:55 Fixer     I have not encounter any bugs with PR4530
16:57 Fixer     anyone wants to fix falling and sneak related bugs? I've created yet another issue for that
16:58 Fixer     and that "take bone" after death button formspec thingy (tm)
17:20 Fixer     client-side physics can be used for mobs as well?
17:24 est       no
17:25 est       you cant even use them for knockback afaik
17:27 celeron55 client-side entity control would be a separate thing
17:44 Hijiri    not sure what client-side physics is referring to here
17:47 celeron55 my feature branch i guess
17:48 Fixer     https://github.com/celeron55/minetest/tree/client_player_physics_script this one?
17:48 Hijiri    oh, I see
17:49 Hijiri    is that the one with camera roll
17:49 celeron55 haha, "the thing with camera roll"
17:49 celeron55 i think i
17:49 celeron55 +'ll refer to it as that from now on
17:53 OldCoder  Sure y not
17:55 est       I think i want to try it out
17:55 est       together with a joystick
17:57 est       err gamepad
17:58 est       the may not even work commit doesnt compile
17:58 est       trying the one before that,
17:58 est       that does compile
18:05 est       yeey it works
18:21 sfan5     anyone else here to look at #4541 or #4432
18:21 ShadowBot https://github.com/minetest/minetest/issues/4541 -- Rewrite keycode handling (keycode.cpp) by sfan5
18:21 ShadowBot https://github.com/minetest/minetest/issues/4432 -- Set infotext for dropped item stacks. by Rogier-5
18:47 Fixer     ohhh
18:47 Fixer     4432 is big for me
18:47 Fixer     well kinda big
18:47 Fixer     useful >_>
21:56 nrzkt     i don't know if you see but now changes could be approved by github workflow without using labels, maybe we should use it :)
21:56 nrzkt     celeron55, maybe you can add the two approvals requirement on github repository :)
22:46 red-001   could #3804 be closed as the feature got implemented?
22:46 ShadowBot https://github.com/minetest/minetest/issues/3804 -- Make base64 encoding/decoding available for lua mods
22:47 Fixer     i've just realised... minetest game does not "killed by" message..... in game
22:47 Fixer     does not have*
22:47 red-001   ?
22:48 red-001   does another subgame have one?
22:49 Fixer     not sure
23:16 Hijiri    it would be a bit hacky to implement since death and health callbacks have no cause information
23:16 Hijiri    you would have to mark the time a player got punched by someone and see if their health went to 0 in the same tick (check if gametime has increased)
23:17 Hijiri    or something similar to that, at least
23:17 Hijiri    Alternatively, you could write a mod that hijacked all the health and punch handling and used custom punch handling code for every punch
23:38 xunto     Fixer: freeminer has, as I know.
23:39 xunto     Fixer: https://github.com/freeminer/freeminer/blob/5588f109f4140d5afb4cda38e083ab2ac6a10129/builtin/game/register.lua#L557-L580
23:41 xunto     Oh... I misunderstood... You mean "You killed by %player name%".