Time Nick Message 00:50 Hijiri #4488 00:50 ShadowBot https://github.com/minetest/minetest/issues/4488 -- Document the "user" parameter of on_use callbacks of items 05:18 paramat i like the Minetest marketing video 05:18 est31 ? 05:27 paramat https://www.youtube.com/watch?v=TD1TVZ47xZY not seen? 05:32 est31 no 05:32 est31 not yet 05:33 est31 lol 09:04 Hijiri I think I've made my longest github post yet 09:10 est wow. that one is really long 09:11 est (if anyone wonders: its https://github.com/minetest/minetest/issues/4428#issuecomment-248245395) 09:54 Hijiri I feel relieved finally posting it, I was sitting on it half-complete for a while 11:42 gregorycu Sup slackers 11:43 gregorycu Yes ShadowBot, a little bit of luck 12:00 est gregorycu: hello 12:10 gregorycu Man, I was just about to use CRTP 12:11 gregorycu But that might blow people's minds 12:12 Fixer hi gregorycu 12:13 gregorycu Hello 12:13 Fixer welcome back 12:14 Zeno` go away 12:14 gregorycu Cheers bro 12:14 Zeno` :) 12:14 gregorycu x2 12:18 Zeno` gregorycu, shouldn't you be asleep? 12:19 gregorycu It's 10:19 12:19 gregorycu I'm coding for 5 minutes, then it's Supreme Commander until about 2am 12:20 Zeno` whoa 12:24 Zeno` "Presumably so the sky object can be updated and have that reflected inside the shader" 12:24 Zeno` nah, it's so that the Sky object can be reallocated entirely 12:25 Zeno` but the pointer to pointer is correct 12:25 Zeno` anyway apart from outstanding comments I think #4530 looks ok. Needs testing though I guess 12:26 ShadowBot https://github.com/minetest/minetest/issues/4530 -- Fix superflous shader setting updates by gregorycu 12:27 Zeno` I think the thing that annoys me most is the factory pattern way of doing things 12:27 Fixer i know that i can trigger light bug with restart... did 30 restarts already and seen no bugs, running it for >10 hours with this PR, good so far, I will torture it for one week and will probably declare it stable for me 12:27 Fixer just give me some time 12:28 Zeno` maybe not even the pattern itself. Just the name annoys me lol 12:28 Zeno` it's so "java-esque" 12:28 est +1 12:29 Fixer but speed is so damn good 12:30 gregorycu We've discussed the factory pattern in code reviews and in this channel 12:31 gregorycu I've defended its use here (not generally) 12:31 gregorycu As has ShadowNinja 12:31 Zeno` maybe. I guess it just seems out of place in some weird way 12:31 gregorycu "The factory stuff seems to acutally be necessary to ensure that each shader has it's own CachedShaderSetting though." 12:32 Zeno` if it's the best way to do things in this instance then so be it 12:32 Zeno` I'm not going to make a huge deal out of it 12:32 Zeno` as I said, if tests are ok I'd approve it 12:33 gregorycu I'm just doing est's code review comments now 12:33 gregorycu Then dinner, then gaming 12:33 Zeno` yep saw that. Cool 12:34 Fixer Zeno`: do I need to recompile or changes are cosmetic? 12:34 Zeno` recompile what? 12:34 Zeno` after applying the patch? Yeah you'd need to recompile 12:35 Fixer Zeno`: mt with newer version of 4530 12:35 Zeno` oh I dunno. Better ask gregorycu 12:35 Fixer erm 12:35 Fixer gregorycu: i'm testing first version of 4530 12:35 gregorycu Cool 12:35 gregorycu I'll have changes soon, 5 minutes 12:35 Fixer gregorycu: maybe i need to recompile with corrected one? 12:35 Zeno` it's always best to compile and test after changes though (of course) 12:35 gregorycu You'll need to recompile, just to make sure I haven't fucked anything 12:36 Fixer sure 12:36 Zeno` even if they "seem" cosmetic 12:36 Fixer it is 1 minute of time 12:36 Zeno` yeah, like gcu said 12:36 Fixer my compile environment is automated by script and recompiles only changed parts 12:39 Fixer i wonder if I can test that empty metadata fix on this "Just Test" copy, it probably has lots of garbage in database 12:41 Fixer gregorycu: changes are code style only? 12:41 gregorycu A slight bit of refactoring 12:44 gregorycu Ok done 12:44 gregorycu I'm out, good luck 12:46 est seems fine 12:46 est but I think there should be a week of testing it before it gets to master 12:46 est then its released to the masses 12:47 est and they can test it as well 12:50 Fixer I agree 12:50 Fixer est: i will test it 100% 12:50 Fixer since I play in SP and MP 12:50 est awesome 12:50 Fixer wait 12:50 Fixer i have compilation error 12:51 Fixer http://pastebin.com/raw/iwNMCtPi 12:54 gregorycu Compilation error you say 12:54 Fixer trololo 12:55 gregorycu oh 12:55 gregorycu that moment you rely on a compiler feature 12:55 gregorycu that doesn't exist in the old version 13:00 gregorycu Ok 13:00 gregorycu Give that a crack 13:01 Fixer one sec 13:04 Fixer went through 24% and goes forward 13:07 Fixer 39%, will probably compile 13:12 Fixer gregorycu: success 17:07 Fixer when all shaders enabled: 46 vs 79 fps / +71% fps boost , thats usual numbers 17:13 Fixer 95 fps with just basic shader, 108fps without shaders, in MT without PR4530 basic shader - 57 fps, roughly +40 fps boost 17:17 Krock neat 17:18 Fixer add to this future fix that will disable "tangent spaces" feature (or how it is called), it will be even better 17:18 Fixer for all shaders except bump-mapping and occlusion iirc 17:20 Fixer tried restarting it 220 times (i counted) to catch the bug on that map, no luck, good sign 17:20 Fixer rejoining* 17:21 Fixer will test it in multiplayer gameplay for prolonged time 19:58 sfan5 ptal #4535 19:58 ShadowBot https://github.com/minetest/minetest/issues/4535 -- Update buildbot libraries by sfan5 22:43 cheapie OK, so I see that quite a few mods are using invalid light_source settings... wouldn't it have been better to give a warning than to crash the server when that happens? I had to fix 6 mods just to get *one* world to load. 22:43 Fixer ^^ 22:48 Fixer !tell paramat people have issues with this https://github.com/minetest/minetest/commit/3aefa5d3ceaaa9299f42cc10921dec65fa53c5e0 maybe this kind of error should not be preventing server from starting 22:48 ShadowBot Fixer: O.K. 22:49 Fixer !tell paramat simple warning in console/debug should be enough, that will prevent lots of frustration for players/admins 22:49 ShadowBot Fixer: O.K. 22:50 xunto Maybe warning + lightsource = 0 is better) 22:51 cheapie xunto: Either is fine in my opinion. Something that worked one day crashing the server the next isn't. 23:16 Fixer just warning imo