Time Nick Message 00:29 paramat sofar +1 for slabs PR, i could merge it later but would like to merge game#1288 with it, i wonder if you are able to +1 that? :} 00:29 ShadowBot https://github.com/minetest/minetest_game/issues/1288 -- Default: New snow textures by Gambit by paramat 00:31 sofar yeah, it's a good improvement 00:35 paramat ok 00:37 paramat hmmmm, i updated #4520 with your requests, please can i merge later? 00:37 ShadowBot https://github.com/minetest/minetest/issues/4520 -- Decorations: Allow schematic decorations to use 'spawn by' by paramat 04:19 paramat hmmmmm thanks for review will update PR 04:57 paramat will merge game#1111 game#1288 in a moment 04:57 ShadowBot https://github.com/minetest/minetest_game/issues/1111 -- Big simplification of slabs combination by sofar 04:57 ShadowBot https://github.com/minetest/minetest_game/issues/1288 -- Default: New snow textures by Gambit by paramat 05:03 paramat now merging 05:08 paramat merged. good, seems we're catching up on so-far's work 07:28 paramat hmmmm it may be too late for you to review now, but #4520 is updated, retested 07:28 ShadowBot https://github.com/minetest/minetest/issues/4520 -- Decorations: Generalise 'spawn by' to be used by all decoration types by paramat 07:32 paramat thanks 07:38 paramat meh today i'm at my best at 7am after being up all night 07:51 paramat #4499 seems approved for merge 07:51 ShadowBot https://github.com/minetest/minetest/issues/4499 -- Allow escaping of texture names when passed as an argument to a modifier by sfan5 07:54 paramat ~tell rubenwardy #4294 is approved 07:54 ShadowBot paramat: O.K. 07:57 paramat #4076 is approved but seems forgotten, any reason? 07:57 ShadowBot https://github.com/minetest/minetest/issues/4076 -- Attempt to improve performance by combining 6 vectors into one using a struct by ShadowNinja 07:58 paramat ^ Tesseract 08:00 paramat will merge #4499 and #4520 in a moment 08:00 ShadowBot https://github.com/minetest/minetest/issues/4499 -- Allow escaping of texture names when passed as an argument to a modifier by sfan5 08:00 ShadowBot https://github.com/minetest/minetest/issues/4520 -- Decorations: Generalise 'spawn by' to be used by all decoration types by paramat 08:23 paramat now merging 08:29 paramat merged 17:22 * sofar wakes up (somewhat) 18:54 rubenwardy the css for line comments has changed. Weird 18:55 T4im not just the css, they changed functionality too 18:55 everamzah https://news.ycombinator.com/item?id=12499642 18:55 rubenwardy ah, just seen the "pull request review" thing 18:55 T4im apparently you can now provide approval/change request feedback with comments 19:09 rubenwardy also, there's a new "projects" tab 19:10 rubenwardy omg, profiles have changes too 19:12 rubenwardy https://github.com/rubenwardy/NodeBoxEditor/projects/1 19:27 sofar it seems the search box in my creative game has disappeared today 19:28 everamzah sofar new engine formspec changes 19:28 everamzah it breaks older clients 19:28 sofar rebuilding my game atm :) 19:29 T4im rubenwardy: a kanban :) 19:30 sofar yup, seems to fix that 19:30 sofar rubenwardy: "Attempt to register already registered sfinv page" would be the best text I think :) 19:31 AcidNinjaFWHR oh wow nice changes rubenwardy 19:35 rubenwardy it's problematic how you need a new server (with a bumped formspec version) to stop errors with too many parameters on old clients 19:37 rubenwardy oh, it seems that FORMSPEC_API_VERSION has never actually been bumped 19:38 rubenwardy actually, you can do formspec_version[2] in a formspec to indicate that it has new functionality 19:51 rubenwardy To fix the search box disappearing on old clients, should I: 1) bump formspec version to stop "too many parameter" errors 2) change it so instead of an extra parameter, it's a new formspec element 3) something else? 19:52 rubenwardy I'd say 2), as it also makes it more readable 20:30 paramat #4128 important bugfix, please can ayone review? 20:30 ShadowBot https://github.com/minetest/minetest/issues/4128 -- Fix disappearing attached player model when parent entity leave and when return to client side loaded area by Foghrye4 20:56 paramat any opinions whether code is needed in #4519 or is a warning enough? 20:56 ShadowBot https://github.com/minetest/minetest/issues/4519 -- Builtin: Limit registered node light_source value to 14 by paramat 20:59 AcidNinjaFWHR paramat, how bad is the lighting bug caused by a light > 14 ? 21:01 est31 paramat, the problem ofc is that it disables light sources that go to 15 to enable underground farms 21:01 est31 which some players want to do 21:03 paramat yeah it's a bug that may be used 21:04 est31 its part of the gameplay, no bug for me 21:05 paramat well the lighting behaves very strangely, and 15 is indeed 'reserved for direct sunlight' and shouldn't actually be used 21:05 paramat however i'm ok with just a warning 21:06 paramat ok how about i make it a warning only then merge it? 21:08 est31 yeah 21:09 paramat will do 21:37 sofar paramat: yeah, a warning will do I think 21:40 paramat ok