Time  Nick        Message
12:37 paramat     \o` please can you look at #4442 ? it's a PR for code you approved in #4091
12:37 ShadowBot   https://github.com/minetest/minetest/issues/4442 -- Fix updateFastFaceRow tiling issue by SmallJoker
12:37 ShadowBot   https://github.com/minetest/minetest/issues/4091 -- mesh tiling bug and possible fix
12:40 \o`         paramat, I tested the mesh tiling thing and it worked well
12:41 \o`         oh it's the same code
12:41 \o`         yeah sure.. +1
12:41 paramat     yes identical
12:41 paramat     thanks
12:44 \o`         hopefully I finish my turbidity meter this week so I can give more time to minetest
12:45 paramat     cool
12:45 \o`         I've been distracted learning electronics hehe
13:07 paramat     i think we can assume +1 from hmmmm as he has LGTM'd the code
13:07 paramat     i'll test and merge later
15:53 paramat     rubenwardy and game devs, this one is significant game#1238 the cache must go
15:53 ShadowBot   https://github.com/minetest/minetest_game/issues/1238 -- Default: Optimise and simplify leafdecay ABM, remove cache by paramat
18:43 Fixer       paramat: btw, that results of my poll has not changed much: https://forum.minetest.net/viewtopic.php?f=3&t=15128 with just 32 votes, 56% likes idea to have basic and full versions of mtg
18:46 paramat     ok
18:49 paramat     there's no obstacle to a 2nd subgame, people just haven't worked on it yet :)
18:53 T4im        mtg needs to split up frameworks from gamespecifics first, fixer, and that alone will take a while
18:53 Fixer       it is just observation, you can disregard it
18:54 T4im        you can't reuse the framework-mods in other subgames because of mtg specific assumptions
18:54 Krock       it's a poll but what's going to happen is a different topic
18:55 T4im        if you wanted to reuse doors mod in a candy lollipop nyancat world you would want no steel or wood doors but doors made out of poptards or gingerbread or whatnot
18:55 T4im        so all those actual door registrations should be moved into a "minetest_game" mod or something like that, which depends on doors
18:56 Krock       why not simply make an API modpack?
18:57 Krock       throw all functions in and done
18:57 T4im        it would end up the same, krock
18:57 T4im        :D
18:57 T4im        it would be the doors framework without the doors registration
18:57 Krock       "  \"minetest_game\" mod  " sounds like "let's merge it all into one init.lua file"
19:00 T4im        well the alternative would be what people disliked with the books and papyrus and what not
19:00 T4im        a split in a different direction, that is not helping anyone :D
19:00 T4im        framework split from game content on the other hand would deduplicate a lot
19:30 Fixer       paramat: i see no fps impact in 4442
19:37 paramat     yes as discussed fps gain may be small and dependent on device
19:40 paramat     will merge game#1238 game#1249 v. soon
19:40 ShadowBot   https://github.com/minetest/minetest_game/issues/1238 -- Default: Optimise and simplify leafdecay ABM, remove cache by paramat
19:40 ShadowBot   https://github.com/minetest/minetest_game/issues/1249 -- Faster find snow near sapling by tenplus1
19:46 paramat     now merging
19:49 paramat     complete! down to 28 PRs
19:50 Wayward_One nice!
19:51 Wayward_One now to make the engine match :P
19:54 paramat     now shall we close game#673 (2 disapprovals) in favour of the preferred game#1032 ?
19:54 ShadowBot   https://github.com/minetest/minetest_game/issues/673 -- Make buckets control scheme consistent. by Jordach
19:54 ShadowBot   https://github.com/minetest/minetest_game/issues/1032 -- Allow buckets to run a non-liquid node's on_punch by C1ffisme
19:58 paramat     game#709 has a nice change of 'disable fire' to 'enable fire' which could be split off the first commit. PA is not around so we may need to resubmit this, and the settingstype stuff, ourselves
19:58 ShadowBot   https://github.com/minetest/minetest_game/issues/709 -- Add settingtypes.txt by PilzAdam
20:03 paramat     rubenwardy i think i'll close game673 later if no objections
20:07 rubenwardy  doesn't bother me particularly
20:08 rubenwardy  the thing that bothers me most?
20:08 rubenwardy  apart from the misaligned health bar,
20:08 rubenwardy  #4417
20:08 ShadowBot   https://github.com/minetest/minetest/issues/4417 -- Formspecs: Add text field enter key event, allow fields to disable form close on enter by rubenwardy
20:14 paramat     yeah your formspec stuff, sorry, i've been keeping a distance because i'm not good with formspec
20:15 paramat     but perhaps i'll look
20:17 rubenwardy  I don't like the formspec code very much
20:18 paramat     closed game673
21:04 paramat     game#1255 now tested and seems good
21:05 ShadowBot   https://github.com/minetest/minetest_game/issues/1255 -- Fire: Use 'enable fire' setting instead of 'disable fire' by paramat
21:40 paramat     simple PR needing consideration game#1227
21:40 ShadowBot   https://github.com/minetest/minetest_game/issues/1227 -- fence inventory_image touchup by pithydon
21:57 sofar       I +1'd that one
22:01 paramat     thanks
22:03 alkotob     uhm hello
22:04 alkotob     I'm using the PPA build and I got this error
22:04 alkotob     minetest: /build/minetest-XWO5LM/minetest-0.4.14/src/util/serialize.h:278: void writeF1000(irr::u8*, irr::f32): Assertion `i >= F1000_MIN && i <= F1000_MAX' failed.
22:04 alkotob     Aborted
22:04 alkotob     I was loading a sub-game but I was told this is from minetest's end
22:05 sfan5       yes this is the engine complaining that your floats are funny
22:05 alkotob     curiously I am not using a debug version
22:05 alkotob     but the stable PPA branch
22:05 sfan5       nah we have sanity checks which are basically assertions but for release builds
22:05 alkotob     I see
22:06 alkotob     so this is not the reason for the crash?
22:06 alkotob     because it's crashing hard as soon as the sub-game loads
22:06 alkotob     consistently
22:06 sfan5       it's the outcome
22:06 sfan5       but not the problem
22:06 alkotob     touche
22:07 alkotob     so at the some point i is going out of bounds
22:07 sfan5       not you but any code anywhere in minetest
22:07 sfan5       but this doesn't usually happen so something must be wrong
22:08 alkotob     yes
22:08 alkotob     I'm looking into the sub-game code
22:08 alkotob     i is a for-loop counter
22:08 sfan5       it could be helpful to have a backtrace
22:09 sfan5       the problem should also occurr with a debug build
22:09 alkotob     I'll download the debug build then
22:21 alkotob     ah I have to go
22:21 alkotob     so no debugging tonight
22:22 alkotob     just a note to the logs: the sub-game is rpgtest