Time  Nick       Message
06:27 Hijiri     how do protocol bumps work? Do they get done after every protocol-modifying change? Or only once per release cycle (at the first change that needs it)?
10:44 paramat    merging #4402 in a moment
10:44 ShadowBot  https://github.com/minetest/minetest/issues/4402 -- Decorations: Fix decoration height check errors by paramat
10:49 paramat    merging
10:52 paramat    complete!
10:54 Krock      \o/
19:27 rubenwardy Merging game#1230 in 30 minutes if no objections...
19:27 ShadowBot  https://github.com/minetest/minetest_game/issues/1230 -- Doors: Allow the screwdriver to rotate doors around y-axis. by t4im
19:27 rubenwardy Not sure what the conversion - how long do you wait if the PR has been approved twice?
19:27 rubenwardy *convention
19:37 Krock      Merge it! Make Minetest great again! ;)
19:39 rubenwardy I have a feeling that it's only 5 mins, just to stop multiple attempts to merge at the same time
19:42 T4im       and maybe to give some Dev ex machina a last chance to swoop in?
19:43 est31      rubenwardy, about your status
19:43 est31      first, congrats to you becoming mtgame core dev
19:43 T4im       indeed, congrats :)
19:44 est31      actually, I wonder about whether you now count as coredev for the engine part as well
19:44 est31      or whether not
19:45 Krock      :tada:
19:46 Krock      there was a discussion about that but there was no final decision IIRC
19:47 rubenwardy thanks :)
19:58 juhdanad   May I move ScriptApiItem::pushPointedThing() to c_converter.cpp?
20:02 Krock      if it has a converer function, then yes. Moving functions to nonsense places doesn't improve the readability
20:02 Krock      *converter function
20:04 juhdanad   Yes, it converts a PointedThing to a Lua table.
20:12 rubenwardy Just like to say that I'm not stupid, and so I won't be approving anything I don't understand sufficiently :P
20:14 est31      rubenwardy, well should we regard you as engine dev as well or not. As you said you will only approve stuff you understand, that makes it okay in my eyes to make you a full dev.
20:15 est31      It has worked well for paramat too, who is mostly centered on mapgen and mtgame dev
20:19 est31      Zeno`, Tesseract sofar sfan5 nore hmmmm celeron55, any other dev, I dont know whether you think its needed or not, but paramat afaik has only asked you to decide whether to make rubenwardy an mtgame only dev, and only asked the mtgame team. therefore I ask all of you, do you want to make rubenwardy an engine core dev as well?
20:20 est31      I do.
20:30 sofar      est31: if you get the backlog, I was +1 on rubenwardy for the engine as well
20:31 hmmmm      has rubenwardy made a significant amount of engine changes?
20:31 rubenwardy I don't need to be an engine core dev
20:32 VanessaE   make him one anyway :)
20:33 VanessaE   (really, rubenwardy has always tended to produce good stuff without major bugs)
20:34 rubenwardy 7 bug fixes, 7 minor features, 4 docs, https://github.com/minetest/minetest/commits/master?author=rubenwardy
20:34 VanessaE   so call it a +0.5 from me (since my opinion doesn't qualify for a full +1)
20:37 Krock      rubenwardy, I made 32 commits with +/- the same amount of lines :P
20:38 rubenwardy true, it's not that much really - a core dev focusing on the engine should have more
20:38 Krock      So I wouldn't argue with the commit count
20:47 juhdanad   Could somebody explain me why ScriptApiBase::objectrefGet is protected, please? Is it for security?
20:53 est31      To speak in his favour, all his contributions added something useful to the game
20:54 est31      also, he's helped with lots of reviews
21:19 Hijiri     is there a conventional "null value" people use in minetest for u8 light levels?
21:21 Hijiri     can I just use whatever as long as it isn't 0-15?
21:21 est31      Hijiri, you found that value by trial and error
21:21 est31      I think its a bit different
21:21 Hijiri     I don't mean day/night blended values
21:21 est31      light value was something like: upper 4 bits about day
21:22 est31      lower 4 bits about night
21:22 est31      or something
21:22 est31      s/error/error?/
21:22 Hijiri     I just want to send a light level between 0-15 for lit particles
21:22 Hijiri     or do you think it would be good to allow specifying day and night light levels?
21:23 Hijiri     It doesn't look like particles use day and night light separately
21:23 Hijiri     at least if I am understanding what decode_light does
21:23 Hijiri     decode_light turns a day/night blended value into a flat light value right?
21:23 Hijiri     no, that's what blend_light does
21:24 Hijiri     but anyway, it looks like particles don't use day/night separately for determining its own brightness
21:26 Hijiri     so I guess my original question was wrong
21:57 Fixer      !tell paramat I've noticed this on mgv7, lonely stone block in ocean: https://i.imgur.com/qFIsJX9.png (using latest mt/mtg)
21:57 ShadowBot  Fixer: O.K.