Time  Nick        Message
01:12 paramat     #4202 is ready, fairly trivial code cleanup but has some restatement of colours in a simpler form
01:12 ShadowBot   https://github.com/minetest/minetest/issues/4202 -- Sky.cpp: Improve code style by paramat
02:10 paramat     actually that PR needs improvement, WIP
02:44 paramat     updated
02:49 paramat     will merge #3537 #3895 in a moment
02:49 ShadowBot   https://github.com/minetest/minetest/issues/3537 -- Add reason for leave to `on_leaveplayer` callbacks. by kaeza
02:49 ShadowBot   https://github.com/minetest/minetest/issues/3895 -- Make node timers more efficient by Ekdohibs
02:53 hmmmm       could you fix the long lines and the lack of spaces between if and () in 3895?
02:55 paramat     hm actually it could do with squashing too
02:58 paramat     there's quite a bit to do so i'll ask nore to do this
03:02 VanessaE    paramat: you have a comment from me to answer on that mossy cobble stairs/slabs PR..
03:02 VanessaE    if you don't mind.
03:03 paramat     looking
03:03 VanessaE    #1120
03:03 ShadowBot   https://github.com/minetest/minetest/issues/1120 -- Fix bug only half of unreliable queue handled per step in worst case by sapier
03:03 VanessaE    er game#1120
03:03 ShadowBot   https://github.com/minetest/minetest_game/issues/1120 -- Mossy cobble slab and stairs. by sofar
03:04 paramat     API stuff? we can do this later
03:04 VanessaE    perhaps, but if you're gonna expand a feature like that,
03:05 VanessaE    that's the best time to invent a simple API, even if it's just one function.
03:05 Wayward_One #4212
03:05 ShadowBot   https://github.com/minetest/minetest/issues/4212 -- Android build error
03:07 paramat     we still need to consider an API, i wouldn't consider it inevitable, default game only has 3 nodes made mossy
03:08 paramat     ugh android stuff
03:10 hmmmm       drrrrrrrrrroooooooid
03:10 paramat     merging 3537
03:23 paramat     merged
03:24 VanessaE    has anyone ever benchmarked run-thousands-of-ABMs versus run-one-ABM-with-thousands-of-decisions?
03:25 VanessaE    as in you have thousands of from/to combos, is it faster to give each its own ABM def, or to use one single ABM that makes all the decisions of which node to operate on?
03:26 paramat     i haven't. i assume having the one ABM search plus decisions is better, like the sapling ABM
03:26 paramat     ah the expert
03:26 VanessaE    huh.  I would have figured one per unique to/from combo would be faster, since the engine would be doing all decision-making in C++
03:26 est31       VanessaE, probably the one with one abm will win
03:27 VanessaE    huh.
03:27 est31       because each abm counts the occurences in the blocks nearby, and this calculation is only done once per abm
03:27 est31       but idk, never ran a benchmark
03:27 est31       its just a guess :)
03:27 VanessaE    hm, sounds like I need to rewrite a couple of my mods then.
03:28 est31       better do a benchmark before you do all the work :)
03:28 VanessaE    maybe :)
03:28 est31       my feelings often tell me wrong things
03:28 est31       remember when I told RBA to add reserve to the vectors
03:29 est31       and in the end it made the game nearly unplayable
03:29 est31       bc of leaves
03:30 VanessaE    I don't remember that, but I'll take your word for it
03:37 * est31     works on a fix for #4212
03:37 ShadowBot   https://github.com/minetest/minetest/issues/4212 -- Android build error
03:38 est31       as of now it seems to be 100% about adding files to android.mk
03:40 est31       Looking goooooood
03:41 est31       its doing the gradle thing, so its 99% certain to work
03:42 est31       https://github.com/est31/minetest/commit/747e7e846fe5e5cf2e138240c1b473cf098dca7e
03:42 est31       hmmmm, paramat ^ PTAL
03:43 paramat     i see
03:44 hmmmm       sure
03:45 est31       can i push?
03:45 hmmmm       sure
03:45 paramat     +1
03:45 est31       pushed
03:47 est31       okay great, now I'll go again
03:47 * est31     needs sleep
03:47 est31       bye
04:09 hmmmm       feeling kinda lazy
04:10 hmmmm       since we're doing minor cleanup type commits how about this
04:12 hmmmm       https://github.com/kwolekr/minetest/commit/33b874fea3948dfcbcc2d6761c28b325ca4aa367
04:13 sofar       +1
04:14 hmmmm       done
04:20 hmmmm       hrmmm
04:39 hmmmm       just closed an old ass issue https://github.com/minetest/minetest/issues/1064
07:27 hmmmm       https://github.com/kwolekr/minetest/commit/27aff22a9b68044d3ea51db731597834336effa3  trivial cleanup, pushing in 20
15:33 Wayward_One Ok, this is probably due to some mistake on my part, but the Android build now fails with the message "failed to find target with hash string 'android-23' in: /home/wayward_one/android-sdk-linux". As usual, I followed the instructions on the dev wiki. Any idea what I may be doing wrong?
16:16 Wayward_One Disregard, had to manually specify "android-23" in the update command
17:06 paramat     oops left c_sand in valleys.h
17:10 paramat     #3895 is ready now will merge later
17:10 ShadowBot   https://github.com/minetest/minetest/issues/3895 -- Make node timers more efficient by Ekdohibs
17:12 paramat     i'd like to also merge my sky cleanup #4202 if anyone wants to look at that, but it's fairly trivial
17:12 ShadowBot   https://github.com/minetest/minetest/issues/4202 -- Sky.cpp: Improve code style. Define sky colours as SColor by paramat
17:23 paramat     ^ i'll merge that later (6 hrs) unless objections
18:18 Fixer       paramat: remember this? https://github.com/minetest/minetest/issues/3685#issuecomment-217942882 are you planning to do it? :)
18:20 paramat     oh crumbs, hmmmm is now a good time to add that, or later?
18:20 paramat     much requested
18:24 paramat     i might attempt it, we would need to convert biome id to name also
18:25 paramat     but i have higher priorities
18:27 Fixer       paramat: that will be awesome feature for ambience sounds, mobs, countless posibilities...
18:32 paramat     i might leave that to the experts
18:50 paramat     sorry hmmmmm, nevermind i shouldn't have highlighted you on this
18:53 hmmmm       paramat, how about i do that, okay?
18:54 paramat     seems best :]
19:14 hmmmm       hmm... is //! a marker for some IDE?
19:21 nrzkt       hmmmm, not vs, not clion, not qtcreator, not eclipse, then don't know :)
19:21 celeron55   it's doxygen
19:21 celeron55   and possibly something else, but at least doxygen
19:21 hmmmm       I thought doxygen was @
19:22 celeron55   doxygen reads a million different comment formats
19:22 celeron55   https://www.stack.nl/~dimitri/doxygen/manual/docblocks.html
19:22 hmmmm       do you feel bad about these //!s being removed?
19:22 hmmmm       (i presume you're the one who wrote Sky)
19:23 nrzkt       no problem for me, i prefer the classic doxygen /**
19:23 celeron55   i don't think i have ever in my entire life written a single doxygen comment
19:24 hmmmm       https://github.com/minetest/minetest/commit/2e90ed07acd295387c0da6c0689d14665b6c125d#diff-13f6d2a2610eb689cc2fd160ee75f115R12
19:25 nrzkt       hmmmm, this comment is... useless lol
19:25 celeron55   those two comments are ridiculous and completely useless no matter in what format they are
19:25 hmmmm       no kidding
19:25 celeron55   if i wrote them, they are probably copy-pasted from some irrlicht example or something
19:25 hmmmm       ahhhh
19:25 hmmmm       irrlicht does use those style comments
19:25 hmmmm       that solves the mystery
19:25 hmmmm       i sorta thought that was out-of-character for you
19:29 paramat     i was puzzled by those too
19:30 hmmmm       https://github.com/minetest/minetest/pull/4202/files#diff-13f6d2a2610eb689cc2fd160ee75f115R619
19:31 hmmmm       i know this isn't your code so this is more of a question for celeron
19:31 hmmmm       celeron55:  is the std::abs in the above link intentional?
19:31 hmmmm       do you want to force pitch to an integer?
19:31 hmmmm       hmm actually nevermind, sorry about that
19:32 hmmmm       paramat:  for clarity you should change that std::abs to std::fabs
19:32 hmmmm       i really hate function overloading
19:32 paramat     ok
20:05 paramat     thanks for the review will update soon
20:27 hmmmm       so we're going to need to discuss biome storage soon
20:27 hmmmm       as of right now there's no need for biome persistence because the only piece of code using it is the server, and only at map generation time
20:28 hmmmm       this is going to change obviously once we start using biomes on the client side
20:31 hmmmm       once mods start telling the core "no, the biome at this point is actually X" then it's game over for querying a biome at a certain point without persistence
21:52 paramat     hmmmm updated PR, detials here https://github.com/minetest/minetest/pull/4202#issuecomment-225396417
21:52 paramat     (details)
21:53 paramat     some further improvements, found another untitled section of drawing code
21:54 hmmmm       great +1
22:30 paramat     will merge #3895 #4202 in a moment
22:30 ShadowBot   https://github.com/minetest/minetest/issues/3895 -- Make node timers more efficient by Ekdohibs
22:30 ShadowBot   https://github.com/minetest/minetest/issues/4202 -- Sky.cpp: Improve code style. Define sky colours as SColor by paramat
22:33 paramat     merging
22:41 paramat     done