Time  Nick        Message
01:15 Wayward_One I know it's a long shot, but I currently have a server experiencing #4151, in case anyone has something for me to try, test, look at, etc. I have not applied the patch yet.
01:15 ShadowBot   https://github.com/minetest/minetest/issues/4151 -- Stall Glitch
02:15 Wayward_One Disregard, had to kill it
06:45 nore        can someone review #4077 again please?
06:45 ShadowBot   https://github.com/minetest/minetest/issues/4077 -- Colored chat and other strings by Ekdohibs
06:49 Zeno`       lgtm. Memory leak fixed, tested with and without luajit (because I recall an issue without it a while ago?) +1
06:59 adfdfgsdf   well
06:59 adfdfgsdf   i wish you'd remove the commented out code pieces and separate the move of guiChatConsole to client/ out
07:00 adfdfgsdf   also isn't irrlicht_modifications a little bit too long??  doesn't irrlicht_mods work?
07:00 nore        maybe
07:01 nore        is its length really a problem though?
07:02 adfdfgsdf   it won't cause any problems, but it certainly isn't pleasant to deal with or look at
07:10 Zeno`       commented out code?
12:41 paramat     4077: nore as long as you address hmmmm's comments i think we should merge it very soon as in later today, unit tests can be added later
13:10 paramat     any comments on #4163 ? code is simple, more interested in comments on how it looks
13:10 ShadowBot   https://github.com/minetest/minetest/issues/4163 -- Sky: Darker, bluer sky and improved horizon haze at night by paramat
13:35 nore        paramat: except for the unit tests, hmmmm's comments are addressed I think
13:40 Zeno`       paramat, nore, +1 for merging if all but the unit tests are addressed. The unit tests would be for something pre-existing anyway (afaics)
13:52 paramat     game#1115 is good
13:52 ShadowBot   https://github.com/minetest/minetest_game/issues/1115 -- Farming: allow LBM's for other mods as well. by sofar
13:53 paramat     +1
13:58 paramat     game#1120 is also good
13:58 ShadowBot   https://github.com/minetest/minetest_game/issues/1120 -- Mossy cobble slab and stairs. by sofar
14:03 paramat     MTGame devs please could you review game#1076 ?
14:03 ShadowBot   https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat
15:26 nore        should I close #4178?
15:26 ShadowBot   https://github.com/minetest/minetest/issues/4178 -- Stable 0.4 by xieziyi
15:32 est31       yes
15:36 nore        paramat: Zeno`: can I merge #4077 now?
15:36 ShadowBot   https://github.com/minetest/minetest/issues/4077 -- Colored chat and other strings by Ekdohibs
15:38 paramat     i can't officially +1 but i say go ahead if hmmmm's issues are addressed, unit tests can be added later. you have zeno's +1
15:39 Zeno`       it's ok with me
15:39 nore        ok, merging then
15:39 Zeno`       I also think the unit tests can be added later for the pre-existing stuff that was merely templated
15:47 Wayward_One ...umm
15:47 Wayward_One What the heck: #4178
15:47 ShadowBot   https://github.com/minetest/minetest/issues/4178 -- Stable 0.4 by xieziyi
15:47 nore        Wayward_One: same question
15:47 nore        was going to close it
15:47 Wayward_One Lol
15:48 nore        closed :)
19:48 Fixer       !seen gregorycu
19:48 ShadowBot   Fixer: I saw gregorycu in #minetest-dev 1 week, 2 days, 4 hours, 24 minutes, and 7 seconds ago saying "This is a job for tomorrow"
19:48 Fixer       okay
21:09 paramat     nore sfan5 can anyone review game#1076 ?
21:09 ShadowBot   https://github.com/minetest/minetest_game/issues/1076 -- Fire: Ignite tnt, gunpowder, permanent flame above coalblock by paramat