Time  Nick      Message
00:34 paramat   est31 is it possible you could review #4135 ? big PR though and i know you don't have much time
00:34 ShadowBot https://github.com/minetest/minetest/issues/4135 -- Biomegen by kwolekr
00:36 est31     I have looked at parts of it and approve with the changes I could understand
00:36 est31     but full review, no, I'm heading to bed now
00:41 paramat   cool
05:59 paramat   hmmmm, with lvm, is it safe to 'read from map', 'get data' and then abort without doing 'set data', 'write to map' afterwards? any memory leak or issues?
05:59 hmmmm     no
05:59 paramat   good
05:59 hmmmm     would've been documented as such if that were the case
06:16 hmmmm     paramat:  close #3929?
06:16 ShadowBot https://github.com/minetest/minetest/issues/3929 -- add a setting for exponential view distance adjustment by DS-Minetest
06:17 paramat   yes
06:18 paramat   almost has 4 disapprovals
06:24 hmmmm     how about #4047
06:24 ShadowBot https://github.com/minetest/minetest/issues/4047 -- Merge threads.h into threading/thread.h by ShadowNinja
06:28 paramat   looking
06:30 paramat   if the issues were fixed would you support this moving of stuff? i feel somewhat neutral
06:30 hmmmm     yes, it doesn't make sense to have two separate files for threading, and then have one of them dependent on a file in the main source tree
06:30 hmmmm     (aren't the subdirectory source files supposed to be thought of as standalone entities?)
06:31 hmmmm     in other words we should be able to take util/ and make that into its own library and use it in other completely different projects
06:31 hmmmm     we should be able to take threading/ and do the same
06:31 hmmmm     perhaps there's an implicit exception to server/ and client/
06:32 paramat   then i would keep it open and ask for improvement
06:32 nrzkt     hmmmm, agreed
06:32 hmmmm     i'm going to add an action required tag
06:34 paramat   there is one :)
06:34 hmmmm     i mean to that PR
06:34 hmmmm     i'm the one who made that tag btw
06:34 paramat   heh i see
06:34 paramat   yeah
06:34 hmmmm     seems to be the more common case that PRs aren't ready than those that are ready
06:35 hmmmm     unfortunately you can't assign multiple people to the same pr/issue
18:14 est31     nrzkt, just try my PR
18:14 est31     your suggested change breaks it
18:27 nrzkt     est31 that's very strange... then okay for your virtual
18:29 est31     nrzkt, do you +1 the Pr
18:30 nrzkt     y
18:32 est31     I'll push it then
20:44 nore      hmmmmm: I thought about your ideas for EnrichedString a bit, and using a basic_string is not a good idea, because it limits the extension possibilities
20:45 nore      for exemple, adding clickable links wouldn't be possible
21:15 nrzkt     est31, in fact yoru PR was wrong :p i didn't see it (was very busy :p)
21:15 nrzkt     the modification on virtual
21:16 est31     you were wrong, not me :)
21:17 nrzkt     no no
21:17 nrzkt     look at the comment on your extra commit :p
21:17 nrzkt     on your repo
21:17 nrzkt     you removed virtual from parent, you shouldn't, you should only remove from childs :p