Time Nick Message 05:27 Etzos Before I go accidentally polluting my copy of the mintest source folder with generated files, was the CMake configuration ever changed to support out of source builds? 05:48 hmmmm i don't think it was... 05:52 hmmmm actually it does support out of source builds, generated object files go into src/CMakeFiles/.dir 05:57 hmmmm paramat: i've decided on what my goal should be with this mapgen cleanup 05:57 hmmmm each major "feature" such as biomes, caves, dungeons have their own set of parameters 05:58 hmmmm the MapgenParams contains its own generic parameters, and then the specific mapgen parameters, biome parameters, cave parameters, dungeon parameters 05:58 hmmmm so each ThingParams per Thing 05:59 hmmmm and all of this is modifiable in lua because you'll be able to construct the entire MapgenParams structure explicitly on mod initialization, and each ThingParams will be required to have a lua serialize/deserialize method 06:01 hmmmm i promise i won't get carried away with this subclassification and abstraction, only to the point where it minimizes redundant code 06:53 Zeno` I think I might make a mese texture 07:59 hmmmm paramat: perhaps biomes should be generated after caves 07:59 hmmmm caves can be marked as such in the voxelmanip and ignored by biome-specific node placement 08:11 nore Zeno`: feel free to do so, there will be more choices :) 10:49 Zeno` hi kahrl 10:50 kahrl hi Zeno` 10:50 kahrl on the subject of out-of-source builds, yes they work, but one problem is that locale files (.mo files) do not get put into a place where minetest can find them 10:50 kahrl Etzos: ^ 10:50 Zeno` oh 10:51 Zeno` maybe that's why my locale tests never work :) 10:51 kahrl one can fix this by simply copying the generated locale directory to the minetest directory 10:52 Zeno` thanks kahrl (even though you weren't addressing me it solved something very low down on my TODO list to research) :) 10:52 kahrl :) 10:52 kahrl it would be nice if this was fixed in CMakeLists.txt, but I have no idea how... 10:55 Zeno` yeah I was just going to ask if it could be fixed 10:55 Zeno` who is the cmake expert? 10:58 kahrl not me ;) 10:58 * Zeno` votes for kahrl to be the cmake maintainer 10:58 kahrl it's genius! 10:59 kahrl hrmm, it uses a macro called set_mo_paths but I don't even know where that comes from 11:00 kahrl oh 11:00 kahrl case sensitive grep strikes again... it's defined as SET_MO_PATHS 11:01 Zeno` isn't using grep cheating? 11:03 kahrl fine. I'll use KDE nepomuk! 11:03 Zeno` lol 11:04 Zeno` nah, use grep 11:04 Zeno` nepomuk is taking things too far 13:44 gregorycu So yeah 13:44 gregorycu #3770 13:44 ShadowBot https://github.com/minetest/minetest/issues/3770 -- Fix superflous shader setting updates by ShadowNinja 13:50 gregorycu I think I found the issue 13:50 gregorycu I better tag Fixer, he may be excited with this news 13:52 Zeno` what news? 13:52 gregorycu So, are you familiar with what that intends to do 13:53 Zeno` yes 13:53 gregorycu I read somewhere that when Irrlicht is low on shaders, it will unload some 13:53 gregorycu Of course, my constant cache doesn't know when they are unloaded 13:54 gregorycu Which means, when the shader is reloaded, none of the constants are set 13:54 gregorycu However, my constants cache thinks the shader is up-to-date 13:54 Zeno` hmm 13:54 gregorycu This is pretty much an educated guess at this stage 13:56 gregorycu Not really sure how to test this 13:56 gregorycu (easily) 14:03 gregorycu I think I know how to test this 14:21 Fixer gregorycu, I'm here! 14:21 gregorycu Hooray 14:21 Fixer was afk outside, now i'm here 14:21 gregorycu lol 14:21 gregorycu Why the hell did you go outside 14:22 Fixer fresh air and stuff 14:22 Fixer it is good to have private house 14:22 gregorycu You're a funny man 14:24 gregorycu http://gregorycurrie.com/repo.jpg 14:24 gregorycu Take a look at that 14:24 Fixer ok 14:24 Fixer you reproduced the bug? 14:25 gregorycu I believe so 14:25 gregorycu A torch didn't fix that 14:27 Fixer yeah 14:27 gregorycu Looks to be an issue with lots of shaders 14:28 gregorycu Or rather, lots of shaders being used at once 14:28 gregorycu I think 14:28 gregorycu I don't know, it all doesn't sit very well with me 14:32 Fixer i can have even with few shaders on 14:33 Fixer for example: tone mapping + waving leaves and grass 14:45 gregorycu *sigh* 14:45 gregorycu can't repo anywhere else 15:24 Zeno` ShadowNinja, can the mutex be made static as well? 15:25 Zeno` referring to #3786 15:25 ShadowBot https://github.com/minetest/minetest/issues/3786 -- Unreliably failing unittests on mac 15:35 ShadowNinja Zeno`: Yes, but that would limit you to starting one thread at a time, and serialize the initialization of those threads. I'd just change the this pointer passed to the thread to a ThreadStartData pointer, containing `Thread * th; Mutex start_mutex;`. 15:35 ShadowNinja You'd delete it before calling run, so the mutex would be freed once you're done with it. 15:36 Zeno` Sounds good 15:36 Zeno` I'm not working on it btw, I collected that data for something different but when I saw the issue I thought it might be applicable 15:37 Zeno` I'm not sure what's wrong with starting one thread at a time... but *shrug* :) 15:57 Wayward_One #4099 15:57 ShadowBot https://github.com/minetest/minetest/issues/4099 -- Minetest apk build failure (again) 15:57 * Wayward_One hides 15:58 naltamur Hello 17:01 naltamur Hello I am a web developer. Can I help project? 17:02 sofar everyone can, yes 17:02 sofar I don't think the main site is looking for an overhaul, though 17:03 sofar there are other things to be done, too. Translations, minetest-mods is in need of a new logo, a good new texture pack wouldn't misstand either 17:04 ShadowNinja naltamur: You can take a look at the website on GitHub: https://github.com/minetest/minetest.github.io 17:05 naltamur shadowninja: thanks 17:05 naltamur I will playing with it :) 17:15 celeron55 there's also the forum theme 17:16 celeron55 if you really want something to do, some people have been asking for an alternative darker theme 17:16 celeron55 https://github.com/minetest/forum.minetest.net_template1 17:22 celeron55 (in case you're more of a web backend guy, there probably aren't much things available for development) 17:47 paramat hmmmm, sounds good 17:47 paramat #4084 seems ready, can anyone give another +1? 17:47 ShadowBot https://github.com/minetest/minetest/issues/4084 -- Add [scale texture modifier by SmallJoker 17:48 naltamur1 hello 17:49 paramat Krock did you test 4084 again? just to be extra careful before release 17:50 Krock paramat, don't worry. The original code that does the whole thing hasn't changed 17:55 paramat ok 17:58 paramat i'm not expert at this type of code, but i'll +1 it later if no-one else looks at it 17:58 Zeno` well, since the rest of the file has no error checking then this is fine 17:58 Zeno` i.e. I'm saying +1 17:58 paramat nice! 17:59 paramat that leaves #4086 which is not absolutely essential 17:59 ShadowBot https://github.com/minetest/minetest/issues/4086 -- Fix locked hardware buttons on Android by MoNTE48 17:59 paramat but would be good if acceptable 18:06 Zeno` *shrug* as I said last night the bug that 4086 has been there since the beginning so I don't have much of an opinion at this point in the release cycle 18:06 paramat i'll trust est31 on this one 18:07 Zeno` the bug that 4086 fixes* 18:18 paramat ok 4086 is the last milestone in engine and game. time to merge #3907 i think 18:18 ShadowBot https://github.com/minetest/minetest/issues/3907 -- Update credits tab by est31 18:19 paramat i can merge 4084 and 3907 later 18:27 sofar translations 18:27 sofar maybe announce when the translations will get merged? 18:28 nore #3907 contains a string that needs to be translated btw 18:28 ShadowBot https://github.com/minetest/minetest/issues/3907 -- Update credits tab by est31 18:30 nore (And it looks like the code doesn't translate it) 18:32 est31 I'll refresh that PR 18:34 est31 hrmm gregorycu has to be moved to active again 18:34 paramat yes 18:37 paramat erm maybe kilbith to previous 18:40 est31 ahhhh i hate when this android build change messes things up again 18:40 est31 it changed the gitignore and this can be felt 18:42 Zeno` no kilbith should not be "previous" for this release 18:42 paramat good point 18:42 Zeno` because he contributed to it 18:42 est31 yeah 18:42 est31 its always counted on a per-release basis 18:43 est31 not about the last two weeks or last months or so 18:44 paramat agreed, excellent contributor too 18:45 est31 so as its "shortly before release" I think I can merge it? 18:45 paramat yes 18:45 paramat 4084 too 18:46 est31 i havent looked at it 18:46 paramat 2 approvals 18:48 Zeno` yeah, please merge that at the same time 19:01 naltamur so.. when is ready next version of minetest? 19:02 paramat release 11th or a little later 19:03 naltamur yeah! 19:03 naltamur I love this project 19:03 paramat Wayward_One do you know if #4086 fixes volume key too? #2122 19:03 ShadowBot https://github.com/minetest/minetest/issues/4086 -- Fix locked hardware buttons on Android by MoNTE48 19:03 ShadowBot https://github.com/minetest/minetest/issues/2122 -- Volume key Android 19:08 Wayward_One paramat, it didn't seem to have any effect 19:09 paramat oh ok heh 19:10 paramat since that was the primary objective perhaps we should not merge it 19:12 paramat as #1454 seems fairly minor 19:12 ShadowBot https://github.com/minetest/minetest/issues/1454 -- Irrlicht sometimes reports unexpected multibyte character 19:13 Wayward_One then again, it does make it hard to take screenshots, as it happens nearly every time 19:13 Wayward_One well, not hard, but it clutters the image 19:13 paramat can't chat be turned off for screensots though? does it crash the game? 19:13 Wayward_One not in android 19:14 paramat i see 19:15 paramat well i think we shouldn't let this delay release 19:15 Wayward_One i have figured out a little workaround though, in case this isn't merged- pushing the power button a split second before the volume button doesn't seem to cause the error 19:16 paramat anyone else agree to removing 4086 from milestones? 19:27 PilzAdam ~tell est31 I'm spammed with merge failure mails from weblate; can you fix that? 19:27 ShadowBot PilzAdam: O.K. 20:26 nore paramat: BlockMen is "previous core developper", even if he still contributed to things in this release? 20:26 sfan5 yes 20:26 sfan5 what counts is the current status of the dev 20:27 sfan5 not whether he contributed anything to the current release 20:27 nore 20:42:53 +est31 | its always counted on a per-release basis 20:27 nore 20:43:05 +est31 | not about the last two weeks or last months or so 20:27 nore also, the message about RBA is untranslated (and untranslatable) 20:28 nore is that intended? 20:29 paramat hm, inconsistency between kilbith and blockmen 20:29 paramat maybe depends on when blockmen left 20:32 paramat not sure about the RBA dedication translation issue, maybe it should be 20:35 paramat he left 21 feb 20:35 paramat well over halfway through 0.4.13dev 20:38 paramat but only has a few commits during 0.4.13dev 20:38 paramat so i think previous is ok 20:39 paramat we're making an exception for kilbith because he left very recently during freeze 20:43 paramat and did a lot of excellent work in mtgame right to the end 21:00 paramat erm yes i feel the dedication should be translated/able but i can't do this 21:01 sofar it's fine, I think, without translation 21:04 paramat well i'm not too bothered either way :] 21:04 Fixer paramat, will you merge updated translation before release? 21:05 paramat i don't know how to, perhaps est will 21:08 sofar est31 should, yes 22:28 Fixer paramat, who will build android packages? 22:31 paramat apk maintainers are nerzhul and est31 apparently 22:31 Fixer ah, ok 22:33 paramat http://dev.minetest.net/Releasing_Minetest 22:48 paramat i noticed docs for facedir rotations are wrong, anyone want to check this fix? #4103 will merge later 22:48 ShadowBot https://github.com/minetest/minetest/issues/4103 -- Lua_api.txt: Fix documentation for facedir rotation by paramat 23:55 paramat updated the commit to be more concise