Time  Nick        Message
00:42 Fixer       hmm, secure.enable_security = false , is this correct as default?
00:43 sofar       yes, that's the default
00:44 sofar       hmm, why can't I obj:punch(obj, ...) anyone? it never does damage
00:45 sofar       all the docs says that obj can be nil, but the C++ code just aborts when param #1 is null
00:45 ShadowBot   https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome
00:47 * Fixer     reads the issue, so many references
00:50 sofar       lol, all bogus
00:52 sofar       2016-03-10 16:52:21: ACTION[Server]: Player sofar punched by player sofar, damage 0 HP
00:52 sofar       I don't get it, I pass it a tool cap struct with everything needed in it
00:52 sofar       including damage_groups = {fleshy=8}
00:57 sofar       sigh
01:14 sofar       ahh, lol
01:14 sofar       got it
01:16 sofar       ha! killed a sand monster with a summoned lightning strike
01:17 kaadmy      :)
01:20 sofar       there's still a bug in core
01:23 sofar       #3837
01:23 ShadowBot   https://github.com/minetest/minetest/issues/3837 -- object:punch(puncher, ... should allow nil for puncher
07:21 paramat     !tell Fixer https://i.imgur.com/cMA4Rbe.jpg that's a tunnel crossing a chunk border at y = 47. it's an unavoidable lighting bug caused when generating chunks upwards, the chunk above is ungenerated so it's impossible to know if there is light or shadow above, so mapgen assumes light above when water level, or shadow below water level
07:21 ShadowBot   paramat: O.K.
07:24 paramat     !tell Fixer it also shows biome surface material in the tunnel, i will attempt to fix
07:24 ShadowBot   paramat: O.K.
07:25 Obani       paramat, /mapfix ?
07:26 paramat     that would need a second lighting calculation, too slow so not worth it
07:40 Hunterz     I think minetest world generators seem to me very smooth, lacking necessary erosion, small lakes, rock formations and more...
07:44 paramat     mgv6 has mudflow type erosion
07:46 Hunterz     Im tried v7 and valleys mapgen
07:50 Obani       v7 and valleys are pretty
07:50 Obani       whereas v6 is ugly :p
09:20 paramat     game#898 is ready for review
09:20 ShadowBot   https://github.com/minetest/minetest_game/issues/898 -- Dye: Make pink dye mixable by paramat
09:23 paramat     i'll merge games 794 and 903 soon
11:43 srifqi      Nice videos for translation: https://www.youtube.com/watch?v=0j74jcxSunY
15:25 paramat     now merging games 794 903
15:35 paramat     merged
19:39 paramat     nore sfan5 ShadowNinja PilzAdam please could you review game#898 game#758 sometime?
19:39 ShadowBot   https://github.com/minetest/minetest_game/issues/898 -- Dye: Make pink dye mixable by paramat
19:39 ShadowBot   https://github.com/minetest/minetest_game/issues/758 -- Add sounds for steel doors. by sofar
20:42 paramat     #3800 has approvals now so i'll merge it in a moment along with #3840 (trivial documentation edit)
20:42 ShadowBot   https://github.com/minetest/minetest/issues/3800 -- Introduce "access" map protection bypass priv. by sofar
20:42 ShadowBot   https://github.com/minetest/minetest/issues/3840 -- Documentation: Clarify global and mapgen-specific mapgen flags by paramat
20:46 kaeza       one of the points of approvals is having unbiased code review. self-approval is not exactly unbiased
20:47 kaeza       just sayin'
20:56 paramat     yes good point
21:00 paramat     but then, before these new labels we self approved. now merging
21:10 kaeza       also, you forgot to update src/settings_translations_file.cpp
21:15 paramat     ok
21:15 kaeza       merged already :(
21:17 paramat     yes merged
21:19 paramat     i was unaware of the translation file, thanks for pointing it out
21:21 paramat     hm looks like it can be auto updated
21:21 kaeza       just temporarily uncomment both blocks in builtin/mainmenu/dlg_settings_advanced.lua, run Minetest, then close as soon as the menu is shown
21:21 paramat     ah i see
21:21 kaeza       both blocks at the bottom*
21:22 kaeza       that should probably be documented somewhere
21:23 kaeza       it's not too late to `git push -f` :)
21:38 paramat     they didn't update for some reason *=(
21:43 paramat     aha it wrote conf.example to bin, this may be something to do with paths
21:45 kaeza       path resolution for RUN_IN_PLACE is weird: some things use <path_to_minetest_exe>/../stuff, while other seems to use ./stuff (i.e. CWD)
21:45 kaeza       I have a cache folder in like 5 or 6 places
21:45 paramat     this explains why conf.example has popped up in bin before now. yes i am using run in place. ok hopefully i'll sort this out later
21:50 paramat     ok, i added a src folder to bin, and the file is there hehe
22:00 paramat     #3843
22:00 ShadowBot   https://github.com/minetest/minetest/issues/3843 -- Documentation: Auto-update conf.example and settings_translation_file.cpp by paramat
22:02 paramat     good, now i know what to do next time
22:04 paramat     celeron55 and all, in case you didn't see the minetest VR and projection table https://www.youtube.com/watch?v=8V588kzxf_o
22:06 Fixer       not bad
22:09 sfan5       wow nice
22:11 paramat     he has a PR here #3620
22:11 ShadowBot   https://github.com/minetest/minetest/issues/3620 -- Stereo: replace toe-in by off-axis method by dfelinto
22:16 paramat     if there are no objections i'll merge #3843 soon
22:16 ShadowBot   https://github.com/minetest/minetest/issues/3843 -- Documentation: Auto-update conf.example and settings_translation_file.cpp by paramat
22:36 est31       ShadowNinja, i hope you want to clean up the regressions you caused?
22:37 est31       #3842 #3831 ?
22:37 ShadowBot   https://github.com/minetest/minetest/issues/3842 -- Console and Pause menu disabled after respawning
22:37 ShadowBot   https://github.com/minetest/minetest/issues/3831 -- Esc stops working when in F10 mode and form invoked, and F10 pressed again
22:37 est31       take your time, but i dont think we should release 0.4.14 with those bugs
22:38 est31       paramat, feature freeze date is still march 20, right?
22:39 paramat     yeah but flexible
22:41 ShadowNinja est31: Same bug.  The MenuManager is doing something wrong.
22:41 est31       its not the same
22:41 est31       its different behaviour
22:42 est31       same place, probably fixable by one commit, yes, but not same bug
22:42 est31       bikeshedding discussion :)
22:47 est31       I will push this in 10 mins: https://github.com/est31/minetest/commit/0d2df732e5c5075cd8848b9a9530865430630bfe
22:48 est31       (belonging to #3841 -- if you clean the git mess, thats the only change remaining)
22:48 ShadowBot   https://github.com/minetest/minetest/issues/3841 -- Fix ask_reconnect_on_crash config option being ignored by orwell96
22:49 kilbith     https://github.com/minetest/minetest/pull/3713 should go in so that we have enough time to test it before the freeze, quite important patch for the metas
22:51 kilbith     same for https://github.com/minetest/minetest/pull/3775
22:52 est31       I think now is the time for me to take over and rebase 3775
22:56 est31       #3713 is ready for second review btw
22:56 ShadowBot   https://github.com/minetest/minetest/issues/3713 -- Resend blocks when modified while sending to client by Jeija
22:57 kilbith     and 2 people report it fixes the metas setting : https://github.com/minetest/minetest/issues/3821#issuecomment-193730908
22:58 est31       Well i think 3713 can go in after the freeze too
22:58 est31       3775 can't
22:58 VanessaE    est31: RBA would be happy for 3775.
22:59 est31       yeah i promised to do it two weeks ago, once my two prs were in a mergeable state
23:00 est31       i now don't think i have the time for my minimap PR
23:00 est31       but the other PR (LBMs) is merged
23:01 kilbith     oh yeah and the connected nodeboxes could go in now to
23:02 est31       https://github.com/minetest/minetest/milestones/0.4.14
23:02 est31       the 0.4.14 milestone has 19 open issues
23:02 est31       thats more than one issue per day
23:02 est31       issue/pr
23:02 Fixer       https://github.com/minetest/minetest/pull/3770
23:03 Fixer       thissss
23:03 VanessaE    ....is in est31's list.
23:03 Fixer       nope
23:03 est31       yes
23:03 VanessaE    yep.  looking right at it.
23:03 est31       it is inside the list
23:04 Fixer       ok, if need testing help on 3770, i will gladly help
23:04 est31       RBA said too that 3770 would help
23:04 Fixer       gives me huge fps boost but needs some bug trimming
23:04 est31       does it?
23:04 est31       are there bugs with it
23:04 Fixer       yes
23:04 Fixer       lightning bugs sometimes
23:05 Fixer       boost is very impressive on my videocard, bigger than VBO
23:05 Fixer       played many hours with it, only bug i see is lighting
23:06 Fixer       i've attached many screenshots in it
23:06 Fixer       for some strange reason it is much easier to reproduce on 0.4.12 "just test" cheaters server
23:06 sofar       can i beg for some NDT_CONNECTED approval votes? ShadowNinja? anyone? #3503?
23:06 Fixer       on other servers it bugs only rarely
23:06 ShadowBot   https://github.com/minetest/minetest/issues/3503 -- Nodebox: Allow nodeboxes to "connect" by sofar
23:07 sofar       https://github.com/minetest/minetest/pulls?q=is%3Apr+is%3Aopen+sort%3Acomments-desc top comments! everyone loves it!
23:09 est31       interesting to see that the two top closed prs #1606 and #3610 are so recent
23:09 ShadowBot   https://github.com/minetest/minetest/issues/1606 -- Add mod security by ShadowNinja
23:09 ShadowBot   https://github.com/minetest/minetest/issues/3610 -- Use meshes to display inventory items by RealBadAngel
23:09 sofar       there's 3 following requests in minetest_game that all have 2 approvals already - #796 #801 #877
23:09 ShadowBot   https://github.com/minetest/minetest/issues/796 -- Don't let dungeons and caves replace water or lava by EXio4
23:09 ShadowBot   https://github.com/minetest/minetest/issues/801 -- Bind minetestserver to a specific interface/ip address
23:09 ShadowBot   https://github.com/minetest/minetest/issues/877 -- Fix gettext for tabs (MSVC) by BlockMen
23:09 sofar       err ouch, wrong number :)
23:10 kilbith     ... now you see why we need a new core-dev
23:13 Obani       a/some
23:16 est31       :)
23:17 Fixer       i've played some hours with PR3775 (node metadata thing) in singleplayer and have not experienced anything critical yet
23:28 Hijiri      What is the max capacity of an itemstack
23:29 est31       2^16 -1 ?
23:29 est31       just a wild guess though
23:31 kilbith     nah, 65535
23:31 Fixer       <Hijiri> someone selling 7.2 * 10^39 beds on my server
23:32 nore        Fixer: I don't think that's possible, I'm almost sure the max capacity is 2^16-1
23:33 Hijiri      nore: The bug is that to check if the player that many, it constructs an ItemStack with that amount and checks if it is in the inventory
23:33 Hijiri      So that succeeds and it uses the bad value
23:33 Fixer       i've also seen cheaters in just test using huge amounts of gold-bronze-protector-blocks, there must be a bug that allows to giveme anything
23:34 Fixer       someone even said that could be related to some kind of glitch when rejoining
23:34 paramat     code style looks ok for #3503 so i could possibly +1, but i was hoping for another more knowledgeable reviewer to check it. i'd like it to go in soon, so related mtgame stuff can be added and checked
23:34 ShadowBot   https://github.com/minetest/minetest/issues/3503 -- Nodebox: Allow nodeboxes to "connect" by sofar
23:35 * nore      goes to bed now, it is late here
23:35 nore        (sorry for not helping tonight)
23:35 est31       no prob
23:38 paramat     ShadowNinja , if possible, game#898 ?
23:38 ShadowBot   https://github.com/minetest/minetest_game/issues/898 -- Dye: Make pink dye mixable by paramat
23:51 ShadowNinja Fixed? #3759
23:51 ShadowBot   https://github.com/minetest/minetest/issues/3759 -- Remove 'new style water' and waving water.
23:53 ShadowNinja paramat: I guess it's fine if it works.
23:54 paramat     ok thanks i still have to test it
23:55 paramat     waving water is still in, new style water was removed
23:57 paramat     RBA was going to remove waving water, it's buggy and doesn't work well with water decorations, perhaps we should go ahead and remove it sometime
23:57 VanessaE    better to find a way to make water decorations work with the shader
23:58 Obani       I approve that