Time Nick Message 00:11 kaeza small question: there's "Touch free target" string, but I'm not sure what the meaning is. from looking at the sources (game.cpp:3351), it looks like it means "touch something on screen to look at it" or something like that. can anybody confirm? 00:12 paramat i prefer >99 because 99+ means 99 or more, >99 means more than 99. if the counter goes 97, 98, 99 .. it should be >99. mathematically 99+ could mean 99 plus a missing number, whereas >99 is clear to the mathematically minded 00:13 Tesseract kaeza: It means you can touch to place/dig anything on the screen instead of having to point the cursor at it. 00:13 Tesseract (For Android) 00:13 kaeza Tesseract, I see, thanks 00:17 paramat calling 1000 '99 or more' is obviously nonsense, 1000 is never 99 00:21 PenguinDad paramat: that's what the or more is for 00:51 paramat heh just realised that 00:52 paramat numbers tend to be right-justified so 99 changing to >99 is tidier, a > just appears 01:03 hmmmm hrmm 01:03 hmmmm what are your opinions on GenElementManager? 01:03 hmmmm is there any opposition to having it rely on covariant return types to work? 01:04 hmmmm C++ purists hate this and say this is a horrible design and that I need to "go use Java" 01:04 hmmmm apparently the "correct" choice is to use templates here 01:04 hmmmm "there is no reason to not use templates" 01:31 Tesseract hmmmm: Covariants seem fine. I don't know how you'd implement the same think with templates, or why you'd want to. templates also require code to be in the header file to work. 01:31 hmmmm I don't know man, but #C++ is a horrible place 01:32 hmmmm they really aren't as smart as they think they are 01:36 realbadangel paramat, you want to indicate infinite stacks? 01:36 paramat RBA the >99 thing? 01:36 realbadangel yup 01:37 realbadangel if so, imho drop the numbers and show "inf" 01:37 paramat i was just giving an opinion for the 99+ or >99 choice, i know nothing of the actual issue 01:38 paramat it might not be about stacks 01:38 realbadangel anythin more is considered a cheat anyway, so no point to limit the stack 01:38 realbadangel just show inf or infinite math symbol there 01:40 paramat i think the issue is about displaying player numbers on servers or something 01:40 Tesseract We were talking about the in-client serverlist. 01:40 realbadangel i see 01:41 realbadangel then maybe show actual number of players in a tooltip? 01:41 paramat yuck no 01:41 realbadangel why not? 01:42 realbadangel tooltips can be multiline, you can put detailed server info there 01:42 Tesseract realbadangel: Doesn't matter, Minetest servers can't actually handle even 64 players without getting very laggy. 01:43 Tesseract (unless you run mininal or something maybe) 01:44 realbadangel Teseract, that may change in the future ;) 01:44 paramat ;) sorry. i guess it's too rare a possibility to justify a tooltip 01:45 realbadangel http://i.imgur.com/r2TpDP6.png 01:45 realbadangel an old image but showing multiline tooltips 01:53 paramat hmmmm, just a quick check, in this commit you change noise params for mgv6 height select, intentional? (i assume it is and due to the very old bug you were talking of) https://github.com/minetest/minetest/commit/16baed04677a975c990c56df85a431e2c6468ec8 03:45 hmmmm paramat, yes 03:45 paramat goodgood 04:31 Zeno` heh, the zoom thing is fun 04:32 Zeno` I can look at distant flowers and admire their beauty 04:34 MinerDad Hi, I'd like to help with MineTest. I read the wiki and it mentioned doing Engine documentation. Is that something I can help with? 04:35 Zeno` https://github.com/minetest/minetest/issues <-- take your pick :) 04:36 Zeno` Oh. Engine docs. 04:37 MinerDad Yeah, I want to get a better feel of the code and thought that writing docs might help me. 04:37 Zeno` Tesseract is probably a good person to speak to about documentation 04:40 Zeno` Have you looked at the current stuff that is documented using doxygen? 04:40 Zeno` Shouldn't take long :) 04:42 MinerDad Yeah, I found a few of the places. Some are in .h files and some in .cpp files. Is there a standard (besides just doxygen style)? 04:43 Zeno` I was about to write that perhaps there should be a doxygen style *guide* since there are so many ways to do the same thing in doxygen comments 04:43 MinerDad agreed 04:43 Zeno` I don't think there's currently and standard or guide... 04:43 Zeno` any* 04:45 MinerDad ok, should I just forge ahead, add some docs, create a pull request and see if it is liked? Do I need to create an issue for every pull request? 04:46 MinerDad And if I'm confused by a function, should I ask here or #minetest? 04:47 Zeno` ask here. If something doesn't need and issue then .. it doesn't need an issue :) 04:47 Zeno` just the PR is fine 04:47 Zeno` do you have a personal style you prefer you doxygen comments? 04:48 Zeno` I need to have breakfast... cannot type :/ 04:48 paramat pull without an issue is ok 04:48 MinerDad No personal style. I'll get the doxygen make target working and see what looks nice in it. 04:49 Zeno` There was a PR yesterday regarding doxygen 04:49 Zeno` let me find it 04:50 Zeno` Oh it's merged: https://github.com/minetest/minetest/pull/1944 04:50 MinerDad yeah, that added the doxygen target. 04:50 Zeno` I don't see any reasonable commenting rules in http://dev.minetest.net/Code_style_guidelines, though. Not related to doxygen anyway 04:51 MinerDad I see the line of putting them in the header, so I'll do that 04:51 Zeno` Yeah so I guess just dive in and make a PR :) 04:51 Zeno` Yeah in .h is better I think 04:51 Zeno` for "public" documentation 04:54 Zeno` You may want to let people know what file/class you're planning on documenting (when you decide) 04:55 MinerDad Do I let them know here? 04:55 MinerDad or on the forum? 04:56 Zeno` In here. I'm just thinking of the cases where a file is being actively changed 04:56 Zeno` There are a few files that are actively being changed almost daily and I think commenting them would cause merge conflicts and headaches 04:57 Zeno` If you watch the commit stream you'll soon work it out though and choose "stable" classes or files to work on 04:58 MinerDad ok 06:16 hmmmm :\ 06:18 hmmmm trying to decide whether an IGenElement should inherit INodeResolveReceiver or each generation element should have multiple inheritance 06:19 hmmmm when client side biomes hit, i'm going to have to define a brand new data structure anyway i look at this 06:19 hmmmm blahh 06:21 hmmmm sorta wondering if I should split Biome up into ServerBiome and ClientBiome 06:22 hmmmm ClientBiome lacking the INodeResolveReceiver inheritance and the content_t listings 06:22 hmmmm i want to be able to use the same exact BiomeManager in the client as I do the server 06:23 Zeno` How can caves be different if the PRNG is given the same seed? 06:23 Zeno` I don't understand that bit 06:23 hmmmm could be a bug 06:26 hmmmm i'm looking at the code - there is no way for such a thing to happen 06:26 Zeno` Maybe threads 06:27 Zeno` not really sure :/ 06:27 hmmmm multithreaded mapgen? that could theoretically cause it, heh 06:27 hmmmm why, are you observing the same problem? 06:27 kahrl maybe a difference in chunk generation order? 06:27 hmmmm also it could be due to the order in which the chunks were generated... there's that walled-in cave problem that never got solved 06:28 Zeno` I was just asking because part of the #minetest conversation flew over my head 06:29 hmmmm meh 06:29 hmmmm zeno`, it's probably because he approached the area from different orders and the walled-in cave bug happened 06:29 Zeno` hmmmm, ok 06:30 hmmmm i actually have an idea on how to fix that and improve cross-chunk generation features in general 06:31 hmmmm i might've mentioned it in the channel in which case i need to search logs because i can't remember all the details of the plan that i worked out 06:32 paramat too soon to worry about clientside biomes surely, are they planned/inevitable? 06:33 hmmmm yeah 06:33 hmmmm it's going to be the segway into client side scripting 06:35 Zeno` kahrl, r.e. #1951... I get neither of those errors 06:35 ShadowBot https://github.com/minetest/minetest/issues/1951 -- Error message on startup 06:36 hmmmm the plan is to use the same exact BiomeManager existing right now in the client 06:36 hmmmm when we register biomes from the mods, they go into the server BiomeManager located in the EmergeManager as ServerBiomes, or I guess simply Biomes 06:37 hmmmm on connection to the server, they get serialized as ClientBiomes and sent over to the client, who receives them and upon deserialization, adds them to the client BiomeManager that I'll put in... somewhere. not the gamedef 06:37 hmmmm I guess Client will work 06:38 hmmmm the point is, both ClientBiome and ServerBiome are Biomes, so you can add them into the BiomeManager just fine 06:38 hmmmm covariant types 06:39 hmmmm I'm not sure if noise.cpp is compiled into the client at this point but this is going to necessitate making it a client source 06:40 hmmmm if noise.cpp is there, then what's the harm in adding some "neato" features like combining textures via perlin noise 06:40 hmmmm super easy to do so why not 06:43 paramat is the advantage of clientside biomes spreading the load of mapgen / reducing load on server? 06:48 hmmmm nope.. 06:48 hmmmm it's for client effects 07:58 Zeno` kahrl, I, umm, like your icon for no clip 07:58 kahrl heh 07:58 Zeno` made that yourself? 07:58 kahrl yeah 07:58 kahrl with inkscape 07:58 Zeno` very nice :P 07:59 Zeno` It may be confusing... it *does* look like an exit sign 07:59 Zeno` maybe if the person icon was sideways 08:00 Zeno` although that may look like throwing someone down the stairs 08:00 kahrl yeah, the person shouldn't have the pose from the emergency exit sign :) 08:01 Zeno` What is the person was half in and half out of a cube 08:01 Zeno` rather than a rectangle? 08:01 Zeno` what if* 08:01 kahrl let me try that 08:11 kahrl Zeno`: https://github.com/minetest/minetest/pull/1946#issuecomment-66868757 08:12 Zeno` fire in the hole! 08:12 Zeno` I mean, I like the second best 08:13 Zeno` looks much less like an emergency exit 08:13 Zeno` that's a square though, not a cube :P 08:13 kahrl I used orthographic projection ;) 08:13 Zeno` I thought so 08:13 sfan5 Tesseract: no, i dunno the cause 08:15 kahrl is there someplace I can upload SVG files? Neither github nor imgur likes them so I had to export to PNG 08:16 kahrl I suppose I could abuse gist 08:16 gregorycu Isn't SVG text? 08:16 kahrl yeah 08:16 gregorycu pastebin 08:17 kahrl lots of it though :) 08:17 Zeno` why doesn't github like them? 08:17 Zeno` can gists be viewed "raw"? 08:18 Zeno` I've seen SVG in actual repos before and click view raw to open them in my browser 08:19 kahrl https://gist.github.com/kahrl/ca541c2adb333e4cca97 08:20 Zeno` basically worked :) 08:21 kahrl when I tried to upload that as an issue comment attachment it said "Unfortunately we don't support that file type yet. Please use PNG, GIF, or JPG." 08:21 kahrl not very open minded :P 08:21 sfan5 kahrl: I think http://mediacru.sh supports svg 08:22 kahrl sfan5: ah nice, indeed they do: https://mediacru.sh/MFjit4yU-9P3 08:32 Zeno` I wonder how many people would be annoyed if we swapped zlib compression for snappy 11:51 PilzAdam I'm pushing this typo fix https://github.com/PilzAdam/minetest_game/commit/367d3f31ba6502a7667bd212cf37f887af1b22dc since I guess https://github.com/minetest/minetest_game/pull/376 won't get merged before release 11:56 Zeno` yep 12:01 PilzAdam kahrl, fixed translation again 12:02 kahrl PilzAdam: lgtm now 12:03 PilzAdam can I merge it then? 12:03 kahrl yep 12:07 PilzAdam sfan5, can you build a release candidate? 12:07 Zeno` PilzAdam, what about this startup issue? 12:08 PilzAdam hm? 12:08 Zeno` I'm looking at it now 12:08 PilzAdam I posted the infolevel logs in the issue 12:08 kilbith the usual weekly builds from sfan5 are already beta/RC, no ? 12:08 Zeno` yeah, just saw that 12:08 Zeno` I wonder if that's got to do with the settings changes 12:09 PilzAdam kilbith, since we have a feature freeze now a build "officially" called release candidate would motivate more people to test, I guess? 12:09 kilbith through its name, probably 12:10 kahrl can we fix the blockers first? (well, at least attempt to fix each one) 12:10 Zeno` I agree that blockers should be fixed. But this startup one worries me 12:10 kahrl Zeno`: I'll set it to blocker as well then 12:11 Zeno` kahrl, if I can't work it out soon I'll set it as one 12:11 Zeno` It won't stop program execution as far as I can see 12:11 kahrl oh sorry, I'll unset it again 12:11 kahrl ;) 12:11 Zeno` lol... but I have NFI what's causing it 12:12 kahrl I hate how github records all your "misclicks" when setting issue labels 12:12 Zeno` In #minetest wuzzy was talking about some subgame/config related issue and I'm wondering if it's related 12:12 kahrl that's #1957 12:12 ShadowBot https://github.com/minetest/minetest/issues/1957 -- minetest.conf of subgame is not read by Minetest anymore 12:13 PilzAdam Zeno`, the error messages might be caused by trying to parse the cmd args, even if it's not needed (i.e. when using the mainmenu) 12:13 PilzAdam kahrl, you don't have the error messages, right? do you have a gameid specified in your minetest.conf? 12:14 Zeno` PilzAdam, I thought so at first as well, but then I traced through the startup and am not quite sure now 12:14 PilzAdam oh... 12:15 PilzAdam derp 12:15 Zeno` (I don't get either of the errors though) 12:15 PilzAdam I had "default_game = survival" in my minetest.conf and no game called "survival" installed 12:15 Zeno` you mean that I've been looking at this for an hour and it was a false alarm? 12:15 PilzAdam commenting it out or changing to a valid gameid fixes it 12:16 PilzAdam Zeno`, well, not quite false alarm 12:16 Zeno` not quite, no 12:16 PilzAdam its a misleading error message 12:16 Zeno` I guess another check maybe 12:16 * Zeno` looks again 12:16 PilzAdam the error message reported by kahrl is a real thing, though 12:17 Zeno` What's wrong with subgame could not be found? 12:17 PilzAdam if I set default_game to anything except "minetest" it shows ERROR[main]: WARNING: Overriding gamespec from "minetest" to "minimal" 12:17 PilzAdam Zeno`, it shows "Subgame [] not found", why it should say "Subgame [survival] not found" 12:18 Zeno` Is that new? 12:18 Zeno` ah ok! Thanks PA 12:18 Zeno` looking now 12:26 sfan5 PilzAdam: sure 12:27 Zeno` PilzAdam, is https://gist.github.com/Zeno-/642751186ad8e029efd5 more suitable? 12:28 kilbith sfan5: don't wanna add a new header with the RC release? 12:28 sfan5 kilbith: nah 12:28 kilbith (the random thing can wait) 12:28 kilbith :( 12:28 Zeno` I can't get the actual name ([survival]) easily I don't think 12:32 sfan5 PilzAdam: any known issues? 12:34 kilbith sfan5: does my header's pull will be ignored for 0.4.11 ? 12:34 sfan5 did we already come to a conseus what to merge 12:34 sfan5 ? 12:35 kilbith i asked you several times 12:35 sfan5 i already told which styles i like 12:35 Zeno` PilzAdam, do you want it in patch format or is the diff ok? 12:36 Zeno` a new header would be nice for a new release 12:36 kilbith https://github.com/minetest/minetest_game/pull/341#issuecomment-66132982 12:37 kilbith ^ let me know if you're agree with that comment 12:37 Zeno` there will never be consensus on something that is artistic and subjective in nature. What was the most popular vote? 12:37 sfan5 most-popular vote is not what matters 12:37 sfan5 the opinions of the maintainers matter 12:37 kilbith most populars : letters-land style 1 & letters-gameland style 1 12:37 Zeno` sfan5, it does and it doesn't 12:38 Zeno` what is the most popular vote from the maintainers? :) 12:38 kilbith the basic one iirc 12:39 Zeno` sfan5, what I mean is it's just as hard to get a consensus from the maintainers on something that's kind of subjective as well :) 12:39 Zeno` link to the first one? 12:40 Zeno` A new header I agree with, whatever it might be (as long as it's good), for "freshness" 12:40 sfan5 looks like the problem we have is that BlockMen did not comment yet 12:41 kilbith all the recents were not merged without BlockMen comment... 12:41 kilbith recents pulls* 12:41 Zeno` oh yeah, it's part of minetest_game 12:41 Zeno` forgot that bit 12:41 sfan5 nore and me both agreed to letters-land style 1 12:42 Zeno` style 1? 12:42 Zeno` are you crazy?! 12:42 Zeno` lol :D 12:43 sfan5 kilbith: many of the recently merged pulls were either smaller cleanups/fixes or already agreed on by other maintainers 12:43 * Zeno` doesn't even know what the current one looks like 12:45 kilbith sfan5: other subgames maintainers ? 12:46 sfan5 nore and BlockMen 12:46 sfan5 the other _game maintainers 12:47 kilbith i don't consider textures changes & furnace code rewriting as small cleanups/fixes 12:48 sfan5 bigger cleanup/fixes then 12:48 Zeno` kahrl, https://gist.github.com/Zeno-/642751186ad8e029efd5 ? 12:49 kilbith BlockMen is away since >1month, would be inapropriate to wait him further 12:52 kahrl Zeno`: looks good but I think the message should mention default_game 12:52 kahrl Subgame specified in default_game [... 12:53 Zeno` ahh, yes of course 12:53 Zeno` will fix that 12:53 kilbith sfan5: those recent big cleanups/textures changes/fixing were approved without BlockMen 12:54 sfan5 should we have waited until blockmen shows up sometime after 0.4.11? 12:54 Zeno` yikes, will have to directly edit the patch (I didn't keep it). Oh well 12:55 Zeno` ok updated. Will merge if you're happy with it kahrl 12:55 kahrl yep, I am 12:55 Zeno` doing so now then ;) 12:55 kahrl this fixes only the startup message, right? 12:55 Zeno` yes 12:55 Zeno` I consider them two different issues 12:55 kahrl yeah 12:57 kilbith sfan5: i don't really want to wait 6 months or more for that a new header will be applied for the next release... 12:58 kilbith will fall into the forgetting else 13:06 Zeno` kahrl, the issue you're getting I don't get 13:06 Zeno` kahrl, could it be because I am using a very old version of minetest_game? 13:07 Zeno` well, it's not that old. Just the commit before next was merged 13:07 PenguinDad Zeno`: that's pretty old 13:08 Zeno` PenguinDad, it's all relative. Relative to my age it's young 13:08 kahrl I'm at 31edc5a9ff 13:09 kahrl which is from the 3rd of december 13:09 kahrl just pulled and it's still happening 13:11 Zeno` hmm 13:11 kahrl Zeno`: try running it with --info 13:11 kahrl it'll show "Selected world: ..." when you exit 13:11 kahrl in my case this is a minimal world 13:12 kahrl I think launch_game needs a check somewhere: if (kill) return false; 13:13 Zeno` hold on, I'll increase debug_level and paste what I get 13:13 Zeno` in here 13:13 Zeno` lol :D 13:14 PenguinDad I noticed this when I only had minimal installed :/ 13:16 Zeno` http://pastebin.com/7LdgLYPe 13:16 Zeno` I have a test world with no mods as well, but basically the same output 13:17 kahrl oh... I forgot to mention it only happens when you exit from the main menu 13:17 kahrl sorry 13:18 Zeno` oh, so exit from game and then exit from main menu? 13:18 Zeno` exit from game to main menu* 13:18 kahrl that, or never enter a game 13:19 Zeno` ok I see 13:20 kahrl if you're guessing that that was my main mode of operation when developing the serverlist icons, you'd be correct ;) 13:21 Zeno` heh 13:24 Zeno` what a horrible function 13:39 sol_invictus accepting a translation without a single review from a native speaker is a bad idea (https://github.com/minetest/minetest/pull/1538) 13:39 sol_invictus don't do that. 13:40 Zeno` kahrl, https://github.com/Zeno-/minetest/commit/b2185365bc7a5357aba41c3274b820324209eee3 13:41 Zeno` gets rid of two potential false errors 13:41 Zeno` sol_invictus, do you speak Russian? 13:42 kilbith he's russian 13:42 Zeno` Doesn't mean he speaks it :D 13:43 sol_invictus yes, but it doesn't mean I'm going to review stuff (: 13:43 Zeno` awww, c'mon sol_invictus old pal and buddy! 13:43 sol_invictus it'd be better if the commit is reverted 13:43 Zeno` kahrl, I'll merge #1958 once you review 13:43 ShadowBot https://github.com/minetest/minetest/issues/1958 -- Fix misleading error when exiting the client from the main menu by Zeno- 13:44 Zeno` sol_invictus, it's that bad? 13:45 * Zeno` wonders why AntonBoch1244 made a PR is they couldn't speak Russian 13:45 sol_invictus Zeno`: it's just a bunch of pointless changes to longer variants plus a lot of mistakes there (e.g. mismatching case)) 13:45 Zeno` sol_invictus, so it was fine before the update? 13:46 kilbith it happened once for french too 13:46 kilbith a dev has merged without asking a native speaker 13:47 sol_invictus Zeno`: idk, it's not worse than after the patch for sure 13:48 Zeno` sheesh, the merge has a whole bunch of languages included 13:48 Zeno` unless I'm looking at the wrong commit 13:48 Zeno` which I was 13:49 Zeno` Ok, does anyone else agree that e4e4324a30d6bcac5cc06c74e955e4941b14bd38 should be reverted based on sol_invictus's expert testimony? 13:49 Zeno` I agree 13:52 sol_invictus you do it wrong 13:52 sol_invictus you should ask if there is any objection 13:52 Zeno` I understand how/why it was merged though. For many (most) languages we rely on the users 13:53 Zeno` order in the court! 13:53 Zeno` :) 13:53 Zeno` sol_invictus, I will revert it 13:53 Zeno` but I do want support of another dev 13:54 sol_invictus nice, I'm someone would approve it 13:54 sol_invictus I'm sure* 13:54 Zeno` There is no clear rule regarding translations so I am inclined to treat it as something that can be done without approval. It can be added back later if necessary. 13:54 Zeno` But, let's give people time to respond to me ;) 13:55 kahrl Zeno`: about #1958, isn't the logic inverted? 13:55 ShadowBot https://github.com/minetest/minetest/issues/1958 -- Fix misleading error when exiting the client from the main menu by Zeno- 13:55 kahrl you check *kill == false (i.e. should the program continue running?) and later treat true as "aborted" 13:56 Zeno` kahrl, ummm... let me think 13:57 Zeno` I originally had exited_from_main_menu 13:57 Zeno` can't think why I changed it now 13:57 kahrl well that's the same, isn't it? 13:57 kahrl I'd keep the void return type on main_menu and just check *kill directly in launch_game 13:57 kahrl since the meaning of the return value of main_menu is not obvious from the name main_menu 13:58 Zeno` doh! 13:58 Zeno` kill is global, right? 13:58 kahrl yeah 13:58 Zeno` forgot about that 13:59 kahrl well, you have to "declare" it by saying bool *kill = porting::signal_handler_killstatus(); 13:59 kahrl but that points to a global variable 14:00 gregorycu Are the forms usually a little non-responsive, or do I have a bad build 14:01 Zeno` updated pushed 14:01 gregorycu It takes half a second for my action to take effect 14:01 kahrl gregorycu: which forms? 14:01 gregorycu formspec forms 14:01 gregorycu With inventories 14:01 gregorycu Chests etc. 14:01 kahrl chests have always been laggy 14:01 gregorycu Cool 14:01 PenguinDad especially locked chests 14:01 gregorycu Well, not cool, but ok 14:02 Zeno` ok, that's good now I think kahrl 14:02 kahrl Zeno`: I agree 14:02 Zeno` I may as well wait for travis to finish before I merge 14:05 kahrl you can revert this translation thing too 14:06 kahrl I wonder what we should do with translation PRs where no core dev speaks that language 14:06 Zeno` yep, will do at the same time. Thanks 14:06 Zeno` It's... difficult to know 14:06 kahrl there are basically two options: 1. just merge it so that the native speakers will either be pleased or speak up against it, or 2. just leave it sitting forever 14:07 kahrl in my experience, comments from native speakers before something is merged are pretty rare 14:08 Zeno` grrr, hard commit to revert 14:10 kahrl oh heh, because the po files were updated later 14:10 kahrl fun 14:19 Zeno` git revert --abort 14:19 Zeno` lol 14:19 Zeno` I chickened out 14:27 Zeno` do we have any devs using OSX? 14:28 kahrl Zeno`: I think I did something amazing https://gist.github.com/kahrl/5deec11e1d43bfa80ade 14:28 Zeno` kahrl :-o 14:28 kahrl Revert "Revert "Update german translation"" This reverts commit 4304f115a20abd775efc462e09f3e8f5fe476175. 14:29 kahrl revertception 14:29 Zeno` I don't know how to do that 14:29 Zeno` looks like magic 14:30 Zeno` you pushing? 14:31 Zeno` Any objections to #1928? 14:31 ShadowBot https://github.com/minetest/minetest/issues/1928 -- Fixes #1687 by extra semaphore retval handle code for OSX by neoascetic 14:31 Zeno` seems like a switch might be better, but *shrug* 14:32 kahrl Zeno`: just a sec 14:32 kahrl the patch is over 10000 lines long 14:33 Zeno` what patch? 14:33 Zeno` yours? lol 14:33 kahrl the revert 14:33 kahrl yeah I had to run updatepo.sh again 14:34 Zeno` I hope you check every line 14:34 kahrl I do! :) 14:37 Zeno` yes, I bought a lovely bridge yesterday 14:43 shadowzone Zeno`: why? 14:43 Zeno` to cross the river 14:43 shadowzone Lol 14:44 Zeno` kahrl, #1928 ok to merge? 14:44 ShadowBot https://github.com/minetest/minetest/issues/1928 -- Fixes #1687 by extra semaphore retval handle code for OSX by neoascetic 14:44 kahrl and so begins the neverending puzzle of why the Zeno crossed the river 14:45 Zeno` I crossed it to get to the other side 14:45 Zeno` There were ducks on the other side 14:46 kahrl Zeno`: dunno, wait for hmmmm, he seems to know about the sem_ functions 14:46 Zeno` ok sure 14:47 Zeno` I think someone should buy me a mac 14:48 kahrl we have some unused ones where I work, you could use them 14:48 Zeno` ok, I'll drop in tomorrow 14:48 shadowzone XD 14:48 kahrl http://ismh.s3.amazonaws.com/2012-06-15-MacPlus.jpg these guys 14:49 Zeno` lol 14:49 Zeno` yes, ok 14:49 Zeno` maybe I won't visit 14:49 kahrl :P 15:30 kilbith nore: sfan5 would wants to reach a consensus with you for the headers: https://github.com/minetest/minetest_game/pull/341 15:32 kilbith i mean to choose one header for the moment 17:59 kaeza I'm not very knowledgeable about gettext; what is the best way to restore a translation that msgfmt or whatever decided to comment out? 18:00 kaeza should I just uncomment it or is there some kind of command to "fix" that kind of stuff? 18:01 kaeza specifically, the last updatepo removed the translations for most items in the pause menu 18:17 kaeza in an unrelated topic, wielditems are still fullbright with shaders on 18:30 diemartin https://github.com/kaeza/minetest/commit/48252fc71c8963e7e53753ecc698fec22df8d67c 18:30 diemartin comments? exio4 ^ 18:32 kaeza err... it didn't push latest changes 19:52 sol_invictus reviewed this stupid russian translation 20:51 kaeza could somebody look at #1959? I think it may need to be labeled "blocker" 20:51 ShadowBot https://github.com/minetest/minetest/issues/1959 -- Checking public serverlist checkbox causes minetest to freeze. 21:18 paramat hmmmm, this lua mapgen problem, is it because formerly noiseparams for luaperlinmaps were written in mods with 'persist =' but now the new lua noise params are formatted 'persistence ='? so backwards compatibility was broken? 21:19 paramat watershed has 'persist = ' as do all lua mapgen mods 21:20 hmmmm errr 21:20 Krock ah. that might be the fail for those cut-offs 21:21 hmmmm internally, the name of the member for persistence in a NoiseParams struct is persist 21:21 hmmmm I did not change the way noiseparams tables are read apart from adding lacunarity/flags 21:22 paramat okay 21:22 hmmmm i just checked and it definitely says "persist" 21:23 hmmmm persist as shorthand for persistence because i didn't want to have to write persistence every time it's mentioned but I think I should support both so there's no confusion 21:23 hmmmm i think exposing the abbreviation of 'persist' to lua is a mistake but it's easy to live with and one i can fix by supporting both 21:24 hmmmm have you had any success in bisecting the commits? 21:24 paramat if you want one noiseparam definition to be usable in both perlinmaps and minetest.get_perlin() there shouldn't be a difference in how persistence is written .. one or the other 21:25 paramat lol i just woke up, exhausted 21:25 paramat and yes i'm in th UK 21:26 paramat i actually prefer persist 21:29 paramat presumably core mapgen isn't affected, so this is a lua noise problem, im guessing a recent commit to do with lua noiseparams 21:30 paramat i'll start bisecting from a week ago 21:30 hmmmm noiseparam definitions work exactly the same everywhere throughout the lua api 21:31 hmmmm it uses the same exact function to read it anywhere a noiseparam definition needs to be read 21:31 paramat i tried changing persist to persistence in watershed noiseparams, no luck it broke it even more 21:32 hmmmm i don't know if it was an oversight or what, but I used the full word 'persistence' in the Settings noiseparam structures 21:32 gravgun Hey everyone, have we already thought of implementing some connected textures feature? 21:33 hmmmm instead of guessing as to what the problem might be, why not find the commit that started the problem... 21:34 paramat yep. im just wondering why lua_api.txt says noiseparams should have 'persistence' when luaperlinmaps expect 'persist' 21:35 realbadangel gravgun, not really 21:36 gravgun Could be useful. But right now we're in a feature freeze... 21:37 paramat so going by lua_api.txt i change persist to persistence in watershed and it breaks terrain 21:38 paramat more specifically, 3D noise breaks but 2D noise seems unchanged 21:42 paramat (.. seemingly, might be wrong about that) i'll start bisecting later tonight 22:47 paramat hmmmmm okay my mistake, sorry, i think i now see what you mean by what you wrote above