Time Nick Message 00:43 paramat hi hmmmm please could you merge https://github.com/minetest/minetest/pull/1892 ? i improved the underwater grass hacks by placing filler nodes instead of top nodes when under water 00:46 paramat thanks! 01:20 paramat im working on a set of default biomes for mgv5/v7 (in default/mapgen.lua) and have discovered these biomes can only be removed or replaced by using a different game, any new biomes registered are squeezed into the default biome system. this will break many worlds, mods and servers so next i plan to add a global mapgen flag 'biomes/nobiomes' to allow disabling of the biome definitions in default/mapgen.lua 02:10 Zeno` How's #1707 looking? Ready to go? 02:10 ShadowBot https://github.com/minetest/minetest/issues/1707 -- Right mouse button behaviour for craft/inventory by Zeno- 02:26 paramat looks like you need to talk to sapier before merging 02:27 Zeno` I have 02:27 Zeno` But we still don't even know if the previous patch broke things :) 02:27 Zeno` And if that's the case the previous patch may need to be reverted as well :( 02:30 Zeno` So, don't really need to wait for sapier. If he has to fix the last patch, adding this one makes things no worse off 02:30 Zeno` (for Android) 02:31 Zeno` e.g. either way things will have to go back 2 commits if it breaks Android 03:30 Zeno` Does anyone have any objections to #1707 being merged? 03:30 ShadowBot https://github.com/minetest/minetest/issues/1707 -- Right mouse button behaviour for craft/inventory by Zeno- 03:36 zat Zeno`: if I understand correctly, it wont let me drop single items anymore? 03:37 Zeno` zat, nah, that's not what it does. What it does is disable the behaviour where if you're dragging a stack of items while holding down the right mouse button it won't automatically drop items (or swap them with whatever slot you happen to pass across) any more 03:38 zat Zeno`: sounds good them 03:38 zat going to sleep, bye 03:38 Zeno` bye 03:38 zat then* 03:51 Zeno` hmmmm? 04:05 paramat zeno sounds good to me in intention 04:09 Zeno` cool 06:31 cg72 https://github.com/minetest/minetest_game/pull/365 06:32 cg72 and no one ever saw this issue??????^^^ 06:32 cg72 i mean saw ingame 08:22 hmmmm https://github.com/kwolekr/minetest/commit/f0cd59034ccc57d69fd79014ed3466deeea2c332 09:58 Zeno` Can #1707 be looked at please. I'd like to merge it so things can progress 09:58 ShadowBot https://github.com/minetest/minetest/issues/1707 -- Right mouse button behaviour for craft/inventory by Zeno- 09:58 Zeno` Also #1876 09:58 ShadowBot https://github.com/minetest/minetest/issues/1876 -- Optimise VoxelManipulator::copyFrom by Zeno- 10:00 Zeno` #1888 I will merge in about an hour unless there are last minute objections 10:00 ShadowBot https://github.com/minetest/minetest/issues/1888 -- Make dropped items larger and rotate faster by Calinou 10:09 Zeno` sfan5? 11:11 Zeno` #1888 merged 11:11 ShadowBot https://github.com/minetest/minetest/issues/1888 -- Make dropped items larger and rotate faster by Calinou 12:23 sfan5 Zeno`: hm? 12:31 Zeno` sfan5, #1876 and #1707 12:31 ShadowBot https://github.com/minetest/minetest/issues/1876 -- Optimise VoxelManipulator::copyFrom by Zeno- 12:31 ShadowBot https://github.com/minetest/minetest/issues/1707 -- Right mouse button behaviour for craft/inventory by Zeno- 12:32 Zeno` I'd like to merge these so things can move forward 12:33 Amaz 1707 looks good as far as I can see, but sapier did ask for time before merging it... 12:34 Zeno` Amaz, yeah I know. But the way I see it is that if 1707 is broken then so is the previous commit. So... 12:34 Amaz I suppose so. 12:35 Zeno` If something needs to be fixed, 1707 doesn't make it harder to fix because the bug is already there due to whatever that previous commit was meant to do 12:42 Zeno` sfan5, do you have a problem with 1707? 12:47 Zeno` I'll merge 1876 in one hour because it was agreed upon apart from adding a comment (which is now added) 13:18 sfan5 Zeno`: 1707 is ok 13:18 Zeno` cool 13:36 PenguinDad Zeno`: double copyFrom? 13:36 Zeno` errr 13:36 Zeno` umm 13:37 Zeno` Dunno what you're talking about PenguinDad 13:37 Zeno` you must have read it wrong? 13:38 PenguinDad ...Zeno- -> minetest/minetest: Optimise VoxelManipulator::copyFromcopyFrom 912a849... 13:38 Zeno` yeah, I dunno why it did that /me looks around innocently 13:39 RGA hello, i’m currently developping on macOS and I had to make minnor changes in my fork to make minetest run with xcode, I would like to discute those changes to know if they are correct. 13:40 Zeno` RGA: The first thing to do is clone the repo. Second, make your changes in a branch (that you create). 13:40 Zeno` But yeah, link to the changes here and they can be discussed 13:42 Zeno` If your changes are not in a branch then they're almost impossible to commit. But since you've made them already just provide a link to read and I'm sure people will make comments 13:42 Zeno` s/commit/merge 13:46 Zeno` oh, I forgot to say hi. Hi RGA 13:46 RGA I have exposed my changes in the forum : https://forum.minetest.net/viewtopic.php?f=7&t=10687 13:47 RGA for the branch, I have already made a fork of minetest it’s not enought ? (it’s maybe a simple question but it’s the first time I work with github) 13:48 Zeno` RGA, the fork is good. Step 1 complete :) But, IMHO, make a branch on your fork for changes that you make. This will not only save your sanity but the sanity of the devs. 13:49 Zeno` Make a new branch for any proposed modifications 13:49 Zeno` You can then, from github, make a PR (pull request) 13:52 RGA ok, also to do it right, for my futurs changes, to I have to speak of it on IRC each time? as pull request can be rejected ? 13:53 Zeno` You don't *have* to speak about it on IRC 13:53 Zeno` But it might speed things up 13:54 Zeno` maybe 13:54 Zeno` has anyone else looked at #1895 ? 13:54 ShadowBot https://github.com/minetest/minetest/issues/1895 -- Responsive tooltip offset for Android. by KodexKy 13:55 Zeno` it looks pretty nice to me 13:55 Zeno` I've only tested on Samsung tab4 though 13:55 RGA yes I know I just wanted to be sure (I’ve read the wiki, and I saw that is better to make others dev knowing what we are working on) 13:56 Zeno` RGA, yeah it probably does make things faster. Especially if those with commit privs can ask questions in real time 14:02 RGA I have a last question, is there a place with default IDE projects ? currently I have my xcode project directly in my working copy. could it be possible to share it on github? if not I will extract it in an indenpendant repository on my github so that it is out of the minetest fork 14:07 kaeza that depends. I have no experience with xcode, but if it can be opened on another computer, and the app can be built with minimal/no configuration required, it should be fine 14:09 kaeza but doesn't CMake generate xcode projects? 14:10 Zeno` kaeza, there was something about xcode somewhere... 14:10 * Zeno` looks 14:12 Zeno` There is a big discussion here: https://github.com/minetest/minetest/pull/1873 14:12 Zeno` and here https://github.com/minetest/minetest/issues/1687 14:30 RGA cmake can generate, but I am only thinking to have base project directly in the repository to start developing with less manipulation as possible 14:31 RGA for exemple a project in xcode is only a folder seen as a file in macOS, so it could be somewhere in github without any problem 14:46 Zeno` Hmm. Does anyone else find that formspecs after the latest commits look... "wrong"? 14:48 Amaz I've noticed they've looked funny for a couple of days... 14:48 Zeno` They settle down after a couple of days? 14:49 Amaz Nope. 14:49 Amaz Just building the latest git to see if it's the same. 14:49 Zeno` Is it an issue? 14:49 Zeno` ok 14:50 Amaz It may have something to do with #1896 14:50 ShadowBot https://github.com/minetest/minetest/issues/1896 -- font_size setting broken 14:51 Amaz Yep, still looks wrong in the latest git. 14:51 Zeno` In what way does it look wrong? 14:52 Amaz The font is big and chunky, not like it was before. 14:53 Zeno` Amaz, do you know how to apply patches to test? 14:53 Amaz Yep. 15:03 Zeno` *sigh* 15:07 Zeno` comments on #1901 please 15:07 ShadowBot https://github.com/minetest/minetest/issues/1901 -- Make sizes of the font in formspecs consistent and not so large by Zeno- 15:08 Zeno` IMHO this needs to be merged until the FIXME that I added to the source code is resolved 15:09 Zeno` The game is kind of unplayable at the moment 15:09 Zeno` Well, it's playable, it's just... well, it doesn't look good 15:09 shadowzone I kinda like it 15:09 Zeno` shadowzone, kinda like what? 15:09 shadowzone the font 15:09 shadowzone I think it looks cool 15:10 Zeno` the font is fine. Formspecs are the things that look not so good 15:10 shadowzone OH 15:10 Zeno` does anyone have a screenshot of the issue I am referring to? 15:10 shadowzone Nope 15:10 Zeno` I guess I can make one then 15:18 Zeno` shadowzone, http://i.imgur.com/hM24U64.jpg 15:19 shadowzone Okay, I might be blind, but what's wrong with it? 15:19 Zeno` (that's on MTZ) 15:19 Zeno` you can see nothing wrong? 15:19 shadowzone Not really 15:20 Zeno` What is the area that I marked? 15:20 Zeno` I'd like to know from and to coordinates please 15:20 shadowzone You mean I have to read it? 15:20 shadowzone I can't read the from and to coords 15:21 Zeno` why? 15:21 shadowzone oooohhhh, I see it 15:21 shadowzone the fonts have them overlapping 15:21 Zeno` I can find worse examples than this 15:21 PenguinDad Zeno`: are you talking about this? https://cdn.mediacru.sh/C3WA6MNKm7yO.png https://cdn.mediacru.sh/JpWmcREuvlor.png 15:21 Zeno` PenguinDad, I am talking about http://i.imgur.com/hM24U64.jpg 15:22 Zeno` I'll make a whole bunch of different screenshots if you like :) 15:22 Zeno` Nearly all the formspecs have some kind of error similar. In fact, http://i.imgur.com/hM24U64.jpg, isn't so bad 15:23 PenguinDad Zeno`: I see but my screenshots show the difference between before fontengine and after 15:23 Zeno` PenguinDad, you mean the smaller font? 15:23 Zeno` in the debug text? 15:24 PenguinDad and the bigger font in the inventory 15:24 Zeno` yeah 15:24 Zeno` so the bigger on in the inventory is linked to the PR I made 15:24 Zeno` I don't know about the other one 15:25 Zeno` Oh, I didn't make a PR did I 15:25 Zeno` oh yeah I did. 1901 lol 15:26 Zeno` so, yes, the inventory differences would be reverted by 1901. I don't know what causes the other issue in your screenshots 15:27 Zeno` All I know is that for the most part sapier did a great job. But, removing code (like in my PR) to fix the obvious issues might be a good idea until what's causing them can be worked out and proper solutions developed 15:28 Zeno` (I didn't remove code, I just commented it out and added a FIXME comment) 15:32 Zeno` I'd rather see code temporarily commented out until something fixes it properly than see what I'm seeing when I play at the moment 15:33 Zeno` I'd fix it myself but: a) Sapier is probably working on it; and b) I don't really understand the full context of what it's (the code I commented out) doing 15:34 Zeno` an #if #endif is not going to bother sapier and it keeps things looking a bit nicer in the meantime 15:36 Zeno` So what I'm asking is: Can #1901 be merged until sapier fixes it properly? 15:36 ShadowBot https://github.com/minetest/minetest/issues/1901 -- Make sizes of the font in formspecs consistent and not so large by Zeno- 15:37 Zeno` or someone else 15:37 Zeno` so people can, you know, play the game 15:45 Zeno` ShadowNinja? 15:49 Zeno` hmmmm, #1901 15:49 ShadowBot https://github.com/minetest/minetest/issues/1901 -- (INTERIM FIX) Make sizes of the font in formspecs consistent and not so large by Zeno- 15:49 Zeno` I propose merging it until things can be fixed properly 15:49 hmmmm what is the proper fix 15:50 Zeno` I don't know what the proper fix is but the current behaviour is broken :) 15:50 Zeno` If I knew what the proper fix was I'd have written it 15:50 Zeno` read log 15:51 hmmmm hmm 15:51 hmmmm sapier could've used std::bsearch() 15:51 Zeno` hmmmm, I still don't know if that would fix things. The font size in a dialog is not, in my experience, associated with the geometry of a dialog (aka formspec in this case) 15:53 Zeno` Opening two different formspecs should both have the same font size; not a font size derived by the size from the size of the formspec 15:54 Zeno` Anyway, the real issue is that fonts overlap, buttons overlap, etc 15:54 Zeno` s/fonts/text 15:55 hmmmm +1 for $1888 15:56 hmmmm 1876 LGTM 15:57 hmmmm no clue about 1707 15:58 hmmmm doesn't 1707 need to be checked on android first? 16:00 Zeno` hmmmm, 1707 was merged because the previous merge about 5 weeks ago was not checked on Android either. So merging it would cause no issues unless there was an issue with the previous merge, in which case both would have to be reverted 16:04 Zeno` ( I have checked 1707 but only on samsung galaxy tab4) 16:04 Zeno` (so it's probably pretty safe) 16:05 Zeno` If not, that and the commit that 1707 "fixes" will have to be reverted *shrug* 16:14 hmmmm okay 16:14 hmmmm sorry about that 16:20 hmmmm Zeno`, could the reason why select_font_by_line_height is broken be caused by a lack of care promoting types when assigning loreq and hireq? 16:20 jin_xi hey hmmmm are you still planning on adding decorations to gennotify? 16:20 hmmmm try fixing that and see if it works properly 16:21 hmmmm jin_xi, yes 16:21 hmmmm sorry about that 16:21 jin_xi no prob, just asking periodically ;) 16:21 Zeno` promoting which? 16:22 hmmmm the integral types to floats 16:22 hmmmm 1 / float / float == 0 16:22 hmmmm likewise I'm not sure if hireq's first variable in that expression is a floating point number or int 16:23 Calinou don't you use .f for floats? 16:23 Calinou in C++ 16:23 hmmmm yes 16:23 Zeno` there is implicit promotion to double in the expressions 16:24 hmmmm yeah, but that's after the division was already performed as an integer one 16:25 Zeno` target_line_height is double so everything in the expression is promoted to double 16:25 Zeno` I don't think that's the issue 16:26 Zeno` I can't see an integer division 16:26 hmmmm nope, you're right 16:28 hmmmm taking a look at the bigger picture, I don't get why font size is selected by the GUI elements 16:30 Zeno` It seems to me to be selected based on the size of the formspec; and that's what I don't get 16:31 Zeno` I see what you're saying and I don't get that either 16:31 hmmmm the loop condition of that binary search is redundant /nit 16:31 hmmmm also, the final selection: t - low < high - t? is that really the condition he wanted? 16:32 hmmmm that loop won't end until hireq == lowreq, so ... 16:33 hmmmm approved 16:33 hmmmm i have to agree with you. i approve of 1896 16:34 Zeno` merge for now? 16:34 Zeno` ok 16:36 Zeno` done 16:38 Zeno` err 1896? 16:38 Megaf Hi all 16:38 Zeno` I just merged 1901 16:38 Megaf Zeno`: Im running a server with an absolutely minimal game and almost no mods at all. I all there are: give initial stuff, sethome, and pixels(just come colorful blocks) 16:39 Megaf those, are built in into default/init.lua 16:39 Megaf Zeno`: besides that, there is the areas mod from ShadowNija 16:39 Megaf and still, it happened to it to use all memory available 16:39 Megaf so, is either a leak on areas or on minetest server 16:40 Zeno` areas is pretty passive 16:41 Zeno` Megaf, I've honestly been meaning to analyse this for days but other issues have arisen. I promise I'll look at it tomorrow (I have noticed similar issues) 16:41 Megaf Ok 16:43 Megaf as a work around I can just restart the server every hour or so... 16:43 Zeno` that kinda sucks 16:44 Megaf this minimal server have used lots of ram twice today already, I just had to kill it 16:46 Zeno` hmmmm, please clarify that I merged the correct PR LOL 16:46 Zeno` 1896 is the widescreen thingy 16:46 hmmmm yeah I just said the wrong number 16:47 Zeno` cool. I'm tired and when I get tired I am tired 16:48 Megaf Zeno`: 0.1% of memery use increase every three seconds 16:48 Megaf memory* 16:48 exio4 exponential memory usage 17:11 Megaf exio4: but that doesnt happen all the time 17:11 Megaf hm, I have changed some settings in minetest.conf, now the memory use is only 2% 17:12 Megaf 20 MB 17:13 Krock Megaf, maybe a setting like the sending radius of mapblocks? :3 17:15 Megaf nope, emerge queue related settungs 17:15 Megaf settings* 17:15 Megaf disk only, total and memory 17:16 Megaf reduced from default to lower values 17:16 hmmmm really now 17:16 hmmmm Megaf, what did you change in particular? 17:18 Megaf server_unload_unused_data_timeout from 300 to 10 17:18 hmmmm i thought you said emerge queue related settings 17:18 Megaf emergequeue_limit_total = from default to 60 17:19 Megaf emergequeue_limit_diskonly = from default to 6 17:19 hmmmm yeah but those don't affect memory at all. 17:19 hmmmm server_unload_unused_data_timeout... does. 17:19 Megaf emergequeue_limit_generate = FROM DEFAULT TO 6 17:19 Megaf from defalt* 17:20 Megaf max_packets_per_iteration = from default to 128 17:20 hmmmm those last 4 settings you mentioned don't affect memory consumption.... but they certainly do screw up server performance 17:22 Megaf could they trigger a leak? 17:22 Megaf memory use still low now, 29 MB 17:22 hmmmm no, you just didn't isolate your changes 17:23 hmmmm isolate your variables i mean 17:48 Megaf 8.1% and rising 18:39 hmmmm agh 18:39 hmmmm i can't include the decoration ID into the gennotify table 18:39 hmmmm without breaking compatibility 18:48 Megaf hmmmm: can you please define decoration? 19:19 Krock pls2fix https://github.com/minetest/minetest/issues/1903 19:29 Krock fixed it.. adding a diff 19:30 Krock ah, fontengine.h throws much much more warnings now.. interesting 19:49 Krock #1904 merge pls 19:49 ShadowBot https://github.com/minetest/minetest/issues/1904 -- Fix MSVC build by SmallJoker 19:54 Krock Also, 20:55:45: ERROR[main]: FontEngine: "C:\Windows\Fonts\TAHOMA.TTF" doesn't seem to be a ttf File. 21:19 paramat sfan5, https://github.com/minetest/minetest_game/pull/366 let me know if the pointy top and roots are okay 21:19 sfan5 paramat: those pine trees look nice 22:18 paramat good 22:29 paramat just spotted an error in default/trees.lua, will fix and perhaps also extend the trunk of appletrees 2 nodes down as roots. i plan to give the schematic trees roots too. trees just sitting on the ground seem wrong 22:38 kilbith i'm strongly against this idea, it could wear through the buildings when those saplings are manually placed 22:38 kilbith and a trunk in the ground is completely wrong 22:39 paramat aha im not sure how popular this would be, so looking for input 22:40 paramat once players know about the roots they could just be more careful, perhaps mgv6 trees should stay as they are now then 22:41 paramat roots for pines and tree schematics only 22:42 paramat i could make more complex root systems that branch int the ground 22:42 paramat *into 22:43 paramat guess it's up to the MTgame team to decide 23:08 realbadangel hi, whats up? 23:09 paramat O/ 23:09 kilbith \o/ rba is alive 23:10 realbadangel had problem with my box, new hdd and new system etc 23:10 realbadangel took a while to rise from all those backups ;) 23:12 realbadangel but thx that i moved from 12.04 to 14.10 23:12 realbadangel and irrlicht 1.8 (also made win7 for testing purposes)