Time  Nick        Message
02:44 Zeno`       I really don't like github pull requests
02:44 Zeno`       maybe I did it wrong... can you create a pull request for a single commit?
02:44 Zeno`       It's just that every time I make a change now it gets added to the pull request :/ E.g. https://github.com/minetest/minetest/pull/1543
02:46 VanessaE    use a different branch for each pull request
02:46 Zeno`       ah ok
02:47 Zeno`       thanks
04:11 cg72        ok if someone doesnt help me with github im smashing my pc with a hammer again!!
04:12 cg72        i cant push a commit as it wont update and squash
04:15 VanessaE    you have to git push -f after you squash.
04:21 cg72        it wont squash or kills my changes for some of the commits
04:23 VanessaE    odd.
04:23 VanessaE    I'll have to let someone more experienced guide you - I always screw that up :-/
04:23 VanessaE    I'm off.
04:23 VanessaE    night all
04:23 cg72        night
04:23 cg72        ty
04:23 cg72        :)
04:43 cg72        i quit im closeing my github this shit is ruining all my work!!!
05:30 celeron55   when not being familiar with git, it's  best to backup the project directory always before doing anything
05:30 celeron55   that's what i did before being comfortable with git
05:30 ShadowNinja Thoughts on core.(de)compress(data, [level])?  It would just pass the data through Zlib.  Usefull for worldedit schematics and the like.
05:32 ShadowNinja It's hard to really lose things with git, although it may be hard to get it back if a commit gets completely detached.
05:33 ShadowNinja celeron55: ^?
05:34 celeron55   it isn't hard when not knowing what one is doing
05:34 celeron55   it's hard after one knows
05:35 ShadowNinja celeron55: I mean about a compression API.
05:36 celeron55   i guess it would be fine
05:40 Zeno`       What's the correct way to throw a lua error?
05:40 Zeno`       E.g. https://github.com/Zeno-/minetest/commit/6c620a402d863a3868146e43ceba5ba39302b7f4
05:41 Zeno`       line 768 of src/script/lua_api/l_env.cpp
05:41 Zeno`       is that right?
05:44 Zeno`       I mean it works, but is the the minetest way?
05:52 ShadowNinja Zeno`: "throw LuaError(...)" is usually used, but that might be changed.  Either way is fine.
05:52 ShadowNinja They both do the same thing.
05:52 Zeno`       I tried the throw LuaError(...) but it didn't seem to dump the Lua backtrace
05:52 ShadowNinja Because LuaErrors are converted to lua_error()s.
05:52 Zeno`       I'll leave it for now, it's not important. Thanks
05:53 Zeno`       s/it
05:53 Zeno`       s/it's not important/if both are fine
05:53 Zeno`       thank you
10:37 BlockMen    sfan5, ok with this? https://github.com/minetest/minetest_game/pull/298
10:40 sfan5       BlockMen: yes
10:56 Zefram_Fysh BlockMen: http://paste.scsys.co.uk/413513 [PATCH] Fix door handness detection for open/close sounds
10:59 Zeno`       sfan5, ok with is? https://github.com/minetest/minetest/pull/1543
11:00 Zeno`       and https://github.com/minetest/minetest/pull/1545
11:01 BlockMen    sfan5, could you merge Zefram_Fysh patch plz?
11:05 sfan5       BlockMen: I'm on vacation with 2g internet, I can't
11:05 sfan5       Zeno`: regarding 1545: rename NO_ERROR to SUCCESS; 1543 looks good
11:05 Zeno`       ok, will rename
11:06 BlockMen    sfan5, ok. i will do it later then
11:07 Zefram_Fysh thanks
11:10 Zeno`       sfan5, renamed
11:51 nore_       ShadowNinja: such a function would dndeed be very useful
13:48 Zeno`       PilzAdam, I can't at the moment update my commit message but I've added a comment
13:49 PilzAdam    Zeno`, it was mostly a reminder to the core dev who will merge it
13:49 Zeno`       I will remember in future though
19:02 paramat     celeron55, since you're audiovisuals maintainer perhaps you could look at this sometime https://github.com/minetest/minetest/issues/1546
19:11 celeron55   paramat: what?
19:11 celeron55   RBA broke it again?
19:11 celeron55   paramat: be sure to shout at RBA, i'm not interested in dealing with this
19:15 celeron55   what the fuck?
19:15 celeron55   https://github.com/minetest/minetest/commit/c9ba92c4ad0b010d6d36890c3b1ddfb2e773560f#diff-c2f90db5de8c33a259c27113939c63c5L1183
19:16 celeron55   he just removed this, and thought it was there for no reason whatsoever?
19:16 celeron55   paramat: go through that commit and figure out what causes it and just make a pull request
19:17 celeron55   as far as i can see RBA didn't change the values that you talk about in there
19:17 celeron55   wait what
19:17 celeron55   yes he did
19:18 celeron55   oh whatever
19:18 celeron55   my take on this is that RBA wasn't allowed to commit that in that state in the first place and he has to fix it
19:19 celeron55   it looks like he never learns and i am not allowed to pull out his commit rights, so deal with it
19:19 celeron55   (i would if there were no other people in this project)
19:19 celeron55   (who would hate me for it)
19:20 sapier      I wonder why it's called "fixes" again as it changes things ... grrrr
19:21 sapier      to me "fix" is something like prevent a crash or revert some accidental change to how it's been before ... or make something consistent to the other 10 cases doing same
19:21 celeron55   i'm going to make a commit that deletes all code
19:21 celeron55   and call it a "fix"
19:22 sapier      what did he intend to do?
19:22 celeron55   it will also change the codebase to use completely different libraries, break the build on everything except my computer and print out "hello world"
19:22 VanessaE    as I recall, it was listed as a fix because the initial proposal for brighter/darker faces introduced a lighting bug with shaders disabled.
19:22 VanessaE    I think this was intended to fix that.  guess he didn't check the effect with smooth lighting disabled.
19:23 celeron55   i have told him to check it on every setting at least twice
19:23 celeron55   how many times do i have to?
19:23 celeron55   do i have to pay someone to repeat this to him until he understands each of the, like, four graphics settings matters
19:23 celeron55   +that
19:24 celeron55   there are literally four settings that matter when tweaking the lighting, and he can't bother to try them
19:24 celeron55   i mean, two settings, resulting in four modes
19:25 sapier      if he was here right now it'd be way less problematic but I guess he'll be busy for some weeks as yesterday ;-)
19:25 celeron55   just revert that commit and wait for him to come do it properly when he has time
19:25 sapier      yet we just release so we've time to fix it ... ok rba has time to fix it :-)
19:25 celeron55   git revert is underrated
19:27 sapier      I wonder why we have to discuss this again and again ... didn't I recently "fix" exactly this issue?
19:29 paramat     hi, yes i'll talk to RBA about it :)
19:31 sapier      thanks paramat ... in best case don't stop bugging him till screenshots from before are same as after ... or changes are explicitly acceptable :-)
19:34 VanessaE    RBA HAS been around, and focused on shaders and such
19:35 VanessaE    how about you guys do the right thing and just fucking fix it?
19:35 VanessaE    instead of bitching about it?
19:35 VanessaE    in the time you spent complaining about his fuckup, you could have already tweaked the settings to the way the should have been (for the mode in question).
19:35 sapier      I don't even know how to fix it except of reverting but I assume he intended to fix something by that change so it's impossible to fix it correct without him
19:37 celeron55   VanessaE: if i do it, it will just break something else because he probably removed or changed something because they were interfering with something else that he did and then it would just be messed up in some other way
19:38 VanessaE    if you break something else, wouldn't that be because YOU failed to test "all four possible settings"?
19:38 celeron55   that's why i decline from doing it right now
19:38 celeron55   it's better to not do it than to break it
19:39 celeron55   the commit message is also completely useless
19:40 paramat     okay those settings i suggested, i'll test and compile and see what looks good
19:40 celeron55   it doesn't tell at all what the commit attempts to do so it cannot be checked whether it still does it after something i would change
19:41 sapier      Well none of us is perfect and as right now there's not that much going on we have time to find out
19:41 sapier      yet commit messages like that one have some room for improvement :-)
19:42 paramat     i suspect that commit calculates face shading all in one place instead of multiple places, RBA mentioned his intention to do that
19:48 VanessaE    celeron55: as for his commit message, maybe he subscribes to xkcd? :)
19:48 VanessaE    http://xkcd.com/1296/
19:50 Krock       ^gobal favor
19:50 Krock       +l
20:09 paramat     i just found a more recent commit 'speedup mapblock mesh' that also changes faces shading values https://github.com/minetest/minetest/commit/f0db6c4423db86203db83538704cc34152c59a09 that was probably the cause
20:49 paramat     ah ... in the 'faces shading fixes' commit, '// Brighten topside (no shaders)' was removed, so the top became darker, that made top and NS too similar, even though elsewhere the original values have not actually been changed. i'll try raising top brightness again using those values
20:58 paramat     first guess, compensated top contrast should be 1.424 instead of 1.095, will test