| Time |
Nick |
Message |
| 00:29 |
ShadowNinja |
"Minetest engine core main application" -- This sounds redundant. Like saying "Minetest core core core application". It's obviously an application too, so just "Minetest engine" should do. |
| 00:34 |
VanessaE |
yes |
| 00:35 |
VanessaE |
I refer to the engine as "core" locally but "engine" is just as good |
| 01:46 |
|
werwerwer joined #minetest-dev |
| 02:57 |
|
BrandonReese joined #minetest-dev |
| 03:00 |
|
ImQ009 joined #minetest-dev |
| 03:14 |
|
khonkhortisan joined #minetest-dev |
| 03:46 |
|
khonkhortisan joined #minetest-dev |
| 04:07 |
|
Miner_48er joined #minetest-dev |
| 04:18 |
|
proller joined #minetest-dev |
| 05:18 |
|
VanessaE joined #minetest-dev |
| 05:40 |
|
grrk-bzzt joined #minetest-dev |
| 05:41 |
|
RealBadAngel joined #minetest-dev |
| 06:07 |
|
nore joined #minetest-dev |
| 06:21 |
|
darkrose joined #minetest-dev |
| 06:30 |
|
salamanderrake joined #minetest-dev |
| 06:43 |
|
damiel joined #minetest-dev |
| 07:06 |
sfan5 |
umm... why was #973 merged? |
| 07:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/973 -- improved win32 file version information by sapier |
| 07:19 |
RealBadAngel |
whats wrong with it? |
| 07:20 |
sfan5 |
<ShadowNinja> "Minetest engine core main application" -- This sounds redundant. Like saying "Minetest core core core application". It's obviously an application too, so just "Minetest engine" should do. |
| 07:20 |
sfan5 |
I would like to have that fixed |
| 07:21 |
RealBadAngel |
ah that. agree |
| 07:21 |
RealBadAngel |
that sounds strange even for me ;) |
| 07:36 |
|
rsiska joined #minetest-dev |
| 07:38 |
kahrl |
why are some of the values in the version block null terminated and some not? |
| 07:38 |
sfan5 |
who even agreed to merge that? |
| 07:38 |
kahrl |
I don't see anything here |
| 07:50 |
RealBadAngel |
so just reverse it and fix |
| 07:51 |
RealBadAngel |
have you guys tried new shaders? |
| 08:30 |
RealBadAngel |
new effect: http://i.imgur.com/9ivjFGe.jpg http://i.imgur.com/zgkBrpb.jpg |
| 08:31 |
RealBadAngel |
how do you like it? |
| 08:38 |
|
Calinou joined #minetest-dev |
| 08:58 |
sfan5 |
RealBadAngel: looks nice |
| 09:07 |
|
darkrose joined #minetest-dev |
| 09:07 |
|
darkrose joined #minetest-dev |
| 09:37 |
|
OldCoder joined #minetest-dev |
| 10:30 |
|
ImQ009 joined #minetest-dev |
| 10:30 |
|
proller joined #minetest-dev |
| 10:46 |
|
RealBadAngel joined #minetest-dev |
| 11:03 |
|
1JTAAH6BG joined #minetest-dev |
| 11:04 |
|
OldCoder joined #minetest-dev |
| 11:20 |
|
PilzAdam joined #minetest-dev |
| 11:28 |
|
ImQ009 joined #minetest-dev |
| 11:47 |
|
Naked joined #minetest-dev |
| 12:26 |
|
tomreyn joined #minetest-dev |
| 12:44 |
|
tomreyn joined #minetest-dev |
| 13:30 |
|
proller joined #minetest-dev |
| 13:39 |
|
ImQ009 joined #minetest-dev |
| 13:46 |
|
ShadowNinja joined #minetest-dev |
| 13:48 |
|
hmmmm joined #minetest-dev |
| 13:50 |
|
proller joined #minetest-dev |
| 13:57 |
|
salamanderrake joined #minetest-dev |
| 14:05 |
|
proller joined #minetest-dev |
| 14:09 |
|
Megaf joined #minetest-dev |
| 14:23 |
|
deltib joined #minetest-dev |
| 14:58 |
|
iqualfragile joined #minetest-dev |
| 15:03 |
|
PenguinDad joined #minetest-dev |
| 15:06 |
Megaf |
folks, how do I compile minetest for OpenGL ES? |
| 15:10 |
xyz |
-DENABLE_GLES=1 |
| 15:12 |
|
zat joined #minetest-dev |
| 15:16 |
Megaf |
hm |
| 15:18 |
|
Anchakor_ joined #minetest-dev |
| 15:39 |
sfan5 |
we don't have a documentation for cmake flags, do we? |
| 15:48 |
PenguinDad |
sfan5, the only documentation I know for them is -LH |
| 15:48 |
sfan5 |
so no |
| 15:48 |
sfan5 |
I guess we shall have some at dev.minetest.net |
| 16:03 |
|
Jordach joined #minetest-dev |
| 16:10 |
|
Calinou joined #minetest-dev |
| 16:34 |
|
EvergreenTree joined #minetest-dev |
| 16:34 |
|
EvergreenTree joined #minetest-dev |
| 16:35 |
|
sapier joined #minetest-dev |
| 16:39 |
|
rsiska joined #minetest-dev |
| 16:39 |
sapier |
#973 was sitting around for half a year now I mentioned it multiple times, it's qute strange that complains always pop up AFTER something was merged. Especially as those complains most time are for formal issues only. |
| 16:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/973 -- improved win32 file version information by sapier |
| 16:40 |
|
EvergreenTree joined #minetest-dev |
| 16:40 |
sapier |
Yet the file version information is there now, everyone who wants to improve it is welcome to do so. |
| 16:41 |
|
EvergreenTree joined #minetest-dev |
| 16:42 |
sapier |
I'm gonna merge #1164 at about 21MET so if someone wants to check it BEFORE merge you're welcome. |
| 16:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/1164 -- Replace builtin pause and message menus by formspec based ones by sapier |
| 16:43 |
xyz |
wtf is MET? |
| 16:44 |
sapier |
middle european timezone? ;-P |
| 16:44 |
sapier |
GMT+1 |
| 16:44 |
sapier |
IRC |
| 16:44 |
xyz |
ah, so same as CET but you call it MET |
| 16:44 |
xyz |
and there's a compliant already in the issue comments |
| 16:46 |
sapier |
well complains form shadow about coding style are on my ignore list |
| 16:46 |
xyz |
why? |
| 16:46 |
sapier |
he'll always find something right after I fixed the last thing he complained |
| 16:47 |
xyz |
ugh |
| 16:47 |
sapier |
and that file doesn't comply to any coding style anyway |
| 16:49 |
sapier |
so unless someone fixes minetests whole coding style or allows usage for tools on existing files I'm just ignore minor issues like that |
| 16:49 |
xyz |
I don't think this should be done at once |
| 16:50 |
xyz |
but I've been told I have no right to complain |
| 16:50 |
xyz |
so I won't |
| 16:50 |
sapier |
doing it at once is the only way to do |
| 16:50 |
sapier |
you wont be able to fix it step by step |
| 16:50 |
|
Naked joined #minetest-dev |
| 16:50 |
sapier |
especialy as we don't even HAVE a defined coding style |
| 16:51 |
sapier |
we have something with some exceptions somewhere |
| 16:51 |
sapier |
but I'm starting to waste time on usless discussions again |
| 16:51 |
xyz |
I wonder why "and no, Boost will not even be considered, so forget it" |
| 16:52 |
sapier |
because boost is crap |
| 16:52 |
sfan5 |
I do not want to install 126MB of headers to compile something |
| 16:53 |
sapier |
it breaks compatibility on each single version they release, no distribution has the version bundled you need right now and and and |
| 16:53 |
sfan5 |
sapier: astyle -z2 -W3 -k3 -p -w -Y -S -K -N -t -m1 is pretty near to Minetest's coding style |
| 16:53 |
sapier |
and of course each application requires a different version of boost |
| 16:53 |
sapier |
yes but I've been forbidden to use it on any file I checkin so this is useless |
| 16:53 |
xyz |
hmm, dunno |
| 16:54 |
xyz |
anyway, what I wanted to complain about |
| 16:54 |
sapier |
and "near to" wont stop shadow from complaining about those things not beeing exactly how he did understand our unprecise specification |
| 16:55 |
sapier |
complains without reason and suggestion are ignored too ;-) |
| 16:57 |
sapier |
yxz CET is american name for MET |
| 16:57 |
sfan5 |
can we just ue UTC for important things? |
| 16:57 |
sapier |
MET-1 ;-) |
| 16:58 |
sapier |
btw I don't consider a simple cleanup to be something important |
| 16:58 |
xyz |
using struct for non-pod should be discouraged |
| 16:58 |
sapier |
xyz can you give an example? |
| 16:59 |
xyz |
an example of what? |
| 16:59 |
sapier |
well what you did is a generall saying I assume you have some context to it ? |
| 17:00 |
sapier |
as far as I know whole minetest code uses structs for non pod types so unless you wanna change it everywhere I see no use in a rule like that except of bugging developers doing things like they are already done |
| 17:00 |
sapier |
+for |
| 17:02 |
xyz |
ugh |
| 17:02 |
xyz |
why is it always all or nothing |
| 17:02 |
sapier |
what's use of rules for non critical things? |
| 17:03 |
xyz |
you can apply new rules to new code so quality of code will gradually increase |
| 17:03 |
sapier |
because it is already crazy to get a commit in shape for merge right now ... not because of bugs but because of unspecified questionable rules |
| 17:03 |
xyz |
yet you apply your all-or-nothing argument and in the end quality of new code is even worse |
| 17:04 |
sapier |
and the real bugs aren't even found on review |
| 17:04 |
sapier |
if there would be found only half the amount of bugs formal issues are found quality would rise drasticaly |
| 17:05 |
sapier |
Yes because it's crap to fix some locations and have exactly same bug in other locations |
| 17:05 |
sapier |
and usually once I fix something I get bugged for not fixing other things I haven't even touched ... which is extremely annoying |
| 17:06 |
xyz |
it's always simple things |
| 17:06 |
sapier |
if at least one of the really critical bugs would've been found prior merge I'd be way less annoyed about that formal things |
| 17:06 |
xyz |
i.e. why have void gotText(std::string message) if it's not used anywhere and only produces an error and makes it harder to write new code? |
| 17:07 |
sapier |
because that function is part of interface |
| 17:07 |
xyz |
that nothing now implements, correct? |
| 17:07 |
sapier |
and no I it's not my interface |
| 17:08 |
sapier |
no the function is called |
| 17:08 |
xyz |
where? |
| 17:09 |
sapier |
iirc some exit function in guiformspec calls it |
| 17:09 |
sapier |
and usually people write their own functions if they're not remembered about the existing ones |
| 17:10 |
sapier |
but that's a formal thing again, did anyone compile and use it yet? |
| 17:12 |
xyz |
I certainly didn't |
| 17:14 |
xyz |
see, you're not interested in my suggestions so I too am not interested in compiling this code |
| 17:14 |
sapier |
I am interested as long as it's not add a tab there move that function 2 lines above and things like that |
| 17:15 |
sapier |
the getText you mention is just specified by interface if it's used where it shouldn't be used imho it's worth an error |
| 17:18 |
|
xyz left #minetest-dev |
| 17:19 |
|
rubenwardy joined #minetest-dev |
| 17:22 |
sfan5 |
I'm not completly done but here is documentation for cmake switches: http://dev.minetest.net/CMake_Options |
| 17:24 |
sapier |
good work, guess we can add this to readme too? |
| 17:24 |
VanessaE |
sfan5: cURL enables the use of remote media fetching via http also, no> |
| 17:24 |
VanessaE |
? |
| 17:25 |
sapier |
sfan5 did you check your luajit detection fixes to really stop usage of old luajit versions? |
| 17:25 |
VanessaE |
this looks good (wish I'd had this a couple of times in the past, in fact) |
| 17:25 |
proller |
sapier, did you play in MT, or only write code? |
| 17:28 |
VanessaE |
fwiw, the luajit version check works on ubuntu :P and forced me to pull and install that from git |
| 17:29 |
sapier |
sfan5 because for my tests your changes just break the check completely you could've just reverted that commit too |
| 17:31 |
sapier |
well actually it'd be better if you did remove it instead of making it non functional |
| 17:35 |
sapier |
VanessaE prior or after sfan5's changes? |
| 17:36 |
sapier |
because that cmake submodule just checks if the supplied code compiles which is always true if you do it the way he did change it |
| 17:39 |
sfan5 |
sapier: the check works for me |
| 17:39 |
sfan5 |
VanessaE: yes it does, add that |
| 17:40 |
VanessaE |
sapier: well I'm at commit 9a3b7715 + your 1143 patch, so whatever that does :P |
| 17:41 |
sfan5 |
VanessaE: i'll add it for you (b/c I will complete it now) |
| 17:41 |
sapier |
sfan5? did you read my comments above? |
| 17:41 |
VanessaE |
sfan5: done. |
| 17:42 |
sfan5 |
... |
| 17:42 |
sfan5 |
sapier: I'm pretty sure I have not broken the check |
| 17:43 |
|
Zeitgeist_ joined #minetest-dev |
| 17:44 |
sapier |
ok I'm gonna make c fresh pull and only add my current luajit version to broken versions again ... just to make sure no old relics are in my dir |
| 17:48 |
sapier |
ok my fault. The check only fails for existing clones ... well I guess everyone already having a cloned repo will know about the broken luajit versions |
| 17:51 |
PenguinDad |
sapier, just tried #1164 and I think the menus are too large |
| 17:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/1164 -- Replace builtin pause and message menus by formspec based ones by sapier |
| 17:52 |
sapier |
too large? thought they're exactly same size as before? can you provide a screenshot? |
| 17:54 |
|
vifino joined #minetest-dev |
| 17:54 |
vifino |
If someone who codes on MineTest wanna help me to get a macbuild working, say it! |
| 17:54 |
vifino |
I am working on that |
| 17:54 |
vifino |
I got cmake working |
| 17:55 |
vifino |
( AKA no errors ) |
| 17:55 |
vifino |
the make -j2 failes |
| 17:55 |
sapier |
just post a link to the error message |
| 17:55 |
vifino |
kay |
| 17:55 |
VanessaE |
PenguinDad: screenshots to compare? |
| 17:55 |
sfan5 |
ok |
| 17:55 |
sfan5 |
I completed the cmake options page on the wiki |
| 17:56 |
sfan5 |
someone please look if I missed something |
| 17:57 |
sapier |
good work |
| 17:57 |
sapier |
DISABLE_LUAJITcould be interesting too |
| 17:58 |
vifino |
http://pastebin.com/W2QHJW7S |
| 17:58 |
VanessaE |
VERSION_EXTRA - Text too append s/too/to/ |
| 17:58 |
vifino |
there it is |
| 17:58 |
VanessaE |
(fixed) |
| 17:58 |
VanessaE |
this seems good to me. |
| 17:58 |
vifino |
sem_timedwait doesnt exists on mac |
| 17:58 |
vifino |
like some bsds |
| 17:58 |
sapier |
that's a problem |
| 17:59 |
sapier |
is there something similar? |
| 17:59 |
vifino |
sem_wait and sem_trywait exists |
| 17:59 |
VanessaE |
sapier: wait, I thought there already was such a flag? |
| 17:59 |
sapier |
yes it's missing in doc only |
| 18:00 |
sapier |
vifiny you can build a timedwait replacement by using trywait ... it's not best style but will work |
| 18:00 |
sapier |
get current time, do a trywait, loop until time is passed or your trywait succeeds |
| 18:00 |
vifino |
sapier How? |
| 18:01 |
vifino |
please help me |
| 18:01 |
vifino |
There is my current reposiroty: https://github.com/vifino/minetest-osx |
| 18:02 |
sapier |
give me a minute |
| 18:02 |
vifino |
sapier take your time |
| 18:04 |
|
Jordach joined #minetest-dev |
| 18:05 |
sfan5 |
sapier: added DISABLE_LUAJIT |
| 18:06 |
vifino |
brb |
| 18:07 |
|
Jordach joined #minetest-dev |
| 18:07 |
sapier |
really good work ... I didn't even know about the EGL flags before |
| 18:08 |
vifino |
back |
| 18:08 |
sfan5 |
the GLES flag was added to prevent it automatically using gles libs that seem to be present on archlinux and screwing up irrlicht |
| 18:13 |
sapier |
https://gist.github.com/sapier/9331103 untested directly written to gist |
| 18:14 |
vifino |
sapier what do i do with that? |
| 18:14 |
sapier |
that code isn't best to do but may work as replaxement for timed wait |
| 18:14 |
sapier |
vifino do you have any experience in coding? |
| 18:15 |
vifino |
In several languages |
| 18:15 |
vifino |
but not C |
| 18:15 |
sapier |
ok then there's at least some chance to get it ported |
| 18:15 |
vifino |
... |
| 18:15 |
* sfan5 |
just categorized the Library specific CMake flags |
| 18:16 |
sapier |
sfan5 can you merge the old version to readme? |
| 18:16 |
vifino |
sapier join #vifino to see my latest project in action |
| 18:16 |
sfan5 |
sure |
| 18:17 |
sfan5 |
sapier: http://dev.minetest.net/index.php?title=CMake_Options&oldid=1806 that one? |
| 18:17 |
sapier |
great, it'd be a pitty if we'd have to do the job twice |
| 18:17 |
sapier |
yes |
| 18:18 |
vifino |
sapier what do i do with that piece of code |
| 18:18 |
vifino |
Do i paste it in place of the line or what? |
| 18:18 |
sapier |
it's a replacement for sem_timedwait |
| 18:19 |
sapier |
but as I said it's untested it may or may not work |
| 18:19 |
vifino |
sapier yes, but WHERE do i put that piece of code |
| 18:19 |
sapier |
exactly at that location where sem_timedwait is used |
| 18:19 |
sapier |
src/jthread/pthread/jsemaphore.cpp |
| 18:20 |
sapier |
wait a second |
| 18:20 |
vifino |
waittime |
| 18:21 |
sapier |
it's better this way |
| 18:21 |
vifino |
sapier or just put it in my github |
| 18:21 |
vifino |
or else i would probably fail |
| 18:22 |
sapier |
ok I updated the whole function for you |
| 18:22 |
vifino |
mkay |
| 18:25 |
sfan5 |
''Document CMake options in README'' incoming in 10 minutes |
| 18:26 |
sapier |
does anyone know HOW the code style for what shadow did complain in #1164 should be? |
| 18:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/1164 -- Replace builtin pause and message menus by formspec based ones by sapier |
| 18:28 |
sapier |
well that's annoying ... someone complains ... you fix it and then someone else complains |
| 18:32 |
PenguinDad |
sapier, VanessaE: http://imgur.com/a3ef3lb,bvejYtu |
| 18:33 |
VanessaE |
wow |
| 18:34 |
sapier |
what's wrong about it? |
| 18:34 |
VanessaE |
it's... um...huge |
| 18:34 |
VanessaE |
and honestly it's not well-formatted but that can be fixed |
| 18:35 |
sapier |
well the formating is exactly as original one ;-) ... I guess I know what's wrong ... formspecs scale to window size ... I did only check with default size |
| 18:35 |
sapier |
not a big deal to fix |
| 18:53 |
|
EvergreenTree joined #minetest-dev |
| 18:59 |
sapier |
PenguinDad: now it should look exactly like before even on larger/smaller resolutions |
| 18:59 |
sapier |
ok on larger only :-) |
| 19:00 |
sapier |
oops ... forget about it :-) |
| 19:00 |
VanessaE |
bbl |
| 19:01 |
sapier |
broke mainmenu by adding a feature in a generic way :-) |
| 19:01 |
|
salamanderrake joined #minetest-dev |
| 19:03 |
sapier |
but now it's fixed |
| 19:05 |
sapier |
but I'm gonna give that fix another day of testing maybe there's not only PenguinDad who does real testing |
| 19:11 |
|
Zeitgeist_ joined #minetest-dev |
| 19:23 |
|
Garmine left #minetest-dev |
| 19:23 |
|
Anchakor_ joined #minetest-dev |
| 19:43 |
|
Garmine joined #minetest-dev |
| 19:53 |
|
NakedFury joined #minetest-dev |
| 20:22 |
|
BrandonReese_ joined #minetest-dev |
| 20:47 |
|
proller joined #minetest-dev |
| 21:13 |
|
khonkhortisan joined #minetest-dev |
| 21:37 |
|
grrk-bzzt joined #minetest-dev |
| 21:38 |
VanessaE |
ShadowBot: tell sapier nope, that last build (bugfix for 4.1.1) didn't work either. same crash as the others. |
| 21:38 |
ShadowBot |
VanessaE: O.K. |
| 21:39 |
|
vifino joined #minetest-dev |
| 21:45 |
|
sapier joined #minetest-dev |
| 23:06 |
|
Zeitgeist_ joined #minetest-dev |
| 23:38 |
|
smoke_fumus joined #minetest-dev |
