Time Nick Message 00:09 kahrl PilzAdam: to distinguish git builds, we could modify the part in CMakeLists.txt where VERSION_STRING is generated so that it runs "git describe --always --tag" and if that succeeds, it overrides VERSION_STRING 00:10 PilzAdam seems good, but it should fallback to "-dev" if it fails (i.e. it isnt a git repo) 00:11 kahrl in that case the user may have downloaded e.g. the 0.4.7 source as a zip 00:11 kahrl so -dev wouldn't be appropriate 00:12 PilzAdam comment that line out for stable releases then 00:13 kahrl I'm trying to make releasing as little painful as possible 00:14 kahrl hmm, one thing that git describe doesn't catch is uncommitted modifications 00:15 kahrl guess we'll have to live with that 00:17 kahrl oh there's --dirty 00:18 kahrl so: git --git-dir="${CMAKE_CURRENT_SOURCE_DIR}" describe --always --tag --dirty 00:27 VanessaE kahrl: +1000 00:29 VanessaE it would make modders' lives easier too ("oh, what version?" "um..0.4.7...." "well, what's the exact text up in the upper left corner?" "um...oh 0.4.7-ab57dc89blahblah" "Oh, that's why, yours is too old, get 584a2d93bblahblah") 00:29 PilzAdam VanessaE, yes, that was the idea 00:30 kahrl PilzAdam: I think the idea with manually disabling the line on releases is the sanest, can't think of anything else 00:30 VanessaE PilzAdam: the last time I pitched this idea, I was turned down because it was thought that not enough people would even see it because of the origin of their builds' source code. 00:33 kahrl what should we do about VERSION_EXTRA? 00:33 PilzAdam use that instead of the other thing 00:33 kahrl what other thing? 00:33 PilzAdam the git version 00:34 kahrl why? 00:35 PilzAdam e.g. in my builds usually have a name (like "vmanip") that can be used instead of the git version 00:36 VanessaE is VERSION_EXTRA is set, use that, and if not, plug in the git commit id then - or just use both 00:38 kahrl okay 00:38 PilzAdam VERSION_EXTRA is used to describe the version; the git version has the same purpose, so it doesnt make much sense to print both at once 00:38 kahrl you lose the exact commit and dirty info that way 00:38 VanessaE sure it does - what about the aforementioned uncommitted changes? 00:39 VanessaE exactly. 00:39 PilzAdam kahrl, well, its the job of the one who sets the version_extra to take care that he knows the exact version 00:40 kahrl that's true as well 00:41 kahrl most users aren't ever going to see a version with VERSION_EXTRA set anyway 00:42 NakedFury where do you see all this info anyway? 00:42 NakedFury as a "most user" 00:43 kahrl top left of the windows 00:43 kahrl -s 00:43 kahrl or --version once it is implemented 00:44 kahrl what to do with the CPACK variables? just leave them as they are? 00:47 NakedFury add all that to About 00:49 NakedFury if it ends up being too much info add it to an About or Info tab 00:50 PilzAdam its only for dev builds, so it should be quite visible 00:50 PilzAdam and not hidden somewhere 01:30 Sokomine was anything changed recently (relatively) regarding moving around of inventory? 01:32 Sokomine i do have the following problem: an inventory place/slot allows take but not place. when something is taken out of that slot and placed into a slot of the players inventory that already contains a diffrent items, those are swapped...which does not work because the slot does not accept input 01:35 kahrl Sokomine: maybe related to d74c377337? 01:37 Sokomine how do i find out what that code stands for? 01:38 kahrl git diff d74c377337^ d74c377337 01:41 kahrl Sokomine: https://github.com/minetest/minetest/issues/332 01:41 Sokomine could very well be. i'm having difficulties with my circular saw which seems to lead to item loss under some circumstances 01:42 Sokomine looks related 02:55 ShadowNinja I need a way to get all of the lists in a InvRef, specificaly a player InvRef. Is there any way to do that currently? If not can someone add it quickly? to_table or get_listnames would be good. 03:18 kahrl I thought that was added some time ago. Maybe not 05:16 ShadowNinja minetest.set_player_privs interprets false as true, you need to use nil to remove privileges. 05:16 ShadowNinja I may fix that tomorow if nobody else has yet. 12:01 PilzAdam kahrl, you should write "kahrl" and not "celeron55" as the copyright holder in new files 12:14 celeron55 PilzAdam: almost everyone has written my name on new files always so it's practically meaningless because no transfer of copyright ownership has really officially been made 12:15 celeron55 you can write "santa claus" there if you please; nobody can use the name there for any purpose anyway 12:15 celeron55 (except using it for contact information for asking who the actual copyright holder possibly might be) 12:16 PilzAdam its a good way to step away from the "celeron-centrtic development" 12:16 celeron55 in that case someone should look through git blames of files and correct the names where possible 12:26 lanxu heh. "moving away from celeron-centric development". Now supporting even more CPU brands, right? :> 15:08 kahrl whatever name is put there becomes meaningless after a while 15:09 kahrl I mean, look at the cpp files introduced by lua mainmenu, they all have (C) sapier but some have quite a number of edits by other people already 15:11 PilzAdam it gives the impression that many people work on Minetest instead of just one 15:11 PilzAdam (if you read the code) 15:12 kahrl well I don't really care about that 15:12 kahrl do people? 15:13 PilzAdam well, all the other arguments say that it doesnt matter 15:13 kahrl I think most would look at the authors of commits first instead of copyright lines 15:16 kahrl we could start adding a changelog with attribution at the top of every file, but that would really bloat up the commits with fluff 15:17 ShadowNinja No changelog in the repo, although one on a wiki or some such is good. (Which we already have) 15:17 PilzAdam well, I dont really care as long as celeron55 is ok when people write his name and as long as its allowed for contributors to put their name in new / mostly rewritten files 15:17 kahrl that's how it has been 15:19 celeron55 maybe the copyright notices could be changed to "Individual Minetest developers" or something; that would be truthful at least 15:19 PilzAdam I would be ok with removing all names too 15:20 kahrl yeah, me too 15:20 ShadowNinja "Minetest development team?" 15:21 celeron55 the copyright is not owned by any signle legal entity 15:21 celeron55 single* 15:22 celeron55 for example "Minetest development team" sounds like the team is some kind of a legal organization to which people transfer the copyrights and that can decide on licensing 15:24 VanessaE in American slang at least, "team" can also mean a loosely-organized group of people that merely follow a common goal. 15:24 PilzAdam is American slang used in courts now? 15:24 celeron55 8D 15:25 VanessaE actually, yes it is :P 15:25 VanessaE though the courts tend to prefer somewhat more well-defined concepts :) 15:26 celeron55 but the core thing here is that it doesn't actually matter what is written in there, so we might just as well let it be unless it's going to be changed to something more factual 19:53 ShadowNinja It seems visual_size only accepts x and y values, not z. Can that be added?