Time  Nick        Message
05:28 kahrl       anyone mind me pushing https://github.com/minetest/minetest/pull/639 (with s/BanName/ban_name)?
05:29 * kahrl     wants to see the pull request counter go down again
05:30 ShadowNinja Looks good to me.
10:08 kahrl       quick note here as well: sfan5 and I created a 0.4.8 milestone on github
10:09 kahrl       for pull requests and issues that should be dealt with one way or another before releasing 0.4.8
10:09 kahrl       we also looked through the issues and added some hopefully reasonable ones to the milestone
10:10 kahrl       discuss
10:10 VanessaE    Siscussion open, discussion closed.  All those in favor, signify by saying 'aye'.
10:10 VanessaE    ;)
10:10 VanessaE    Dis*
10:10 kahrl       aye ;)
10:10 VanessaE    aye :)
10:11 VanessaE    seriously though, the list for the milestone looks reasonable to me
10:11 VanessaE    pilz will balk at including #528 though
10:14 kahrl       "dealt with one way or another" - means it can be rejected or postponed as well
10:17 kahrl       it would be easy to make a new drawtype for the diagonal rail, what I'm wondering about is if the diagonal rail code is efficient enough
10:40 pitriss     kahrl: I probably found bug yesterday. enable_fog = false is ignored in latest git client...
10:45 proller     https://github.com/minetest/minetest/pull/897 flyy!
10:51 proller     kahrl, maybe include my liquid-weather stuff to 0.4.8 ?
10:53 kahrl       proller, which pull?
10:53 proller     https://github.com/minetest/minetest/pull/895
10:53 proller     https://github.com/minetest/minetest/pull/892
10:53 proller     https://github.com/minetest/minetest/pull/882
10:54 kahrl       can you add explanations what they do, squash them and remove the merge commits?
10:55 sfan5       pitriss: why do you want to disable fog?
10:56 proller     kahrl, better to squash before merge, to not squash 5+ times with every founded issue
10:56 pitriss     sfan5: just because i don't like it.. and disabling it by F3 every relog / server crash is bit uncomfortable
10:56 proller     some of have descriopion, but i will write more
10:56 kahrl       proller, I can't read that many commits so I won't review them
10:57 proller     here pure change: https://github.com/minetest/minetest/pull/892/files
10:57 pitriss     sfan5: btw it is mentioned in example conf.. so I expected it is working..
10:57 kahrl       pitriss: I can reproduce that, appears to only happen when shaders are enabled
10:58 kahrl       probably because of how the shader constants are set
10:59 pitriss     kahrl: ahh.. I hope it is possible to be fixed..
11:01 PilzAdam    proller, you can just git commit --ammend fixes, no need to commit and then squash all the time
11:01 PilzAdam    -m
11:02 proller     will try.. but usualy with git - more params->more problems
11:03 Exio4       its man page is useful too
11:04 kahrl       how does stuff like https://github.com/minetest/minetest/pull/892/files#L4L740 affect performance?
11:05 kahrl       this is a tight loop and this change adds at least one pointer dereference to every iteration
11:07 kahrl       (not even talking about the increased number of iterations)
11:10 Exio4       https://github.com/minetest/minetest/pull/892/files#L1R332
11:11 proller     kahrl, ok, will make var outside loop
11:12 proller     Exio4, its ok, nodeupdate too slow
11:12 proller     torch on ice will dropped in other abm
11:13 proller     without this impossible to make melting stone - its start drop all gravel and server stuck
11:19 kahrl       pitriss: https://gist.github.com/kahrl/6422576
11:21 pitriss     kahrl: ok thank you.. should I apply it to latest git or it will be merged with latest git?
11:22 sfan5       kahrl: in case you want to commit that diff to master, /me is ok with that
11:23 kahrl       sfan5: ok thanks, I'll merge it
11:27 proller     and micro this https://github.com/minetest/minetest/pull/899
11:40 Zeg9        Why can weather only be used with liquid_finite?
11:43 pitriss     kahrl: thanks.. It is working.. thank you very much..
11:43 proller     because melting will cause overflood
11:44 proller     with liquid_finite liquids have constant volume, without - WTF volume
11:51 Exio4       it is redhat sponsored Zeg9
11:51 Zeg9        ...
11:56 proller     i can enable it, but you get waterworld
11:57 Zeg9        I was saying "..." to Exio4 ;)
12:30 ironzorg    سمـووحخ خ خ خ امارتيخ خ
12:31 sfan5       that thing?
12:32 sfan5       do that in #freenode :P
12:43 rmilan      gepemrol
13:40 celeron55   <+kahrl> proller, I can't read that many commits so I won't review them
13:40 celeron55   you could just click the "Files Changed" thing 8)
13:41 celeron55   oh, that was actually mentioned already
13:41 celeron55   well it wasn't mentioned how to get that anyway
14:25 PilzAdam    there is a problem with hotbar.png: in survival I have a hotbar with 5 items, but in creative its 8; there is currently no way to set a different texture
14:25 PilzAdam    something like player:set_hotbar_texture() would be nice
14:48 Exio4       what's up with merging #893? it isn't like it is a big commit or so
14:49 Exio4       just for cleaning the pull/issues list
15:32 proller     kahrl, here fixed https://github.com/minetest/minetest/pull/892/files#L4R745
17:55 PilzAdam    https://github.com/minetest/minetest/pull/900
17:55 PilzAdam    this is the 900th pull request, it has to be merged ASAP ;-)
17:56 PilzAdam    (http://irc.minetest.ru/minetest-dev/2013-09-03#i_3299399)
18:00 troller     lets create ASAP list!
18:00 troller     my:
18:00 troller     https://github.com/minetest/minetest/pull/897
18:01 troller     https://github.com/minetest/minetest/pull/899
21:38 kahrl       pushing in a few minutes: https://gist.github.com/kahrl/6429954
21:44 PilzAdam    kahrl, fix minetest.conf.example too
21:45 kahrl       oh, forgot that
21:48 kahrl       https://gist.github.com/kahrl/6429954 updated
22:25 VanessaE    btw, why are shaders enabled by default anyway?
22:26 VanessaE    (considering the number of people who use dx)
22:31 BlockMen    PilzAdam, to #900. why setting it per player instead making a if hotbar_cnt != 8 then hotbar_image = "hotbar" + hotbar_cnt + ".png"?
22:33 PilzAdam    BlockMen, there might be usecases where mods want it per player
22:33 PilzAdam    e.g. if they want to highlight slot 4 or so
22:33 PilzAdam    or custom formspec skins
22:34 PilzAdam    (like the player texture mod)
22:34 BlockMen    formspec != hotbar
22:35 BlockMen    but beside that i noticed that liquid_range doesnt work for me
22:35 BlockMen    when setting it at source it shows no effect, when setting it at flowing it produces this -> http://i.imgur.com/tDdAZT5.png
22:36 proller     i'm for removing liquid_range
22:36 BlockMen    i'm for fixing it :P
22:37 proller     it have no sense
22:37 BlockMen    proller, it hase. e.g lava shouldnt flow as far as water
22:37 BlockMen    *-e
22:37 PilzAdam    BlockMen, what value have you set it to?
22:37 BlockMen    5
22:37 proller     https://github.com/minetest/minetest/pull/882 - its much better
22:38 proller     in -next branch lava have 4 levels
22:38 proller     * with liquid_finite
22:38 PilzAdam    proller, we are talking about normal liquids
22:38 proller     and.. sand+gravel have 1 levels
22:39 proller     PilzAdam, they not normal!
22:40 BlockMen    proller, as normal as block environment :P
22:40 proller     and somebody can make your "normal" like finite #882
22:41 proller     my friend tried minetest, and first words was like wtf with liquids here
22:43 PilzAdam    BlockMen, the bug appears when flowingliquids are in the map that are not allowed to appear, e.g. the 6th flowing node when you have set it to 5
22:45 PilzAdam    so it doesnt really need to be fixed, I guess
22:45 BlockMen    PilzAdam, ok. where it has to be set, source, flowing or both?
22:45 PilzAdam    flowing
22:45 PilzAdam    but set it in both
22:45 BlockMen    then it stops at 1
22:46 proller     good solution: https://github.com/minetest/minetest/pull/882/files#L4L432
22:46 PilzAdam    what does that mean, "it stops at 1"?
22:47 BlockMen    that means that its range is 1 altough its set to 5
22:48 PilzAdam    can you re-check that?
22:49 PilzAdam    proller, does getMaxlevel() work with liquid_range?
22:49 proller     no, level is vertical. range is horisontal
22:50 PilzAdam    then how is that a better solution?
22:50 BlockMen    PilzAdam, http://i.imgur.com/sPz9KIu.png
22:50 proller     its make same, but correct way
22:50 BlockMen    and in code "liquid_range = 5"
22:50 proller     you can adopt it for old liquids
22:51 PilzAdam    BlockMen, break a node next to it to force a liquid update
22:51 proller     and yo can make "range" up to 63
22:51 PilzAdam    it doesnt make the same, it simply ignore range now
22:51 BlockMen    PilzAdam, i did. i also placed new a couple times
22:52 PilzAdam    BlockMen, weird, it works for me
22:52 proller     PilzAdam, level param is like range (for you) but makes more
22:52 proller     and with levels no sense in range
22:53 PilzAdam    proller, but it doesnt work with the normal liquids, and thats what we are talking about currently
22:54 proller     because i dont want touch old liquids code, but somebody can
22:56 BlockMen    PilzAdam, well for me not. here i removed all neighbour nodes http://i.imgur.com/Dc20tLc.png
22:56 BlockMen    it definetly make wrong range
22:58 proller     BlockMen, just try leveled ;)
22:59 proller     https://forum.minetest.net/viewtopic.php?id=7033 - here all ready
23:02 kahrl       proller, do you have an idea why #862 might fail to bind/connect?
23:04 proller     need to test your suggestion about init vars
23:42 BlockMen    I found the bug. It is caused by the check on viscosity. In PilzAdams commit the range is just added for liquids with viscosity <= 1 https://github.com/minetest/minetest/blob/master/src/map.cpp#L2177
23:44 BlockMen    sry, in RealBadAngels commit