Time Nick Message 14:00 PilzAdam Id like to merge these 2 menu related pull requests: https://github.com/minetest/minetest/pull/722 https://github.com/minetest/minetest/pull/721 14:00 PilzAdam any objections? 14:00 VanessaE definitely merge those. :) 14:27 kahrl what should be done with the very old open pull requests? 14:27 kahrl like those from 2012, should they be closed with wontfix? 14:28 kahrl (except the obvious exceptions such as the leveldb pull request) 14:28 VanessaE leave them open, add a comment requesting a rebase 14:28 sfan5 *looks at pull list* 14:28 VanessaE and if no one rebases, *then* close it as "too old" or something else, I'd say 14:28 PilzAdam you cant generally say to close all the old pull requests 14:28 VanessaE ("won't fix" is just wrong) 14:29 PilzAdam maybe create a lavel "rebase" or "old" 14:29 PilzAdam *label 14:30 sfan5 what about "rebase-needed" 14:30 VanessaE yes 14:30 sfan5 label created 14:30 VanessaE but don't close until the submitter's had time (but failed) to do so. 14:30 VanessaE maybe auto-close in a month 14:31 kahrl well some of these are quite short and in rarely touched parts of the code, so not all really need a rebase 14:58 VanessaE well if not a rebase then at least the submitters could re-check their code to see if it still works with current git 15:03 kahrl true 15:05 PilzAdam Ill merge the menu related pull requests now since nobody seems to object 15:05 VanessaE PilzAdam: don't we want some kind of default menu theme to go with that? 15:05 PilzAdam clouds are the default 15:05 VanessaE well I mean a default overlay 15:06 kahrl I was thinking about doing a "pull request of the day" thing. Every day (if I have time) I pick a random open pull request and post it here and post some comment 15:06 VanessaE like that blocky white "minetest" logo we had for a short while.. 15:06 kahrl then maybe check if it can be rebased easily and whether it (still) works 15:06 kahrl would that be spammy? 15:06 VanessaE kahrl: not really, that seems perfectly fair to me 15:06 VanessaE if you're up to it of course. 15:07 PilzAdam one "problem" is to find another core dev when merging something 15:07 kahrl the picking code is really simple: http://paste.dy.fi/6UE 15:07 VanessaE kahrl: seems simple enough 15:08 kahrl and the output today is: Pull Request of the day: #657 Add mouse_sensitivity option -- https://github.com/minetest/minetest/pull/657 15:09 kahrl I think it can be merged, let me test it 15:09 VanessaE kahrl: you need something in there to keep you from getting the same pull request more than once though. 15:09 kahrl VanessaE: I was thinking about that, I'll think of something 15:09 kahrl heh double-think 15:10 VanessaE maybe just append number to a text file, re-read the file on each run or something 15:10 VanessaE heh 15:12 kahrl should they stay in the file forever? maybe only for a week / a month 15:12 VanessaE um... 15:12 VanessaE good question. 15:12 VanessaE I'd say 2 weeks? 15:12 kahrl sounds fair 15:19 kahrl pull request #657 seems to work fine. My only question is whether the sensitivity should be range limited 15:20 VanessaE is there a practical reason to do so? 15:20 VanessaE you might have some twitch players ;) 15:20 kahrl I set it to a really high value (like a billion or so) and now the camera angle is glitched 15:20 VanessaE ohjeez 15:21 VanessaE yeah, perhaps some insane-but-it-still-works limit then 15:21 PilzAdam kahrl, there are many ways to glitch the camera with settings 15:21 kahrl I set the sensitivity back to 0.2 but I can't change my yaw, and W moves back and S forward 15:22 kahrl range limit to 0.01 to 100? 15:27 kahrl also it'd be cool if this option was accessible from the GUI but it doesn't fit into the current option menu 15:27 kahrl I'll leave it for now 15:27 PilzAdam RBA is working on a GUI for whole minetest.conf IIRC 15:28 kahrl does it work with sapier's formspec based menu? 15:28 PilzAdam dunno 15:30 VanessaE it's supposed to be an external tool. 15:30 VanessaE so it should be independent of how the menu is implemented. 15:31 PilzAdam wich is nonsense 15:34 VanessaE maybe the plan is to integrate it into MT later on 15:34 VanessaE but for now, an external tool to configure this stuff would be easier to maintain and polish 15:37 kahrl should I push the mouse_sentivitity commit, any objections? https://gist.github.com/kahrl/5569240 15:38 kahrl -t +s -v +t -t +v 15:38 VanessaE looks good to me. 15:38 kahrl sensitivity is a hard word to type 15:38 PilzAdam seems good 16:08 PilzAdam thexyz, do you want to push the current translation before I run updatepo.sh? 16:19 thexyz PilzAdam: okay, will do 16:20 thexyz PilzAdam: done 16:23 VanessaE "Merge remote-tracking branch 'origin/master'" <-- evil evil merge commit 16:23 VanessaE :) 16:24 thexyz it's not 16:27 PilzAdam thexyz, updated po files 16:29 PilzAdam thexyz, can you update weblate? 16:30 thexyz sure 16:39 sfan5 aaand german had 100% translated again 16:39 sfan5 *has 16:39 PilzAdam thexyz, can you push it or should we wait for others too? 16:39 thexyz okay 16:40 thexyz done 16:42 sfan5 time for a new win build 16:45 sfan5 codeload.github.com is slow again... 16:46 PilzAdam why does building translations fail the first time I run it? 16:51 anonyme0245 hello all 16:55 anonyme0245 Is there any projets where i can help? 16:56 Calinou http://dev.minetest.net/TODO 16:56 Calinou http://dev.minetest.net/Changelog 16:56 anonyme0245 oh! sorry, i never see it... :S 16:56 anonyme0245 thank you 16:59 Calinou np 17:34 anonyme0245 Someone can say me where the treegen functions are called? 17:35 PilzAdam cant you just grep "make_tree"? 17:36 anonyme0245 yes, i added a new function... But I greped make_tree in MapGen, and I haven't find... 17:44 anonyme0245 It is visibly in mapgen_v6... but it wasn't very indicated... But thank you