Time  Nick         Message
06:21 thexyz       celeron55: really? it seems quite obvious for me
06:21 thexyz       should I port the fix and push it to 0.3?
13:22 celeron55    thexyz: no, until somebody is ready to make a windows and a launchpad release of it immediately after
13:22 celeron55    afaik launchpad sucks horse ass because it can't import git branches
13:23 celeron55    i mean, once you put the fix in the repo, like infinitely more people will go immediately troll around in all 0.3.2 servers
13:23 celeron55    they all need to be able to update immediately
13:24 celeron55    and i don't know from where they have gotten their minetests
13:25 celeron55    most likely from debian's and ubuntu's official repos -_-
13:25 celeron55    this is an ugly situation
13:31 celeron55    the optimal solution would be to first wake up all the packagers of 0.3 for ubuntu and debian and whatever is important, and then do everything all at once
13:32 celeron55    an another solution is to make the vulnerability the commit is fixing non-obvious enough and hope nobody starts popularizing it themselves 8)
13:32 celeron55    the third is to not bother until it's absolutely needed
13:34 celeron55    i mean, debian still has 0.3.1 while 0.3.2 was made 8 months ago
13:34 celeron55    fixing it and releasing 0.3.3 is roughly equal to doing nothing but releasing the vulnerability info
13:34 Exio         wow
13:34 Exio         and 0.3.1 is... 1 year ago?
13:34 celeron55    unless the first solution is used
13:35 celeron55    0.3.1 is 13 months
13:37 celeron55    of course we could intentionally be dicks, do things simply and let shit happen, but it's just not wise if you take anything into account
13:38 celeron55    unless we do research and get to the conclusion that most public 0.3 servers are pulled directly from github
13:41 celeron55    this is a rare case where not having released source would be better 8)
14:16 thexyz       why should we care about debian? why not just send email to every registered forum user telling them to update their mt 0.3 servers and post something on forum and blog?
14:24 RealBadAngel hi
14:25 RealBadAngel Celeron55, have you checked treegen commit?
15:28 celeron55    thexyz: maybe
15:29 celeron55    RealBadAngel: didn't i already check it? in any case, i'll not do that in the next few days
15:29 celeron55    busy with other stuff
15:30 RealBadAngel celeron55, you have seen work in progress, now its pulled
15:53 PilzAdam     https://github.com/celeron55/minetest/pull/369 comments?
16:14 Jeija        Is there any reason why these compiler warnings have not been fixed? https://github.com/Jeija/minetest/commit/84b48dd527dfd6a7a5d9419a3b18d1b0a33cd8f6
16:29 hmmmm        well the initialization is redundant
16:29 hmmmm        SColor should have an initializer with no arguments
16:29 hmmmm        try video::SColor color()
16:32 hmmmm        also your fix isn't much of a fix at all, should be seed = %llu
16:32 hmmmm        getMapSeed() returns a u64
19:46 thexyz       RealBadAngel: why do you #define PI instead of using M_PI?
19:52 thexyz       there's also something wrong with indentation here https://github.com/RealBadAngel/minetest/blob/3c21e926787bcd96f14bf9a2846fe806fc3351ff/src/treegen.cpp#L337
19:53 thexyz       i don't think this is too important, but still