Time  Nick       Message
10:31 Taoki      celeron55: Any news on RBA's lua keys patch? IIRC he did what was needed last time, and made a new pull request.
17:10 thexyz     why isn't that merged? https://github.com/celeron55/minetest/pull/268
17:12 darkrose   because you haven't pushed the merge button? go on, do it
17:13 PilzAdam   use git cherry-pick to not have the merge commits
17:14 thexyz     what's the problem with merge commits?
17:14 PilzAdam   they look ugly
17:15 thexyz     awful!
17:17 thexyz     shouldn't https://github.com/celeron55/minetest/pull/294/files be if(ii == 0 || vmanip.getNodeNoExNoEmerge(p1).getContent() == CONTENT_AIR) ?
17:21 PilzAdam   thexyz, can you sticky this http://minetest.net/forum/viewtopic.php?id=3829 ?
17:21 hmmmm      indeed it should be.  checking if it's contained in that voxel area is completely redundant.
17:23 hmmmm      actually, nevermind that, it's completely necessary
17:23 hmmmm      getNodeNoExNoEmerge returns CONTENT_IGNORE if it's outside of the area
17:23 hmmmm      and index() doesn't do any bounds checking
17:23 hmmmm      so, you must keep that code as is
17:24 hmmmm      err, rather, nevermind, sorry, i didn't realize you're assuming it to be air first
17:24 hmmmm      the final verdict is that you can change it
17:25 hmmmm      if it's not contained, it'll just not be CONTENT_AIR, so no invalid access would be made
17:28 rubenwardy thexyz: http://minetest.net/forum/viewtopic.php?id=3829 is closed, so I can not edit it any more.
17:29 rubenwardy can i get rights for it, or would it need to be unclosed?
17:31 thexyz     rubenwardy: opened again
17:33 PilzAdam   suggestion: Move leafdecay to builtin
17:34 PilzAdam   same reason as for falling
17:39 celeron55  i object
17:39 celeron55  it has an overhead
17:39 hmmmm      so do all abms
17:40 celeron55  yes
17:41 celeron55  such a low-intervalled ABM wastes resources if it's doing effectively nothing and there are no other ABMs of similar frequency, altough i don't know how much
17:42 celeron55  (that should be researched a bit)
17:47 PilzAdam   Is there any reason why there is no setting for FOV in minetest.conf?
17:48 Calinou    there is?
17:48 hmmmm      ...except there is
17:48 Calinou    fov = 72 is the default
17:49 hmmmm      it's hard coded as 72 in the server though
17:49 Calinou    in the server?
17:49 hmmmm      where it checks to see which blocks to send
17:50 Calinou    oh
18:35 Taoki      Excellent... I merged RBA's patch into my branch and it compiles. Player animations might happen within the next days
19:38 Taoki      Alright, finished updating some other stuff. Now I wonder how exactly to use the new player keys api, since you need to get some values and read them in an if statement, and I'm bad at lua
21:36 Taoki      Anyone here good with lua, willing to offer some help for the player script?
21:37 Taoki      How do you define a per-object field (eg: a string) to use on objects? For example, in a lua script, can I define a boolean or string or something, and have that hold a different value for each player (do an obj.myvalue == whatever check)
21:49 Taoki      Never mind actually, don't think I'll need that after all
22:18 qheaden    What code links the options selected on the main menu to the settings store in the g_settings struct?
22:19 qheaden    *stored in
22:24 qheaden    Nevermind. I found the binding in main.cpp.