| Time |
Nick |
Message |
| 03:20 |
|
SpaceManiac joined #luanti-dev |
| 05:00 |
|
MTDiscord joined #luanti-dev |
| 06:06 |
|
SpaceMan1ac joined #luanti-dev |
| 07:30 |
|
ivanbu joined #luanti-dev |
| 09:28 |
|
SFENCE joined #luanti-dev |
| 09:43 |
|
SFENCE joined #luanti-dev |
| 09:59 |
|
SFENCE joined #luanti-dev |
| 10:48 |
|
SFENCE joined #luanti-dev |
| 10:54 |
|
SFENCE joined #luanti-dev |
| 11:10 |
sfan5 |
merging #15848, #15850, #15824 soon |
| 11:10 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15848 -- Use fallback font correctly for fonts provided by the server by y5nw |
| 11:10 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15850 -- Fix Microsoft Visual Studio error: string is not a member of std #15843 by jgerrish |
| 11:10 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15824 -- Centered title in README.md and added icon by millennIumAMbiguity |
| 11:15 |
|
SFENCE joined #luanti-dev |
| 11:25 |
|
TenPlus1 joined #luanti-dev |
| 11:25 |
TenPlus1 |
Hi folks... |
| 11:25 |
TenPlus1 |
have any devs tried using the latest dev release to join an older 5.7 and below server ?? |
| 11:26 |
sfan5 |
maybe, maybe not |
| 11:26 |
sfan5 |
is it broken? |
| 11:26 |
TenPlus1 |
join Xanadu server and try opening the chest at spawn... they come up blank |
| 11:26 |
TenPlus1 |
yet singleplayer chests work fine, and using Luanti 5.10 works fine |
| 11:27 |
TenPlus1 |
also hii |
| 11:27 |
TenPlus1 |
I've tried all sorts of containers and chests, most of them blank out |
| 11:29 |
sfan5 |
it says |
| 11:29 |
sfan5 |
2025-03-01 12:29:06: WARNING[Main]: GUIInventoryList::draw(): The inventory location "nodemeta:2,11,-3" doesn't exist |
| 11:29 |
sfan5 |
if it worked before that's a bug |
| 11:30 |
TenPlus1 |
when I run 5.10 stable the chests work fine |
| 11:30 |
TenPlus1 |
when I run 5.11 stable the chests work fine |
| 11:30 |
TenPlus1 |
just the latest dev that's having issue now :() |
| 11:31 |
sfan5 |
that's interesting then. I don't think we've had many changes in this area |
| 11:32 |
TenPlus1 |
that's what has me confused... Xanadu server uses Minetest 5.7 so the player and maps aren't older versions |
| 11:32 |
sfan5 |
can you open an issue on github so we don't forget? |
| 11:32 |
TenPlus1 |
I'll copy the error you posted into it as well... |
| 11:33 |
TenPlus1 |
er, should I make it a Luanti issue or minetest-game issue ? |
| 11:33 |
sfan5 |
former |
| 11:33 |
TenPlus1 |
okies |
| 11:38 |
TenPlus1 |
This ok: https://github.com/luanti-org/luanti/issues/15852 |
| 11:45 |
TenPlus1 |
thanks for checking :P coffee time o/ |
| 11:52 |
|
SFENCE joined #luanti-dev |
| 12:08 |
|
YuGiOhJCJ joined #luanti-dev |
| 12:14 |
|
SFENCE joined #luanti-dev |
| 12:18 |
|
SFENCE joined #luanti-dev |
| 14:01 |
sfan5 |
@luatic do you still want to look at game#3182? |
| 14:01 |
ShadowBot |
sfan5: Error: That URL raised <HTTP Error 404: Not Found> |
| 14:01 |
sfan5 |
game#3182 |
| 14:01 |
ShadowBot |
sfan5: Error: That URL raised <HTTP Error 404: Not Found> |
| 14:01 |
sfan5 |
ShadowNinja: btw ^ |
| 14:02 |
|
SFENCE joined #luanti-dev |
| 14:09 |
MTDiscord |
<luatic> sfan5: looks ok |
| 14:46 |
|
hwpplayer1 joined #luanti-dev |
| 15:33 |
|
SFENCE joined #luanti-dev |
| 16:46 |
|
hwpplayer1 joined #luanti-dev |
| 16:49 |
|
SFENCE joined #luanti-dev |
| 17:01 |
|
SFENCE joined #luanti-dev |
| 17:21 |
sfan5 |
merging #15853 soon |
| 17:21 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15853 -- Android: update SDL support code by sfan5 |
| 17:37 |
ShadowNinja |
game#3182 |
| 17:37 |
ShadowBot |
https://github.com/luanti-org/minetest_game/issues/3182 -- [no sq] TNT thing & set blend = "clip" on spawned particles by sfan5 |
| 18:32 |
|
TheCoffeMaker joined #luanti-dev |
| 18:59 |
|
Desour joined #luanti-dev |
| 19:33 |
Krock |
Desour: ee9258cefd is a potential candidate for #15852, even though it does look correct. |
| 19:33 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15852 -- Chest Issue |
| 19:35 |
Desour |
mhm, I also looked at the commits we have so far in 5.12-dev, and the others all looked more innocent |
| 19:35 |
Krock |
aside from that I don't see any packet-related changes. packet because the inventory apparently wasn't sent to the client. |
| 19:36 |
Krock |
I do have a few patches to provide a CSM API to spy on the available inventories but rebasing those probably takes longer than a bisect. |
| 19:43 |
Desour |
it's indeed ee9258cefda49e2b33eaac45de47c74adab0d6a9 |
| 19:47 |
Krock |
> u32 m_read_offset = 0; // read and write offset |
| 19:47 |
Krock |
this is an invitation for misinterpretation |
| 19:51 |
Krock |
ptr uses the wrong offset |
| 19:55 |
Krock |
oh lol no it's trivial, Desour. Server::sendAddNode sends (u8) (remove_metadata ? 0 : 1); |
| 19:55 |
Krock |
it's read back in an inverted manner |
| 19:55 |
Krock |
"bool remove_metadata;" should be "bool keep_metadata;" |
| 19:56 |
Krock |
didn't test this yet but it seems to make sense |
| 19:56 |
Krock |
feel free to open a PR since you already started working on that. |
| 19:57 |
Desour |
the issue being in sendAddNode would also explain why it happens for mtg chests but not the trash can |
| 19:57 |
Krock |
I'd expect it to be sent via the block data but I guess there's more than that. |
| 19:57 |
Desour |
I only tested, it's probably better if you make the PR :) |
| 19:58 |
Desour |
the mtg chest changes the node when opened (probably swap_node), so that probably removes meta on client now |
| 19:58 |
Krock |
oh right! the model swap will indeed trigger this case. |
| 19:59 |
Krock |
just observed this live. the node metadata vanished after the server - client RTT |
| 20:01 |
Krock |
will push https://pastebin.com/raw/ayZs59x2 in 15 minutes unless there are objections |
| 20:06 |
Desour |
+1 |
| 20:17 |
Krock |
doing the push-up |
| 21:00 |
sfan5 |
irrlicht cannot cull our clouds correctly |
| 21:26 |
sfan5 |
merging #15851 soon |
| 21:26 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15851 -- Enforce minimum `client_mapblock_limit` depending on view range by sfan5 |
| 23:33 |
|
panwolfram joined #luanti-dev |
