Time |
Nick |
Message |
12:01 |
|
loggingbot_ joined #luanti-dev |
12:01 |
|
Topic for #luanti-dev is now FEATURE FREEZE IN EFFECT. Luanti (fka Minetest) core development and maintenance. Chit chat goes to #luanti. https://dev.luanti.org/ https://irc.luanti.org/ https://github.com/luanti-org |
12:02 |
sfan5 |
well we can always delete them later |
12:02 |
sfan5 |
so i'll push the commits once CI passes |
12:03 |
[MatrxMT] |
<y5nw> We can probably drop Cantonese and Literary Chinese (IMO particularly the latter) later if we want |
12:03 |
sfan5 |
the latter at least has a handful of useful translations even if nobody speaks this language :D |
12:22 |
sfan5 |
found some descriptions to fix in settingstypes.txt so I'll re-do the last two commits |
13:10 |
sfan5 |
ok so we should be ready for an RC |
13:38 |
|
wrrrzr joined #luanti-dev |
13:38 |
wrrrzr |
irc logs dont work\ |
13:41 |
|
turtleman joined #luanti-dev |
13:48 |
|
wrrrzr left #luanti-dev |
13:56 |
|
i3Riced joined #luanti-dev |
14:00 |
|
i3Riced joined #luanti-dev |
14:03 |
|
i3Riced joined #luanti-dev |
14:07 |
|
i3Riced joined #luanti-dev |
14:13 |
MTDiscord |
<luatic> i know it's extremely late for this, but: what if we change some use_texture_alpha = "opaque" defaults back to "clip"? |
14:13 |
MTDiscord |
<luatic> there are, despite all the years, still mods and servers which don't set use_texture_alpha properly e.g. for node boxes |
14:14 |
MTDiscord |
<luatic> a "clip" default would make many of these render correctly with minimal performance implications |
14:14 |
MTDiscord |
<luatic> and the extreme cases that really need the performance (i'm thinking erle's studs here) can still specify use_texture_alpha = "opaque" |
14:16 |
MTDiscord |
<luatic> that is, changing this default should hardly introduce (performance) regressions, but should fix (old) rendering breakage (stuff like windows being black, torches looking very weird, etc.) |
14:17 |
MTDiscord |
<luatic> alternatively, i might release a mod like alpha_workaround, but which does not commit the sin of setting "blend" everywhere |
14:18 |
sfan5 |
part of the idea was also to prevent xray texture packs for those nodes |
14:19 |
sfan5 |
and there's indeed some geometry merging we could perform when the mode is opaque |
14:28 |
MTDiscord |
<wsor4035> Will break mods that assume that is the default |
14:28 |
|
i3Riced79 joined #luanti-dev |
14:30 |
|
i3Riced6 joined #luanti-dev |
14:45 |
MTDiscord |
<luatic> wsor: i know, and this back-and-forth is why i didn't originally bring it up, but i am arguing that this "breakage" should hopefully be very unproblematic |
14:45 |
MTDiscord |
<luatic> whereas the current breakage breaks correct rendering for old mods and servers, and sadly it seems not all of them will ever get to fix things properly |
14:46 |
MTDiscord |
<luatic> but well, i'll probably opt for a better workaround mod 👍 |
14:46 |
MTDiscord |
<luatic> anyways re https://github.com/luanti-org/luanti/pull/15425#discussion_r1948101585, i wonder whether "clients" is a good term to use at all |
14:46 |
MTDiscord |
<luatic> it's more of a technical term. how would you even translate that to german? "Kunden"? "Klienten"? lol |
14:47 |
MTDiscord |
<luatic> i think "players" would be much more intuitive |
14:48 |
sfan5 |
our translation advice page says "clients" gets translated to "Clients" |
14:48 |
sfan5 |
but yes |
14:48 |
sfan5 |
it should be players |
14:49 |
MTDiscord |
<luatic> i think i'll piggy back #15736 to improve that then |
14:49 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15736 -- Tweak main menu server list behavior by siliconsniffer |
00:48 |
|
SpaceManiac joined #luanti-dev |
05:00 |
|
MTDiscord joined #luanti-dev |
07:02 |
|
ivanbu joined #luanti-dev |
08:45 |
|
hwpplayer1 joined #luanti-dev |
09:14 |
|
hwpplayer1 joined #luanti-dev |
09:22 |
|
Warr1024 joined #luanti-dev |
09:42 |
|
hwpplayer1 joined #luanti-dev |
09:44 |
|
hwpplayer1 joined #luanti-dev |
09:46 |
|
Warr1024 joined #luanti-dev |
09:51 |
|
hwpplayer1 joined #luanti-dev |
10:01 |
|
hwpplayer1 joined #luanti-dev |
10:45 |
|
hwpplayer1 joined #luanti-dev |
10:56 |
sfan5 |
merging #15741, #15766, #15764, #15763 in 15m |
10:56 |
sfan5 |
I will merge weblate after that |
10:56 |
sfan5 |
(did we even update it at the start of the feature freeze?) |
10:57 |
sfan5 |
we did not, lol |
10:57 |
sfan5 |
pgimeno: looks like you can turn it off now |
11:01 |
rubenwardy |
didn't do an RC either |
11:01 |
sfan5 |
we could do that now and release on wednesday or something |
11:02 |
sfan5 |
what matters is that we don't delay stuff further for no reason |
11:04 |
pgimeno |
turned off, thanks for the heads-up |
11:07 |
pgimeno |
blog#90 |
11:07 |
pgimeno |
ok, I will still serve those |
11:08 |
pgimeno |
blog#90 |
11:22 |
[MatrxMT] |
<Zughy> How does our weblate work? Do we manually need to update strings in there? |
11:22 |
[MatrxMT] |
<Zughy> Also we should rename it, it still says Minetest |
11:27 |
Krock |
wouldn't it be sufficient for weblate to just push to the repo from another remote URL? it's kind of a repository fork that's committed upon by their translation interface web UI |
11:30 |
sfan5 |
other projects do that and I think it's annoying to constantly have the commit log flooded by tiny weblate commits |
11:31 |
sfan5 |
https://gitlab.xfce.org/xfce/thunar/-/commits/master?ref_type=HEADS here's an example |
11:32 |
Krock |
I think our current approach with bulk update/merge is more pleasant than direct committing |
11:33 |
[MatrxMT] |
<y5nw> I think Weblate has an option to open PRs instead of pushing directly to the repo |
11:33 |
Krock |
it keeps the commits reasonably well apart so they can be skipped over when looking through the git log |
11:37 |
sfan5 |
https://github.com/luanti-org/luanti/commits/ci/ commits for review |
11:41 |
Krock |
clicked on a few translations; they do appear sane |
11:41 |
Krock |
except for the German one c0ee7859 ..... |
11:42 |
sfan5 |
yeah |
11:43 |
sfan5 |
wuzzy corrected it but in a way that's yet different |
11:51 |
sfan5 |
branch updated. got rid of the commits. |
11:52 |
sfan5 |
the latin translation also seems very useless |
11:53 |
sfan5 |
i'll drop it too |
11:53 |
sfan5 |
(this is all that's in it for reference https://github.com/luanti-org/luanti/commit/9b7ba9ddb5469edb9a76d703dd9c7a3a1a1ca503) |
11:55 |
[MatrxMT] |
<Zughy> Matrix took the last parenthesis as part of the link lol |
11:55 |
|
Desour joined #luanti-dev |
11:57 |
sfan5 |
Interlingua and Cantonese (Traditional Han script) also have literally a single translated string and it's LANG_CODE |
11:57 |
sfan5 |
in theory this could make sense for mod authors to be able to use these languages |
11:57 |
sfan5 |
but that's quite far fetched |
11:57 |
sfan5 |
should I remove them too |
11:57 |
sfan5 |
? |
12:00 |
[MatrxMT] |
<y5nw> I had a PR for translation language fallback; it dropped LANG_CODE |
14:56 |
MTDiscord |
<luatic> https://github.com/luanti-org/luanti/pull/15736#pullrequestreview-2604283778 |
14:56 |
MTDiscord |
<luatic> imo we can shove this into 5.11 ¯_(ツ)_/¯ |
15:05 |
MTDiscord |
<siliconsniffer> Sorry was afk. Thanks for taking care of this, "players" is indeed more fitting here. Happy to resolved your concern luatic :P |
15:23 |
|
Desour joined #luanti-dev |
15:53 |
MTDiscord |
<astra008.> The server list gets the number of players in a Minetest server from this: https://github.com/luanti-org/luanti/blob/master/src/server/serverlist.cpp#L52, correct? |
15:59 |
MTDiscord |
<rollerozxa> I believe it checks the length of the clients_list if that exists, but if clients_list is not sent then that is what's used yes |
16:05 |
|
i3Riced joined #luanti-dev |
16:06 |
|
i3Riced joined #luanti-dev |
16:18 |
|
hwpplayer1 joined #luanti-dev |
16:26 |
MTDiscord |
<luatic> okay, let's just shove in #15708 and then do the RC? |
16:26 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15708 -- Expose client version information in non-debug builds by rollerozxa |
16:27 |
sfan5 |
i have a small adjustment I want to do to the devtest unittest |
16:27 |
MTDiscord |
<luatic> okay sure |
16:28 |
MTDiscord |
<luatic> you want to turn it into a register_on_joinplayer? |
16:28 |
sfan5 |
no |
16:28 |
|
hwpplayer1 joined #luanti-dev |
16:38 |
|
i3Riced90 joined #luanti-dev |
16:40 |
|
Desour joined #luanti-dev |
16:49 |
|
Desour joined #luanti-dev |
16:55 |
sfan5 |
@luatic i made a few more changes now |
16:55 |
MTDiscord |
<astra008.> What is meant by RC? |
16:57 |
MTDiscord |
<siliconsniffer> Release Candidate, "pre-release release" |
16:58 |
|
SFENCE_arch joined #luanti-dev |
16:59 |
MTDiscord |
<luatic> sfan5: saw them, seems fine |
17:00 |
SFENCE_arch |
What is our state? Sohuld I build some RC or release for macOS now? |
17:02 |
MTDiscord |
<luatic> setmetatable(core.protocol_versions, {__newindex = function() end}) - could error here tbh |
17:03 |
sfan5 |
could |
17:03 |
sfan5 |
merging #15708 in 5m |
17:03 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15708 -- Expose client version information in non-debug builds by rollerozxa |
17:04 |
MTDiscord |
<luatic> i'll add the error real qucik |
17:04 |
sfan5 |
sure |
17:05 |
MTDiscord |
<luatic> ah wait |
17:06 |
MTDiscord |
<luatic> i realized it's just my piggy-backing that would postpone #15736 |
17:06 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15736 -- Tweak main menu server list behavior by siliconsniffer |
17:06 |
MTDiscord |
<luatic> i'll just undo that, make it a separate commit in 5.12 |
17:06 |
sfan5 |
please no more PRs in 5.11 |
17:06 |
sfan5 |
it doesn't really matter if the fix is in now or later, does it? |
17:06 |
MTDiscord |
<herowl> 😄 |
17:07 |
MTDiscord |
<luatic> i just feel bad if it's my piggy backing that postpones it when it's otherwise ready |
17:08 |
MTDiscord |
<siliconsniffer> I think it's a nice QoL improvement, would appreciate if it gets in. |
17:08 |
sfan5 |
there is no urgent need so it's not getting in |
17:09 |
MTDiscord |
<luatic> well, i'll re-push the piggy-backing commit then |
17:09 |
MTDiscord |
<luatic> ¯_(ツ)_/¯ |
17:13 |
sfan5 |
rc build with adjusted version running here -> https://github.com/luanti-org/luanti/tree/ci |
17:14 |
MTDiscord |
<luatic> tagged |
17:14 |
MTDiscord |
<luatic> i'll draw up a quick forum post |
17:15 |
MTDiscord |
<luatic> SFENCE_arch: you can build a RC for macOS if you'd like to now |
17:17 |
|
SFENCE joined #luanti-dev |
17:18 |
SFENCE |
luatic: working on it.... |
17:51 |
MTDiscord |
<luatic> https://forum.luanti.org/viewtopic.php?t=31339 forum post |
17:55 |
Krock |
updating the changelog PR .... |
18:08 |
Krock |
Are there any meeting points? The milestone is now empty and the RC builds on the way. |
18:10 |
Krock |
btw: it would be possible to create a release draft to include the builds. That would be a nice landing page for people who would like to test it. |
18:10 |
Krock |
Shall I set one up, or is someone already working on that? |
18:12 |
MTDiscord |
<luatic> i didn't know "release drafts" were a thing |
18:13 |
MTDiscord |
<luatic> i just commented on the commit to upload the un-matrjoshka'd zips 😄 |
18:13 |
MTDiscord |
<luatic> feel free to do that i'd say, then edit my forum post with the link to that |
18:14 |
MTDiscord |
<luatic> some users are apparently worried that the USK12 rating luanti got on Google Play and by some german authority may impede using luanti in education |
18:15 |
MTDiscord |
<luatic> we should maybe look into flagging servers |
18:15 |
MTDiscord |
<luatic> the possibility of an edu version has also been brought up, but there is not yet much to talk about |
18:15 |
sfan5 |
i don't think flagging servers will fix this |
18:22 |
Krock |
https://github.com/luanti-org/luanti/releases/tag/5.11.0-rc1 |
18:24 |
|
SFENCE joined #luanti-dev |
18:30 |
|
SFENCE joined #luanti-dev |
18:32 |
[MatrxMT] |
<y5nw> So it seems like the USK doesn't provide any details on the USK 12 rating besides "fantasy violence; content for various age groups // chat"? Ugh |
18:33 |
SFENCE |
luatic: Here is prerelease for apple silicon macOS. https://github.com/luanti-org/luanti/releases/download/5.11.0-rc1/Luanti_5.11.0-rc1_arm64.zip |
18:33 |
sfan5 |
i mean not like we can fix that |
18:34 |
SFENCE |
I have some troubles with x86_64 build. |
18:34 |
MTDiscord |
<luatic> SFENCE: is it signed? |
18:35 |
MTDiscord |
<sfence> Yes, it is signed for direct distribution. |
18:37 |
MTDiscord |
<luatic> alright, thanks |
18:48 |
Krock |
SFENCE: would "luanti-5.11.0-macos11.3_arm64.zip" be the correct name for this archive? currently it does not state "macos" or the macOS version in its name |
18:48 |
Krock |
or rather "luanti-5.11.0-rc1-macos11.3_arm64.zip" (added rc1) |
18:54 |
SFENCE |
Fixed. |
18:54 |
Krock |
thank you. |
19:25 |
|
siliconsniffer joined #luanti-dev |
19:45 |
SFENCE |
I have not idea what is happening. But x86_64 Luanti build Debug build works well, bud release build ends up with SIGSEG error. |
19:46 |
SFENCE |
Do we have somebody with intel mac, mac os 11.3 or newer, to test if it works on HW? To be sure that it is not only some stupid Rossetta problem? |
19:47 |
|
MTDiscord1 joined #luanti-dev |
19:49 |
SFENCE_arch |
Hmmm... looks like my previous IRC messages was not resend to Discord.... |
19:49 |
|
YuGiOhJCJ joined #luanti-dev |
19:58 |
|
SFENCE joined #luanti-dev |
20:05 |
|
sofar joined #luanti-dev |
20:14 |
[MatrxMT] |
<luatic> heads up, i will probably be taking a break for about a month to focus on my studies |
20:38 |
sfan5 |
SFENCE_arch: did you try with lldb |
20:43 |
|
imi joined #luanti-dev |
23:33 |
|
panwolfram joined #luanti-dev |