Time  Nick            Message
01:03 Ruslan1         Lone_Wolf: thank
01:03 Lone_Wolf       For what? :thinking:
01:04 Ruslan1         So I don’t need use http://minetesthosting.com
02:23 Prestige        Is there a list of existing servers that are popular?
02:57 Prestige        Ah I found it
13:42 fluxflux        hello all, got a crash i'm having trouble tracking down. server crashes whenever a player says e.g. "%40" in chat, because lua is interpreting that as a replacement pattern and blowing up. the stacktrace is not helpful:
13:42 fluxflux        minetest5/src/script/cpp_api/s_base.cpp:89: static int ScriptApiBase::luaPanic(lua_State*): A fatal error occurred: LUA PANIC: unprotected error in call to Lua API (...est/minetest_exec/minetest5/bin/../builtin/game/chat.lua:18: invalid capture index)
13:42 fluxflux        there's only one mod that's calling format_chat_message, and it doesn't seem to be responsible.
13:44 pyrollo         Nice finding
13:45 pyrollo         On local game, typing %1 makes chat echo "@message"
13:45 pyrollo         Typing %2 or more makes game crash
13:45 pyrollo         You should open a bug on Github
13:45 pyrollo         (tested on 5.1)
13:48 fluxflux        hm. okay, tested it on a 2nd server and didn't have the issue, so i assumed it wasn't core game
13:48 pyrollo         I'm about to test on last dev version
13:48 pyrollo         (it is compiling)
13:48 fluxflux        2nd server was on 5.0 though, i think
13:48 rubenwardy      That could be a vulnerability if passed to printf
13:49 fluxflux        hm. interesting point, lua's formatting is just a thin wrapper for printf, right?
13:53 pyrollo         Last dev version is also crashing when typing "%2"
13:53 fluxflux        seems to be a 5.1 thing
13:53 fluxflux        okay, i'll file a bug
13:53 pyrollo         Thanks
13:55 fluxflux        file against minetest or minetest_game, though?
13:55 sfan5           do you see minetest_game appear anywhere in the backtrace? no -> file it at the engine
13:56 fluxflux        right
13:56 fluxflux        builtin, not minetest_game. sorry.
14:02 ANAND           ^ Bug introduced by customizable chat-message format commit
14:03 ANAND           Ideally, the % char should be escaped properly
14:05 fluxflux        https://github.com/minetest/minetest/issues/9132
14:05 ANAND           Cool
14:05 ANAND           Working on a fix, thanks for reporting
14:05 fluxflux        np
14:06 sfan5           user input should not be given to gsub
14:06 fluxflux        has killed our server several times in the last couple days, after some turkish users showed up. not sure if that's related.
14:06 sfan5           don't try to escape input, instead write an alternative
14:09 ANAND           sfan5: I was thinking of replacing all occurrences of `%` in the chat message with `%%`
14:09 ANAND           Uh, `\%`, sorry
14:10 fluxflux        ANAND: i think %% would be correct here, but sfan seems to be suggesting that isn't safe either
14:10 sfan5           %% is indeed correct
14:10 sfan5           but this is a great demonstration why just escaping strings is an error-prone workaround
14:11 ANAND           Ah, so %% is the right way...
14:16 ANAND           message = message:gsub("%%", "%%%")
14:17 ANAND           Doesn't crash, but the % chat and everything after it is gone
14:17 ANAND           char*
14:18 fluxflux        ANAND: you want message:gsub("%%", "%%%%")
14:20 ANAND           fluxflux: You're right, "%%%%" works
14:28 ANAND           #9133
14:28 ShadowBot       https://github.com/minetest/minetest/issues/9133 -- Escape % characters in chat messages before formatting by ClobberXD
14:28 ANAND           fluxflux: ^
19:28 MinetestBot     02[git] 04sfan5 -> 03minetest/minetest: Rework packet receiving in ServerThread 13c10952b https://git.io/JeKbS (152019-11-19T19:27:20Z)
19:59 MinetestBot     02[git] 04paramat -> 03minetest/minetest: Move duplicated mapgen parameters to class MapgenBasic (#9134) 13b3c245b https://git.io/JeKNo (152019-11-19T19:59:17Z)
20:35 Elon_Satoshi    how does a minetest server work?
20:40 Elon_Satoshi    also, may I have an account on the wiki?
20:41 * Elon_Satoshi  wants to update the page on servers a bit, since now minetest does notify you when you register a new account, and asks you to type your password again
20:56 Krock           Elon_Satoshi: please PM Calinou
20:56 Elon_Satoshi    alright
21:09 Calinou         I think the wiki is no longer sending emails correctly, so creating accounts for others doesn't work…creation
21:09 Calinou         unless celeron55_ fixed it
21:09 Calinou         I could assign you a random password manually and tell you to change it though
21:10 Calinou         oh, they left :(
21:19 Copenhagen_Bram hmm
21:19 Copenhagen_Bram Calinou: no i'm right here
21:19 Copenhagen_Bram i was Elon_Satoshi
21:19 Copenhagen_Bram lol
21:19 Calinou         I sent you a PM