| Time |
Nick |
Message |
| 00:15 |
|
proller joined #minetest |
| 00:16 |
|
nepugia joined #minetest |
| 00:19 |
|
Lia joined #minetest |
| 00:20 |
|
illwieckz joined #minetest |
| 00:22 |
|
nixi joined #minetest |
| 00:31 |
|
est31 joined #minetest |
| 00:32 |
|
Cornelia joined #minetest |
| 00:39 |
|
swift110 joined #minetest |
| 00:47 |
|
nepugia joined #minetest |
| 01:03 |
Ruslan1 |
Lone_Wolf: thank |
| 01:03 |
Lone_Wolf |
For what? :thinking: |
| 01:04 |
Ruslan1 |
So I don’t need use http://minetesthosting.com |
| 01:12 |
|
Cornelia joined #minetest |
| 01:18 |
|
swift110 joined #minetest |
| 01:22 |
|
ANAND joined #minetest |
| 01:51 |
|
Kars joined #minetest |
| 02:03 |
|
fluxflux joined #minetest |
| 02:08 |
|
riff-IRC joined #minetest |
| 02:14 |
|
Cornelia joined #minetest |
| 02:17 |
|
Prestige joined #minetest |
| 02:23 |
Prestige |
Is there a list of existing servers that are popular? |
| 02:31 |
|
longerstaff13_ joined #minetest |
| 02:40 |
|
Cornelia joined #minetest |
| 02:57 |
Prestige |
Ah I found it |
| 04:07 |
|
Lone_WolfHT joined #minetest |
| 04:09 |
|
Cornelia joined #minetest |
| 04:22 |
|
Cornelia joined #minetest |
| 04:36 |
|
amenji joined #minetest |
| 04:50 |
|
amenji joined #minetest |
| 04:58 |
|
Cornelia joined #minetest |
| 05:19 |
|
norkle joined #minetest |
| 06:11 |
|
andyo joined #minetest |
| 07:05 |
|
TomTom joined #minetest |
| 07:21 |
|
supahati joined #minetest |
| 07:28 |
|
pyrollo joined #minetest |
| 07:29 |
|
jluc joined #minetest |
| 07:42 |
|
Norore joined #minetest |
| 07:54 |
|
CWz joined #minetest |
| 07:55 |
|
Volgaar joined #minetest |
| 08:39 |
|
ShadowNinja joined #minetest |
| 09:54 |
|
xSmurf joined #minetest |
| 10:21 |
|
longerstaff13_ joined #minetest |
| 10:32 |
|
gorilla_ joined #minetest |
| 11:00 |
|
Fixer joined #minetest |
| 11:06 |
|
gorilla_ joined #minetest |
| 11:36 |
|
longerstaff13_ joined #minetest |
| 11:36 |
|
proller joined #minetest |
| 11:45 |
|
dzho joined #minetest |
| 11:48 |
|
tpe joined #minetest |
| 11:58 |
|
Cornelia joined #minetest |
| 11:59 |
|
riff-IRC joined #minetest |
| 12:10 |
|
dzho joined #minetest |
| 12:22 |
|
YuGiOhJCJ joined #minetest |
| 12:37 |
|
Cornelia joined #minetest |
| 12:39 |
|
fluxflux joined #minetest |
| 13:00 |
|
Cornelia joined #minetest |
| 13:06 |
|
gorilla_ joined #minetest |
| 13:15 |
|
Cornelia joined #minetest |
| 13:21 |
|
sagax joined #minetest |
| 13:25 |
|
Cornelia joined #minetest |
| 13:29 |
|
proller joined #minetest |
| 13:42 |
fluxflux |
hello all, got a crash i'm having trouble tracking down. server crashes whenever a player says e.g. "%40" in chat, because lua is interpreting that as a replacement pattern and blowing up. the stacktrace is not helpful: |
| 13:42 |
fluxflux |
minetest5/src/script/cpp_api/s_base.cpp:89: static int ScriptApiBase::luaPanic(lua_State*): A fatal error occurred: LUA PANIC: unprotected error in call to Lua API (...est/minetest_exec/minetest5/bin/../builtin/game/chat.lua:18: invalid capture index) |
| 13:42 |
fluxflux |
there's only one mod that's calling format_chat_message, and it doesn't seem to be responsible. |
| 13:44 |
pyrollo |
Nice finding |
| 13:45 |
pyrollo |
On local game, typing %1 makes chat echo "@message" |
| 13:45 |
pyrollo |
Typing %2 or more makes game crash |
| 13:45 |
pyrollo |
You should open a bug on Github |
| 13:45 |
pyrollo |
(tested on 5.1) |
| 13:48 |
fluxflux |
hm. okay, tested it on a 2nd server and didn't have the issue, so i assumed it wasn't core game |
| 13:48 |
pyrollo |
I'm about to test on last dev version |
| 13:48 |
pyrollo |
(it is compiling) |
| 13:48 |
fluxflux |
2nd server was on 5.0 though, i think |
| 13:48 |
rubenwardy |
That could be a vulnerability if passed to printf |
| 13:49 |
fluxflux |
hm. interesting point, lua's formatting is just a thin wrapper for printf, right? |
| 13:53 |
pyrollo |
Last dev version is also crashing when typing "%2" |
| 13:53 |
fluxflux |
seems to be a 5.1 thing |
| 13:53 |
fluxflux |
okay, i'll file a bug |
| 13:53 |
pyrollo |
Thanks |
| 13:55 |
fluxflux |
file against minetest or minetest_game, though? |
| 13:55 |
sfan5 |
do you see minetest_game appear anywhere in the backtrace? no -> file it at the engine |
| 13:56 |
fluxflux |
right |
| 13:56 |
fluxflux |
builtin, not minetest_game. sorry. |
| 14:02 |
ANAND |
^ Bug introduced by customizable chat-message format commit |
| 14:03 |
ANAND |
Ideally, the % char should be escaped properly |
| 14:05 |
fluxflux |
https://github.com/minetest/minetest/issues/9132 |
| 14:05 |
ANAND |
Cool |
| 14:05 |
ANAND |
Working on a fix, thanks for reporting |
| 14:05 |
fluxflux |
np |
| 14:06 |
sfan5 |
user input should not be given to gsub |
| 14:06 |
fluxflux |
has killed our server several times in the last couple days, after some turkish users showed up. not sure if that's related. |
| 14:06 |
|
gorilla_ joined #minetest |
| 14:06 |
sfan5 |
don't try to escape input, instead write an alternative |
| 14:09 |
ANAND |
sfan5: I was thinking of replacing all occurrences of `%` in the chat message with `%%` |
| 14:09 |
ANAND |
Uh, `\%`, sorry |
| 14:10 |
fluxflux |
ANAND: i think %% would be correct here, but sfan seems to be suggesting that isn't safe either |
| 14:10 |
sfan5 |
%% is indeed correct |
| 14:10 |
|
tomraceror joined #minetest |
| 14:10 |
sfan5 |
but this is a great demonstration why just escaping strings is an error-prone workaround |
| 14:11 |
ANAND |
Ah, so %% is the right way... |
| 14:15 |
|
sec^nd joined #minetest |
| 14:16 |
ANAND |
message = message:gsub("%%", "%%%") |
| 14:17 |
ANAND |
Doesn't crash, but the % chat and everything after it is gone |
| 14:17 |
ANAND |
char* |
| 14:18 |
fluxflux |
ANAND: you want message:gsub("%%", "%%%%") |
| 14:20 |
ANAND |
fluxflux: You're right, "%%%%" works |
| 14:22 |
|
mensious joined #minetest |
| 14:28 |
ANAND |
#9133 |
| 14:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/9133 -- Escape % characters in chat messages before formatting by ClobberXD |
| 14:28 |
ANAND |
fluxflux: ^ |
| 14:36 |
|
proller joined #minetest |
| 14:37 |
|
longerstaff13 joined #minetest |
| 14:55 |
|
AntumDeluge joined #minetest |
| 14:56 |
|
Lia joined #minetest |
| 15:06 |
|
gorilla_ joined #minetest |
| 15:09 |
|
Cornelia joined #minetest |
| 15:53 |
|
Ruslan1 joined #minetest |
| 15:58 |
|
Lone_WolfHT joined #minetest |
| 16:06 |
|
gorilla_ joined #minetest |
| 16:25 |
|
mensious joined #minetest |
| 16:27 |
|
DI3HARD139 joined #minetest |
| 16:39 |
|
DI3HARD139 joined #minetest |
| 16:41 |
|
majochup joined #minetest |
| 17:03 |
|
twoelk joined #minetest |
| 17:06 |
|
gorilla_ joined #minetest |
| 17:12 |
|
swift110 joined #minetest |
| 17:12 |
|
swift110 joined #minetest |
| 17:37 |
|
Krock joined #minetest |
| 17:38 |
|
nepugia joined #minetest |
| 17:57 |
|
xSmurf joined #minetest |
| 18:03 |
|
swift110 joined #minetest |
| 18:06 |
|
gorilla_ joined #minetest |
| 18:13 |
|
FreeFull joined #minetest |
| 18:46 |
|
FreeFull joined #minetest |
| 19:06 |
|
gorilla_ joined #minetest |
| 19:13 |
|
xSmurf joined #minetest |
| 19:24 |
|
ensonic joined #minetest |
| 19:28 |
MinetestBot |
[git] sfan5 -> minetest/minetest: Rework packet receiving in ServerThread c10952b https://git.io/JeKbS (2019-11-19T19:27:20Z) |
| 19:58 |
|
Cornelia joined #minetest |
| 19:59 |
MinetestBot |
[git] paramat -> minetest/minetest: Move duplicated mapgen parameters to class MapgenBasic (#9134) b3c245b https://git.io/JeKNo (2019-11-19T19:59:17Z) |
| 20:03 |
|
Norore joined #minetest |
| 20:06 |
|
gorilla_ joined #minetest |
| 20:09 |
|
TomTom joined #minetest |
| 20:10 |
|
ensonic joined #minetest |
| 20:35 |
Elon_Satoshi |
how does a minetest server work? |
| 20:37 |
|
proller joined #minetest |
| 20:38 |
|
Ruslan1 joined #minetest |
| 20:40 |
Elon_Satoshi |
also, may I have an account on the wiki? |
| 20:41 |
* Elon_Satoshi |
wants to update the page on servers a bit, since now minetest does notify you when you register a new account, and asks you to type your password again |
| 20:56 |
Krock |
Elon_Satoshi: please PM Calinou |
| 20:56 |
Elon_Satoshi |
alright |
| 21:00 |
|
Copenhagen_Bram joined #minetest |
| 21:06 |
|
gorilla_ joined #minetest |
| 21:09 |
Calinou |
I think the wiki is no longer sending emails correctly, so creating accounts for others doesn't work…creation |
| 21:09 |
Calinou |
unless celeron55_ fixed it |
| 21:09 |
Calinou |
I could assign you a random password manually and tell you to change it though |
| 21:10 |
Calinou |
oh, they left :( |
| 21:19 |
Copenhagen_Bram |
hmm |
| 21:19 |
Copenhagen_Bram |
Calinou: no i'm right here |
| 21:19 |
Copenhagen_Bram |
i was Elon_Satoshi |
| 21:19 |
Copenhagen_Bram |
lol |
| 21:19 |
Calinou |
I sent you a PM |
| 22:06 |
|
gorilla_ joined #minetest |
| 23:06 |
|
gorilla_ joined #minetest |
| 23:08 |
|
riff-IRC joined #minetest |
