Time Nick Message 17:09 Jordach PilzAdam, whats the basecolour example for crafting by using dyes> 17:09 PilzAdam what? 17:09 Jordach like basecolour_red 17:09 Jordach so unifieddyes:red will work alongside dyes:red 17:10 Jordach feck it 17:10 Jordach ill write an alternative] 18:24 Jordach PilzAdam, using the 0.4.4 build, and by using the stairs.register functions, the game oddly crashes 18:25 PilzAdam debug.txt? 18:27 Jordach http://paste.ubuntu.com/1443877/ 18:28 PilzAdam when i was reading the code i wondered why it doesnt crash 18:28 PilzAdam seems noone tryed to register stairs or slabs before 18:28 PilzAdam will fix this 18:29 thexyz PilzAdam: they probably just copied everything from stairs mod 18:29 Jordach http://ompldr.org/vZ3B4ag/xmas.zip 18:29 PilzAdam no, if you call stairs.register_[...] in any mod it has to prefix the modname and not stairs 18:29 PilzAdam i know this bug from farming 18:30 Jordach add the entire contents of notworkingcode.txt to presents.lua 18:30 thexyz how about just adding ":"? 18:30 thexyz prepending* 18:30 PilzAdam minetest.get_current_mod_name() 18:30 PilzAdam this should work 18:30 thexyz ok 18:30 PilzAdam Jordach, can you test it? 18:30 Jordach PilzAdam, oldcoder requires this for his server 18:31 thexyz PilzAdam: also, doesn't your item_drop mod fixes this https://github.com/celeron55/minetest/issues/107 18:31 thexyz well, some part of your item_drop 18:31 PilzAdam yes, it does 18:31 Jordach PilzAdam, that wont work 18:31 Jordach the crafts are non movable 18:31 thexyz why is it still not fixed then?) 18:31 Jordach (eg, the function needs a full re-write) 18:32 PilzAdam Jordach, what do you mean by "the crafts are non movable"? 18:32 Jordach they are stairs:slab_ .. modname 18:33 Jordach the function would need to be re-written 18:33 PilzAdam wait, I will prepare a patch 18:38 PilzAdam https://github.com/PilzAdam/minetest_game/commit/59ee97b01dfb9a095bffd8550a30a4a5596ea83c 18:39 PilzAdam Jordach, can you test the mod with this? 18:46 Jordach PilzAdam, works 18:47 PilzAdam thexyz, merge it? 18:48 thexyz hm.. i'd prefer single call to get_modname though 18:53 PilzAdam thexyz, https://github.com/PilzAdam/minetest_game/commit/8c977451a8d6336a28bf07bc4a3762bd62500720 18:53 PilzAdam fixed 18:53 Jordach ehm 18:53 Jordach shits 18:53 Jordach PilzAdam, what if it did work 18:54 thexyz feel free to merge if it still works 18:54 Jordach because i called it before and it worked 18:54 Jordach that may make some mods bugged 18:54 PilzAdam there is no way that it worked before 18:56 Jordach huh 18:56 PilzAdam so anything against merging this? 18:56 thexyz if it works, feel free to merge 18:59 VanessaE thexyz: ok that profiler is finally installed and I guess it's running (all mods have been profiled and the server is up). 18:59 VanessaE now what do I do? Where is the output saved at? 18:59 thexyz you should /stop firstly 18:59 thexyz then it'll be somewhere 18:59 VanessaE done. 18:59 VanessaE ok got it. it dropped a file in my homedir. 18:59 thexyz probably in the same dir as the one minetestserver is started from 19:00 VanessaE nothing of interest in the file though. 19:00 VanessaE Total time spent in profiled functions: 0s 19:01 VanessaE oops, just realized I was on the wrong channel here. oh well 19:01 VanessaE 6 of one, half a dozen of the other. 19:01 thexyz ? 19:02 VanessaE anyway, every init.lua in my mods tree has the profiler installed at the top of the file (your profiler hook kept returning attempt-to-concatenate-nil errors) 19:02 Jordach hey VanessaE 19:02 VanessaE except for a couple of init.lua's that were just comments originally. 19:03 thexyz VanessaE: you should only call profiler function once 19:03 VanessaE hi Jordach 19:03 VanessaE *facepalm* 19:03 thexyz that can be done in separate mod 19:03 thexyz as i told you yesterday 19:03 VanessaE I didn't fully understand yesterday - I was probably too tired. 19:04 VanessaE but to be fair, your russian text is too terse and didn't translate too clearly. 19:04 VanessaE ok, lemme separate this out. 19:17 VanessaE thexyz: FAIL. 19:17 thexyz ? 19:17 VanessaE /home/vanessa/.minetest/games/other_testing/mods/{any mod name here}/init.lua: 19:17 VanessaE ...minetest/games/other_testing/mods/particles/init.lua:1: attempt to concatenate a nil value 19:17 VanessaE maybe the profiler needs to be in depends.txt also? 19:18 thexyz you're doing it wrong then 19:19 thexyz create new mod named "profiler" 19:19 VanessaE make a mod out of profiler.lua -- done. 19:19 VanessaE insert your hook at the top of each suspect init.lua -- done. 19:19 thexyz FAIL 19:19 thexyz who said you should do that? 19:19 VanessaE you did. 19:19 VanessaE " Next in the file init.lua , preferably at the beginning, write the following magical text:" 19:19 VanessaE (your hook) 19:19 thexyz ok, let me explain again 19:20 thexyz create new directory, named profiler 19:20 thexyz put profiler.lua in here 19:20 VanessaE done. 19:20 thexyz put init.lua in here 19:20 thexyz write code from wiki article in that init.lua 19:20 VanessaE AH! 19:20 thexyz don't touch anything else 19:21 thexyz VanessaE: well, the text in wiki is correct too, but you shouldn't write this text to all mods 19:21 thexyz to all mods' init.lua-s 19:21 VanessaE right - the wiki makes it sound like that hook goes into all mods. 19:21 VanessaE ok, lemme fix this the *right* way :-) 19:24 VanessaE ok. 19:24 VanessaE All mods are back to my regular, unmodified files that run on the server. 19:24 VanessaE Now. 19:24 VanessaE mkdir profiler 19:25 VanessaE download profiler.lua and put it in there --done. 19:25 VanessaE copy your hook into profiler/init.lua --done 19:25 VanessaE fix the first line of the init.lua to get rid of the Cyrillic in favor of: 19:25 VanessaE dofile(minetest.get_modpath('minetest.get_current_modname()')..'/profiler.lua') 19:26 VanessaE copy the whole profiler folder into the mods directory of my test game directory (which is currently an exact copy of the live server one) 19:27 VanessaE start the game using the test game (I've done this many times before, I know it works fine) 19:27 VanessaE 14:23:13: ERROR[main]: /home/vanessa/.minetest/games/other_testing/mods/profiler/init.lua: 19:27 VanessaE 14:23:13: ERROR[main]: ....minetest/games/other_testing/mods/profiler/init.lua:1: attempt to concatenate a nil value 19:27 thexyz i can't say anything except: deeerp 19:27 thexyz > 'minetest.get_current_modname()' 19:27 thexyz why do you use quotes here> 19:27 thexyz ? 19:27 VanessaE oh fuck. 19:27 VanessaE *facepalm* 19:28 VanessaE because I'm an idiot, that's why :-) 19:28 Jordach VanessaE, nope.avi 19:28 PilzAdam VanessaE, isnt VanessaE 2.0 out already? 19:28 NakedFury it was delayed 19:28 VanessaE eh? 19:28 NakedFury stuck at VanessaE 1.75 19:28 PilzAdam better AI etc. 19:29 VanessaE THERE we go. 19:29 VanessaE now we're getting somewhere. 19:29 PilzAdam VanessaE, I bet its technic who causes the 100% CPU 19:29 VanessaE possibly. 19:29 PilzAdam *wich 19:29 Jordach i had a VERY RUDE joke 19:29 Jordach .] 19:29 Jordach . 19:29 Jordach yes the full stop 19:29 VanessaE I've disabled significant parts of it already though. 19:31 thexyz VanessaE: don't forget to publish this "profiler" mod to minetest mod releases 19:31 VanessaE thexyz: thanks for the help. the profiler is now installed on the server and running. 19:32 VanessaE I'll publish it if it gives me some useful output :-) 19:38 NakedFury What does it do? 19:38 VanessaE it tells CPU usage and other statistics on a per-file basis if I'm reading it right 19:38 VanessaE should help me find out which mod keeps spiking to 100% CPu and just staying there.