Time Nick Message 12:40 kilbith one should make a forum mod using hypertext 12:41 kilbith or a reddit mod 14:47 * Sokomine plugs a cable into tomraceror 14:47 ANAND lol :) 19:21 Peppy Hi 19:23 Peppy I still can't import xban.db to sban any help welcome 19:24 Peppy minetest, xban and sban are up to date, i'm running Xubuntu, lsqlite3 was installed via luarocks 19:26 Peppy command "/ban_dbe xban.db" fails with "sban/init.lua:1108: attempt to concatenate local 'q' (a nil value)" 19:39 Krock seems like a mod error 19:39 Krock !mod sban 19:39 MinetestBot Krock: SQLite Ban [sban] by shivajiva - https://forum.minetest.net/viewtopic.php?t=18603 19:40 Krock oh 19:40 Krock Peppy: https://github.com/shivajiva101/sban/blob/master/init.lua#L1104 change to 19:40 Krock local q = "" 19:41 Krock If it still does not work, please paste the new error (paste service?) 19:45 Peppy thanks Krock, i'll try this at once :) 19:45 shivajiva first thing I noticed was that's the export command, don't you want the import command /ban_dbi xban.db 19:47 Peppy well, /ban_dbi xban.db fails too but game won't crash 19:47 shivajiva how big is the xban.db file? 19:48 shivajiva it spits an sql file out for import if it's to large 19:49 Peppy i did reset xban.db, it crashed too 19:50 Peppy mod suggested by Krock works ok, i'll try with my full xban.db (1.3 Mb) 19:51 shivajiva it will stop the crash but may cause other bugs, need to understand why nil data is entering that function really 19:52 Peppy full xban.db now fails with "sban/init.lua:1128: bad argument #6 to 'format' (number expected, got string)" 19:52 ShadowBot https://github.com/minetest/minetest/issues/6 -- Apples on the trees can not be eaten 19:53 Peppy trying ban_dbi 19:54 Peppy ban_dbi > "processing 6489 records" in the log but no data output 19:56 shivajiva I'll try and trace the issue, without a successful import it's only going to cause more issues that don't exist 20:03 Peppy fyi : I get the same error with a smaller xban.db I got with xban_cleanup 20:03 Peppy (< 100Ko) 20:04 Krock > issues that don't exist 20:05 Krock that would rather be follow-up issues caused by erroneous import 20:05 Krock unhandled edge-cases 20:10 shivajiva don't worry I'm sure it's my fault =) 20:12 shivajiva at the very least I didn't initialise a string I then tried to concatenate 20:15 Krock *cough* testing 20:20 shivajiva I see I'm allowing expires to become a string but I have asserted integer in format for the second error 20:23 shivajiva which is some niggle I have about missing expiration needing some kind of initialisation to the process rather than using nothing lmao 20:23 shivajiva if you follow 20:27 Krock well, tbh I can't follow there 20:31 shivajiva it just has broader implications I've been avoiding thus far by not typing the input strongly at the start and then trying to encapsulate it later 20:33 shivajiva the solution is simple enough, make 0 the default for a full ban for the expires field and encompass that logic 20:34 shivajiva now the code is being rigid about the type of it's field input 20:38 shivajiva it's not like sqlite is fussy, that would have nipped it in the bud :P 20:46 shivajiva https://github.com/shivajiva101/sban/blob/master/init.lua#L1356 shows it's already partially instated 20:56 shivajiva looks like I just missed a couple of instances of use 20:57 Krock shivajiva: btw, is there already a GUI for it? 20:58 shivajiva yes 20:59 shivajiva search bang 20:59 Krock Ah. apparently /bang is supposed to show it 21:02 shivajiva just my humour :) 21:02 Krock Wild west feelings 21:09 shivajiva the ambiguity of the s prefix I use amuses me also, I/m sure it comes to mean something to everyone that uses it other than it's designation 21:11 shivajiva but I was thinking 'Cillit Bang and the dirt is gone' at the time :D 21:13 Krock 'Cthulhu Bang and it's still not gone' 21:26 Peppy Thanks a lot shivajiva an Krock for investigating this, I can't wait to get rid of xban and namesperip ! 21:27 shivajiva think I added or am going to add ip's per id option 21:28 Peppy you did irrc 21:29 Peppy name per ip whitelist (or perplayer limit raise) would be a must 21:30 shivajiva got my head in SimulIDE for the crack this weekend just to see how useful it is. whitelist is an override for the other features 21:32 shivajiva you can't keep the owner out either or ban them or limit them in any way 21:33 shivajiva as it should be 21:35 Peppy the idea is to set 2 names max per ip but being able to raise limit if players has more brothers/sisters playing 21:36 Peppy without raising the overall limitation 21:47 shivajiva it will keep the db nice and compact and discourage vpn users though as they will be locked out of their account rapidly 21:49 shivajiva ip limit field needs adding for that sort of granularity with an unlimited option in the construct 22:07 shivajiva try that Peppy 22:09 Peppy ? 22:15 Peppy I don't get it 22:18 Peppy I don't need IP limitation but name limitation (sban.accounts_per_ip) 22:18 Peppy I won't be able to use sban until import from xban is fixed though 22:19 Peppy thanks anyway 22:33 shivajiva Peppy: I assumed I'd fixed it on the last commit 35 mins ago 22:33 shivajiva did you try it? 22:36 Peppy ho didn't know you commited, i'll try this right now, thanks ! 22:39 Peppy ban_dbe xban.db >"init.lua:1108: bad argument #3 to 'format' (number expected, got nil)" 22:39 ShadowBot https://github.com/minetest/minetest/issues/3 -- Furnace segfault 22:39 Peppy i'll try with my lighter xban.db 22:43 Peppy same :/ 22:43 Peppy but still works with fresh xban.db 22:44 shivajiva yes that's caused by a nil last seen entry coming from xban.db, looks like I need to handle that also 22:47 shivajiva dw I'll get there 22:48 shivajiva I think this was the main reason I didn't strongly type the fields in the first place, so I could get a working import 22:52 Peppy well, don't feel like you have to solve this right now, I've lived with xban and namesperip for years now xD 22:54 Peppy I like so much when "/ipnames whois " returns "No such user" :D 22:56 Peppy works too with the guy that left 3 min ago... 22:56 Peppy xban does log him though 23:08 shivajiva okay updated, try again if you wish 23:09 Peppy trying right now 23:12 Peppy ban_dbe dumped a 2Mb file :) 23:12 shivajiva ;) 23:13 Peppy ban_dbi fails thoug 23:14 Peppy h 23:14 shivajiva silently? 23:14 shivajiva nothing logged 23:16 Peppy says "processing 6489 records" in the log, sban.sqlite didn't grow 23:18 shivajiva okay I'll work on fixing that, thanks for taking the time to report all this instead of giving up :) 23:19 Peppy I have an error if I try to import xban.sql into a new database : 23:20 Peppy #258 : UNIQUE constraint failed: address.ip. 23:20 ShadowBot https://github.com/minetest/minetest/issues/258 -- Make it clearer that the first login to a server is also a registration 23:22 Peppy If I try to import into sban.sqlite I get "#139 : UNIQUE constraint failed: address.ip." 23:22 ShadowBot https://github.com/minetest/minetest/issues/139 -- /mods command to see mod list 23:23 Peppy looks like some data was imported but only a bit of it 23:27 Sokomine ah. er. wondering why cpu usage is so high...but just starting compiling latest mt on another terminal :-) 23:28 shivajiva okay, this is going to take a bit of time to unmangle 23:28 shivajiva Hi Sokomine 23:29 Peppy oh, I notice this too : game chat says "xban2 dumped to xban.db" witch is wrong 23:29 Peppy should be "xban2 dumped to xban.sql" 23:32 Peppy Hi Sokomine 23:32 Peppy shivajiva : well, anyway feel free to ask me to test anything 23:33 Peppy thanks 23:35 shivajiva will do, I'll let you know when I think I have sussed it 23:37 shivajiva something to do with not processing duplicates correctly