| Time |
Nick |
Message |
| 00:14 |
|
GreenDimond joined #minetest-hub |
| 00:19 |
|
NathanS21 joined #minetest-hub |
| 01:13 |
|
redneonglow joined #minetest-hub |
| 01:37 |
|
Jordach joined #minetest-hub |
| 01:57 |
|
ANAND joined #minetest-hub |
| 03:10 |
|
garywhite joined #minetest-hub |
| 03:25 |
|
loggingbot_ joined #minetest-hub |
| 03:25 |
|
Topic for #minetest-hub is now Offtopic welcome if brief, otherwise use #minetest-chat | Info/Rules: http://hub.minetest.net/ | Logs: http://irc.minetest.net/minetest-hub/ |
| 04:21 |
|
Ruslan1 joined #minetest-hub |
| 07:54 |
|
longerstaff13 joined #minetest-hub |
| 07:54 |
|
longerstaff13 joined #minetest-hub |
| 08:22 |
|
FrostRanger joined #minetest-hub |
| 08:50 |
|
atorian37 joined #minetest-hub |
| 09:08 |
|
atorian37 joined #minetest-hub |
| 09:46 |
|
atorian37 joined #minetest-hub |
| 10:03 |
|
FrostRanger joined #minetest-hub |
| 10:06 |
|
atorian37 joined #minetest-hub |
| 10:35 |
|
Fixer joined #minetest-hub |
| 10:59 |
|
atorian37 joined #minetest-hub |
| 11:54 |
|
Jordach joined #minetest-hub |
| 12:21 |
|
Jordach_ joined #minetest-hub |
| 12:23 |
|
T4im joined #minetest-hub |
| 12:27 |
|
FrostRanger joined #minetest-hub |
| 12:33 |
|
Gael-de-Sailly joined #minetest-hub |
| 13:08 |
Jordach |
>someone authed as me |
| 13:08 |
Jordach |
>it's the macbook waking from sleep |
| 13:18 |
|
calcul0n joined #minetest-hub |
| 13:46 |
|
aerozoic joined #minetest-hub |
| 13:47 |
|
Jordach_ joined #minetest-hub |
| 13:52 |
|
calcul0n joined #minetest-hub |
| 14:37 |
rubenwardy |
!seen tenplus1 |
| 14:37 |
MinetestBot |
rubenwardy: tenplus1 was last seen at 2018-11-03 17:09:20 UTC on #minetest-hub |
| 14:39 |
Jordach |
rubenwardy, looks like we left him behind at #live D: |
| 14:57 |
|
Jordach_ joined #minetest-hub |
| 14:59 |
|
Jordach_ joined #minetest-hub |
| 15:35 |
Jordach |
apparently mousewheeling in Konversation renames me |
| 15:40 |
rubenwardy |
you probably have the nick changer focused |
| 15:44 |
|
Ruslan1 joined #minetest-hub |
| 16:09 |
|
ANAND joined #minetest-hub |
| 16:10 |
Fixer |
Jordach: to update windows 10 |
| 16:27 |
|
greeter joined #minetest-hub |
| 16:43 |
Fixer |
found paramat's alt https://forum.minetest.net/viewtopic.php?f=15&t=9724&view=unread#p334612 |
| 16:44 |
rubenwardy |
u wot |
| 16:57 |
* Fixer |
runs away just for sure |
| 17:12 |
rubenwardy |
so, discussion point: |
| 17:12 |
rubenwardy |
how should concept approvals work? |
| 17:12 |
rubenwardy |
a few times recently, PRs have been reviewed and such and then rejected even by the reviewer for conceptal reasons |
| 17:13 |
rubenwardy |
because the reviewer wAnTeD tO hElP tHe Op LeArN |
| 17:14 |
rubenwardy |
just one person concept approving an issue or PR is a little tricky, because someone else may dislike it |
| 17:20 |
|
_Xenon joined #minetest-hub |
| 17:21 |
|
Gael-de-Sailly joined #minetest-hub |
| 17:22 |
Fixer |
nice, sofar made very useful licensing topic |
| 17:30 |
|
tumeninodes joined #minetest-hub |
| 17:31 |
Shara |
I'd suggest two concept approvals. |
| 17:32 |
Shara |
In theory every other dev but those two could then hate it and it gets blocked, but I think once you have two it's fairly likely it's going to be safe if it can hit the technical requirements |
| 17:32 |
rubenwardy |
this adds quite a lot of overhead |
| 17:32 |
Shara |
Since two current approvals can get to a merge anyway, technically we do merge on two concept approvals as it is |
| 17:32 |
Shara |
Yea, but I think it wouldn't be needed for everything |
| 17:32 |
tumeninodes |
just for the sake of saving valuable dev time, I suggest all my concepts just be automatically approved |
| 17:32 |
Shara |
It would be non-vital, and the final two approvals alone could still stand |
| 17:33 |
rubenwardy |
looool |
| 17:33 |
Shara |
But for larger tasks that people only want to engage with if they know it's a wanted feature, it could make a difference |
| 17:33 |
rubenwardy |
well, for issues bugs should be exempt |
| 17:33 |
Shara |
Yes, bug fixes and trivial changes, and anything small would be fine |
| 17:34 |
Shara |
And it's not like it means someone needs approval before they start working on it, just that if they do try and get that first, there is obviously a greater degree of certainty and commitment for them |
| 17:35 |
rubenwardy |
in terms of implementation: MinetestBot maintains a label called "Concept approval needed". To approve an issues (inc: PRs) two core devs need to do :+1: on the reactions |
| 17:35 |
Shara |
The way I see it working would really just be formalising what people can already do if they think (just talk to some devs and ask if they support it) |
| 17:36 |
Shara |
But by making an actual process for it, maybe people will be more likely to check before starting large tasks (large in this case meaning anything that is enough work they'd be annoyed at it not getting merged) |
| 17:37 |
Shara |
I'd be cautious of putting a label on everything to say concept approval is needed, because it wouldn't actually be 'needed'. |
| 17:37 |
Shara |
It would be mroe something that can be requested and something devs might choose to give for issues they know contributors might want some reassurance on before beginning |
| 17:37 |
Shara |
more* |
| 17:38 |
rubenwardy |
well, it should probably only apply to new issues |
| 17:38 |
rubenwardy |
and PRs |
| 17:38 |
Shara |
But make it any kind of hard requirement and some people might decide it's too much fuss an dbother to even try |
| 17:39 |
Shara |
I'm sure there are a lot of existing issues that could use it |
| 17:39 |
rubenwardy |
well, I think that it's too much to ask all PRs to make an issue first |
| 17:39 |
Shara |
Same |
| 17:39 |
Shara |
And that would generate more and pointless issues |
| 17:40 |
Shara |
As an example, if I see a one line change that's needed or decide to fix some typos, I am just going to go ahead and make a PR. |
| 17:40 |
Shara |
But if I want to implement a new feature that will take me some hours of work... I should still be able to just make a PR if I want to chance my luck as usual, or if I feel confident enough it's wanted. |
| 17:41 |
Shara |
But I should also be able to request concept approval in advance if I am uncertain and want to be sure I'm not just wasting my time |
| 17:41 |
Shara |
So then I could open an issue specifically saying I want a concept approval |
| 17:45 |
|
longerstaff13 joined #minetest-hub |
| 17:45 |
|
longerstaff13 joined #minetest-hub |
| 17:48 |
tumeninodes |
speaking of an issue... how can one go about adding backface culling to 3 individual textures, used for one node? I just cant seem to get it set up right |
| 17:50 |
tumeninodes |
if I have {"some_texture.png", "some_texture.png", "some_texture.png"}, and want to apply bfc to all three...? |
| 18:05 |
|
Krock joined #minetest-hub |
| 18:07 |
Krock |
hello :) |
| 18:14 |
tumeninodes |
hola |
| 18:16 |
Jordach |
Krock, not gonna lie, these people are idiots with a text editor |
| 18:16 |
Jordach |
why do you want lag values at start up anyway :thinkingL: |
| 18:16 |
tumeninodes |
oh, nvm, backface culling cannot be used with use texture alpha... dang |
| 18:17 |
tumeninodes |
plan J |
| 18:18 |
tumeninodes |
https://www.gamasutra.com/view/feature/3366/a_compact_method_for_backface_.php?print=1 |
| 18:22 |
tumeninodes |
heh, an article from 1999 |
| 18:45 |
Fixer |
it loaded so fast |
| 18:55 |
Fixer |
wonderful linuxgaming2 is still at 0.4.14 |
| 19:01 |
Jordach |
lmao i found a bug while fixing sky.cpp |
| 19:01 |
Jordach |
so apparently, the night sky colours were never applied to the sky |
| 19:01 |
Jordach |
because apparently the if statement for sky colour needs < 0.07 |
| 19:03 |
Jordach |
and at full night time, that value is 0.073155 for some stupid reason |
| 19:03 |
Jordach |
which means, no execution |
| 19:08 |
Jordach |
the sky actually has the wrong set of colours |
| 19:08 |
Jordach |
https://i.imgur.com/D6MxKTu.png this is what it's meant to look like, if the statement worked as advertised |
| 19:08 |
Jordach |
it's blue, not very dark grey with a white tint at the bottom |
| 19:11 |
tumeninodes |
nice Jordach |
| 19:12 |
Fixer |
Jordach: https://i.imgflip.com/3qlsp.jpg |
| 19:12 |
Jordach |
there's been a silent bug in the sky logic for years and i've just noticed it |
| 19:12 |
tumeninodes |
in other news https://pngquant.org/ just in case anyone else is interested in such tools |
| 19:12 |
Jordach |
i usually debug things by setting them to full white or R, G, B |
| 19:12 |
Jordach |
>lossy compression of PNG |
| 19:13 |
Jordach |
>PNG >lossy |
| 19:13 |
tumeninodes |
definitely looking forward to nicer skies |
| 19:13 |
Jordach |
turns out the classic sky was actually missing the midnight blue |
| 19:14 |
Jordach |
i wondered why it looked off |
| 19:14 |
tumeninodes |
yes... an alternate to indexing |
| 19:14 |
tumeninodes |
poke around some more after... cuz losta things look... off :D |
| 19:16 |
Jordach |
LMAO WHO LET THAT PATCH IN |
| 19:16 |
Jordach |
apparently, even when it's not dawn or sunset |
| 19:16 |
Jordach |
the damn directional fog is still running |
| 19:16 |
Jordach |
it's comment even states it should only run during dawn and sunset |
| 19:17 |
tumeninodes |
hmmmm, a slight performance nudge if that is corrected? |
| 19:17 |
Jordach |
likely, it's not recalculating colours all the time |
| 19:18 |
Jordach |
(after the patch) |
| 19:19 |
tumeninodes |
.33333333 of 0.000001 fps increase |
| 19:19 |
Jordach |
problem is, it looks a bit wrong when it suddleny kicks in |
| 19:20 |
tumeninodes |
porb why it was just left running |
| 19:20 |
tumeninodes |
*prob |
| 19:20 |
tumeninodes |
sometimes 'wrong' just look better |
| 19:21 |
Jordach |
it might be wrong |
| 19:21 |
Jordach |
but, with it active, it looks fine |
| 19:21 |
Jordach |
so perhaps there was clarity inside it's madness |
| 19:21 |
tumeninodes |
;) |
| 19:22 |
tumeninodes |
well, there goes our perf boost :P |
| 19:23 |
Jordach |
probably had a 1-2uS shaving |
| 19:25 |
tumeninodes |
when you're done with this, you can always go and add animation defs to the moon, which we can use to do lunar cycles :) |
| 19:26 |
Jordach |
don't need that |
| 19:26 |
Jordach |
just replace the soddin texture |
| 19:27 |
Jordach |
;) |
| 19:27 |
tumeninodes |
rar |
| 19:28 |
tumeninodes |
bring me the moon |
| 20:40 |
|
IhrFussel joined #minetest-hub |
| 20:41 |
IhrFussel |
"No address associated with host server" when trying to connect to a certain server... client or server problem? |
| 20:43 |
luk3yx |
It sounds like a DNS problem, you should check the IP then try running 'host servers.dns' in a terminal. |
| 20:53 |
IhrFussel |
I'm trying to help a player who can't connect to their favorite server cause of it...but I'm not sure if I can help them...they say they use linux but don't know which one...and they cannot manage to open a terminal window |
| 20:56 |
rubenwardy |
anyone good with bash? |
| 20:57 |
rubenwardy |
wondering why line 13 prints lines of $1.exp when it passes: https://gist.github.com/rubenwardy/6d6c88b7a11da90894df45df670b7a34 |
| 20:58 |
sfan5 |
bash has no closures |
| 20:58 |
sfan5 |
wait |
| 20:58 |
sfan5 |
that wasn't the question |
| 20:58 |
sfan5 |
rubenwardy: grep prints what it matches |
| 20:58 |
rubenwardy |
ahh |
| 20:59 |
rubenwardy |
lol |
| 20:59 |
sfan5 |
pass -q to it |
| 20:59 |
rubenwardy |
that worked. Thanks! |
| 20:59 |
sfan5 |
also you should use {} instead of () which is a subshell |
| 20:59 |
sfan5 |
when doing that note that bash requires a trailing ; inside {} |
| 21:09 |
|
Ruslan1 joined #minetest-hub |
| 21:23 |
|
garywhite joined #minetest-hub |
| 22:11 |
|
Gael-de-Sailly joined #minetest-hub |
| 22:52 |
|
FrostRanger joined #minetest-hub |
| 23:33 |
|
paramat joined #minetest-hub |
| 23:34 |
paramat |
Fixer lol i actually disagree with DELTA_FORCE's posts =) |
