Minetest logo

IRC log for #minetest-hub, 2018-11-12

| Channels | #minetest-hub index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:14 GreenDimond joined #minetest-hub
00:19 NathanS21 joined #minetest-hub
01:13 redneonglow joined #minetest-hub
01:37 Jordach joined #minetest-hub
01:57 ANAND joined #minetest-hub
03:10 garywhite joined #minetest-hub
03:25 loggingbot_ joined #minetest-hub
03:25 Topic for #minetest-hub is now Offtopic welcome if brief, otherwise use #minetest-chat | Info/Rules: http://hub.minetest.net/ | Logs: http://irc.minetest.net/minetest-hub/
04:21 Ruslan1 joined #minetest-hub
07:54 longerstaff13 joined #minetest-hub
07:54 longerstaff13 joined #minetest-hub
08:22 FrostRanger joined #minetest-hub
08:50 atorian37 joined #minetest-hub
09:08 atorian37 joined #minetest-hub
09:46 atorian37 joined #minetest-hub
10:03 FrostRanger joined #minetest-hub
10:06 atorian37 joined #minetest-hub
10:35 Fixer joined #minetest-hub
10:59 atorian37 joined #minetest-hub
11:54 Jordach joined #minetest-hub
12:21 Jordach_ joined #minetest-hub
12:23 T4im joined #minetest-hub
12:27 FrostRanger joined #minetest-hub
12:33 Gael-de-Sailly joined #minetest-hub
13:08 Jordach >someone authed as me
13:08 Jordach >it's the macbook waking from sleep
13:18 calcul0n joined #minetest-hub
13:46 aerozoic joined #minetest-hub
13:47 Jordach_ joined #minetest-hub
13:52 calcul0n joined #minetest-hub
14:37 rubenwardy !seen tenplus1
14:37 MinetestBot rubenwardy: tenplus1 was last seen at 2018-11-03 17:09:20 UTC on #minetest-hub
14:39 Jordach rubenwardy, looks like we left him behind at #live D:
14:57 Jordach_ joined #minetest-hub
14:59 Jordach_ joined #minetest-hub
15:35 Jordach apparently mousewheeling in Konversation renames me
15:40 rubenwardy you probably have the nick changer focused
15:44 Ruslan1 joined #minetest-hub
16:09 ANAND joined #minetest-hub
16:10 Fixer Jordach: to update windows 10
16:27 greeter joined #minetest-hub
16:43 Fixer found paramat's alt https://forum.minetest.net/viewtopic.php?f=15&t=9724&view=unread#p334612
16:44 rubenwardy u wot
16:57 * Fixer runs away just for sure
17:12 rubenwardy so, discussion point:
17:12 rubenwardy how should concept approvals work?
17:12 rubenwardy a few times recently, PRs have been reviewed and such and then rejected even by the reviewer for conceptal reasons
17:13 rubenwardy because the reviewer wAnTeD tO hElP tHe Op LeArN
17:14 rubenwardy just one person concept approving an issue or PR is a little tricky, because someone else may dislike it
17:20 _Xenon joined #minetest-hub
17:21 Gael-de-Sailly joined #minetest-hub
17:22 Fixer nice, sofar made very useful licensing topic
17:30 tumeninodes joined #minetest-hub
17:31 Shara I'd suggest two concept approvals.
17:32 Shara In theory every other dev but those two could then hate it and it gets blocked, but I think once you have two it's fairly likely it's going to be safe if it can hit the technical requirements
17:32 rubenwardy this adds quite a lot of overhead
17:32 Shara Since two current approvals can get to a merge anyway, technically we do merge on two concept approvals as it is
17:32 Shara Yea, but I think it wouldn't be needed for everything
17:32 tumeninodes just for the sake of saving valuable dev time, I suggest all my concepts just be automatically approved
17:32 Shara It would be non-vital, and the final two approvals alone could still stand
17:33 rubenwardy looool
17:33 Shara But for larger tasks that people only want to engage with if they know it's a wanted feature, it could make a difference
17:33 rubenwardy well, for issues bugs should be exempt
17:33 Shara Yes, bug fixes and trivial changes, and anything small would be fine
17:34 Shara And it's not like it means someone needs approval before they start working on it, just that if they do try and get that first, there is obviously a greater degree of certainty and commitment for them
17:35 rubenwardy in terms of implementation: MinetestBot maintains a label called "Concept approval needed". To approve an issues (inc: PRs) two core devs need to do :+1: on the reactions
17:35 Shara The way I see it working would really just be formalising what people can already do if they think (just talk to some devs and ask if they support it)
17:36 Shara But by making an actual process for it, maybe people will be more likely to check before starting large tasks (large in this case meaning anything that is enough work they'd be annoyed at it not getting merged)
17:37 Shara I'd be cautious of putting a label on everything to say concept approval is needed, because it wouldn't actually be 'needed'.
17:37 Shara It would be mroe something that can be requested and something devs might choose to give for issues they know contributors might want some reassurance on before beginning
17:37 Shara more*
17:38 rubenwardy well, it should probably only apply to new issues
17:38 rubenwardy and PRs
17:38 Shara But make it any kind of hard requirement and some people might decide it's too much fuss an dbother to even try
17:39 Shara I'm sure there are a lot of existing issues that could use it
17:39 rubenwardy well, I think that it's too much to ask all PRs to make an issue first
17:39 Shara Same
17:39 Shara And that would generate more and pointless issues
17:40 Shara As an example, if I see a one line change that's needed or decide to fix some typos, I am just going to go ahead and make a PR.
17:40 Shara But if I want to implement a new feature that will take me some hours of work... I should still be able to just make a PR if I want to chance my luck as usual, or if I feel confident enough it's wanted.
17:41 Shara But I should also be able to request concept approval in advance if I am uncertain and want to be sure I'm not just wasting my time
17:41 Shara So then I could open an issue specifically saying I want a concept approval
17:45 longerstaff13 joined #minetest-hub
17:45 longerstaff13 joined #minetest-hub
17:48 tumeninodes speaking of an issue... how can one go about adding backface culling to 3 individual textures, used for one node? I just cant seem to get it set up right
17:50 tumeninodes if I have {"some_texture.png", "some_texture.png", "some_texture.png"}, and want to apply bfc to all three...?

| Channels | #minetest-hub index | Today | | Google Search | Plaintext