Time Nick Message 00:01 ChimneySwift you need to register it in a mod named "water_feature" or have a leading ":" 00:03 tumeninodes I should just put it up on github but, didn't seem sensible without any additional code or features. 00:03 rubenwardy don't use a leading : 00:03 rubenwardy !book items 00:03 MinetestBot rubenwardy: Nodes, Items, and Crafting - https://rubenwardy.com/minetest_modding_book//en/items/nodes_items_crafting.html 00:03 rubenwardy explains item names there 00:03 rubenwardy the mod name needs to be the same as the prefix of a registered thing 00:03 rubenwardy so the modname should be modname:itemname 00:04 ChimneySwift also don't register additional nodes in builtin 00:05 rubenwardy he's not, ChimneySwift 00:05 rubenwardy that's just where the engine checks the item name 00:08 TommyTreasure trying now, as a separate mod 00:09 ChimneySwift ah 00:16 TommyTreasure with my lack of lua knowledge, i think i'll wait for the git repo :) or.... just play with it on my local machine for a while 00:31 tumeninodes pparamatL is WA listed in the API? what line number? 00:34 paramat https://github.com/minetest/minetest/blob/dc948382f57c34a7da358bba85c04513877fe2c3/doc/lua_api.txt#L5656 00:34 tumeninodes thank you 00:35 paramat a tile string can be replaced with that table 00:36 paramat ugh there's an option for clientside setting of WA 00:36 paramat server should decide orientation of textures 00:37 paramat always 00:37 * paramat is the enemy of the client ;] 00:38 tumeninodes haha 00:40 paramat oh but then, client can use texture packs .. but still, will see why this was done 00:47 tumeninodes TommyTreasure: https://github.com/TumeniNodes/water_feature 00:48 tumeninodes so, I should be able to just add the world_align = false after the side texture 00:50 tumeninodes and ah ha... the only way the client can set the rotation is if we use "world_align - user" 01:02 paramat i missed this clientside stuff in the PR, can't see any good reason for it yet 01:02 tumeninodes haha, I'm still trying to figure out how to apply this in the tile def :P 01:03 tumeninodes would be nice to have an example present, as some of the others show 01:04 tumeninodes afk quickly, I forgot to eat today brb 01:05 paramat apparently a client can force-apply WA to nodes on servers that do not specify it, uneasy about this https://github.com/minetest/minetest/blob/dc948382f57c34a7da358bba85c04513877fe2c3/builtin/settingtypes.txt#L728 01:05 Shara I'm uneasy about WA in every sense. 01:05 Shara It never should have been merged and I stand by that. 01:05 paramat or at the least, seems not worth doing. and why would a server want to let a client decide WA or not for a node? 01:06 Shara Quite honestly? Clients are allowed to have texture packs, so why not let them decide this? 01:06 BakerPrime What is WA? 01:06 Shara Either way, should not have been merged as it has been and should be reverted 01:07 Shara BakerPrime: forces all textures to allign a specific way regardless of node rotation. 01:07 paramat "Note though that that is considered EXPERIMENTAL and may not work properly." 01:08 BakerPrime Ah. I see. 01:08 Shara paramat: I'm really not happy with the idea of duplicating nodes just for this 01:08 Shara Not in MTG 01:09 paramat global textures are not in stable yet, so there's a chance to reconsider the clientside stuff 01:09 Shara If this is such a big deal, people can just make a mod so they can have nicely lined up upside down stairs. 01:10 Shara paramat: either way, that commit should be reverted 01:10 paramat yeah, i mean, because a texture pack can do this, why bother duplicating the ability? 01:10 Shara I consider this the worst thing I have come across in MTG since I joined the dev team 01:11 Shara And the more I think about it, the less happy I am with anything other than reverting it. 01:12 paramat Shara what's the problem you see with the engine feature if it's optional per-node? the mistake in MTG was forcing it for all stairs, i agree, but that's different 01:12 Shara Engine feature is fine. The use of it in MTG is not fine. 01:13 paramat ah ok 01:14 paramat i was talking about the engine feature clientside stuff 01:14 Shara I don't mind what happens there, but I want it gone from MTG for any node that is rotable when in full node form. 01:16 paramat ok if we don't duplicate nodes in stairs, do you still want to have non-rotatable-parent stair nodes WA? a revert would undo that 01:16 rubenwardy WA means that the textures line up right? 01:16 paramat sorry, you answered already 01:17 Shara I really feel adding duplicates of those nodes in MTG is a bad move, and I've only been considering it because I worried this would get brushed aside if I don't. But I realised that's not okay. 01:17 rubenwardy and non-WA textures are needed forpatterns? 01:17 Shara Yes, but the WA nodes disrupt texture allignments on normal stairs as well 01:18 Shara The choices are stairs will look a little funny when roated to be upsidedown (current stable), or they'll look funny in normal use, or we duplicate nodes. 01:19 Shara I agree I'd love to fix the current upside-down issue, but neither of the alternatives are better 01:19 paramat yeah whether to duplicate is the big decision to make, i don't feel strongly on this, but possibly slightly prefer duplication 01:20 Shara So those nodes should be made non-WA again. After that, if you want to try and add duplicates, okay, but let that come after fixing these please. 01:22 paramat sounds good, because i'm still really unsure about duplication 01:22 paramat so will do that for my PR 01:23 Shara Okay. Duplication feels unnecessary to me, because it would be simple to add a mod that does that. (If people complain at me for spoiling this for them, I'll even make the mod) 01:23 Shara (simple so long as you can set WA or not WA when registering stairs) 01:25 TommyTreasure tumeninodes, i got it to work. had to comment out the 'sounds' line, and added a craft recipe 01:25 paramat actually my PR already does this. but it does it by adding a field to make it choosable, which seems essential to give modders the choice independent of whether the parent node is rotatable 01:25 Shara Yes, choice is good :) 01:26 paramat ok PR seems ready then 01:27 tumeninodes I have enjoyed WA only because I am lazy, and if I am placing say, wooden slabs for a floor, It is easier than having to move all over so you are placing the node in the proper direction to align with the rest. 01:28 tumeninodes and the way it makes using stairs for arches etc. blend so nicely. 01:28 tumeninodes In all honesty, that could just be done as a mode 01:29 Shara That's what I'm thinking. Done as a mod it becomes a nice little mod that people who are careful with their builds will gain something from, and no one loses anything 01:30 tumeninodes I'm on board with that 01:31 tumeninodes TommyTreasure: glad to hear it 01:37 paramat PR is not quite ready actually 01:38 Shara Just looking over it now. What's missing? 01:39 paramat see last comment 01:39 Shara Heh, thought that might be what you were looking at 01:40 paramat if 'worldaligntex' is not set, it will be 'nil' which will act as 'false', i think .. 01:41 Shara Yea 01:41 Shara It will count as false 01:45 Shara Anyway, looks fine to me. I can do a more in depth check tomorrow. 01:46 Shara Sleep calls - good night all. 01:46 rubenwardy o/ 01:47 tumeninodes don't let the bed bugs bite 01:47 * Shara hands them all over to tumeninodes 01:47 Shara You mind them then :) 01:47 tumeninodes Stop, citizen 01:47 Shara Too slow! 01:47 * Shara legs it 01:47 Shara Night :) 01:48 tumeninodes night 01:48 tumeninodes I ain't feedin these things 01:49 tumeninodes should make NumberZero make the WA mod, it was their great idea XD 02:18 * tumeninodes is off to bed, has other PRs to work on tomorrow 16:53 IcyDiamond rdococ: just do it ™ 16:54 rdococ how tho? should I use the inventory system? or have actual ingame blocks? 17:56 rubenwardy Krock: you put .co.uk in the topic, which doesn't seem to be registered 17:56 rubenwardy https://forum.minetest.net/viewtopic.php?p=154573#p154573 17:56 rubenwardy later posts say uk.to 17:57 Krock ooops I'm too british 17:57 Krock thanks for pointing it out 17:58 Krock also had to fix some porting issues in the searching code. uh <<< this guy did a bad job testing it first 17:59 Krock actually no. This was clearly on purpose to see whether people actually read it 18:00 Krock ;) 19:53 jas_ hi 20:16 IcyDiamond o/