Time  Nick       Message
10:41 sfan5      merging #14555, #14534 in 10m
10:41 ShadowBot  https://github.com/minetest/minetest/issues/14555 -- Fix inconsistent rounding in VoxelLineIterator::VoxelLineIterator by Desour
10:41 ShadowBot  https://github.com/minetest/minetest/issues/14534 -- [no sq] Profiler improvement + an optimization by sfan5
11:32 sfan5      huh looks like my changes actually broke something
11:42 sfan5      http://sprunge.us/NjBpe2?diff pushing in 15m or so
11:47 pgimeno    ugh, that RE looks bad, it would miss @@@ for one
11:48 sfan5      there's an open bug for that
11:52 pgimeno    I think something like r'(?<!@)(?:@@)*@(?:[^@1-9n]|$)' could work
11:54 pgimeno    that's the whole expression, it covers ^@$ and [^@]@$ already
12:01 pgimeno    I'm unsure about whether @$ should be rejected though, isn't that used for line continuation?
12:07 pgimeno    ah I see, #14414
12:07 ShadowBot  https://github.com/minetest/minetest/issues/14414 -- mod_translation_updater.py: Parses escape codes in .tr files incorrectly
12:28 MTDiscord  <josiah_wi> Thank you for your feedback a while ago on #13609 sfan. I'd like your input on an idea: Catch2 has a feature to filter tests with a RegEx, and that can be set in run_tests to filter on a module name. It will be more permissive than findTestModule since anything matching the RegEx goes, and I would add something to the README to mention that.
12:28 ShadowBot  https://github.com/minetest/minetest/issues/13609 -- Upgrade client active object mgr tests to Catch2 by JosiahWI
12:30 MTDiscord  <josiah_wi> Unrelated, I had some kind of spurious Lua error in the main menu after rebasing on latest master, but I thought it was because I passed --test-module none so I didn't save the error message. I think now it's unrelated to my command line options.
12:33 sfan5      sounds useful if we're goingto use catch2 more widely
12:33 sfan5      pushing http://sprunge.us/1Crr15?diff in 15m or more
12:37 MTDiscord  <josiah_wi> Correction, that's a CTest feature. Catch2's argument is just wildcards and tags.
12:42 MTDiscord  <josiah_wi> It works locally now. How should I handle the decision to invoke Catch::Session::run vs the homecooked module system? The code in master decides that if findTestModule fails, then an error message is printed and -1 is returned as the exit code.
13:34 sfan5      apparently log events from irrlicht haven't been passing through to MT correctly for 7 years?!
13:36 MTDiscord  <jordan4ibanez> Sounds about right
13:50 MTDiscord  <josiah_wi> I am ready for #13609 to be reopened.
13:50 ShadowBot  https://github.com/minetest/minetest/issues/13609 -- Upgrade client active object mgr tests to Catch2 by JosiahWI
13:51 MTDiscord  <josiah_wi> sfan5, I pushed what I have so you can take a look when you have time.
14:25 [MTMatrix] <grorp> sfan5: just in the isMenuActive() case or in other cases as well?
14:48 sfan5      just in that case
14:50 MTDiscord  <josiah_wi> There are 4 failing unit tests in master on MSVC.
15:03 sfan5      yes, feel free to work on a fix
15:04 sfan5      (these appeared when I made the MSVC CI build also run unittests, nobody knows how long they've been there)
15:54 MTDiscord  <luatic> merging #14567 in 5m
15:54 ShadowBot  https://github.com/minetest/minetest/issues/14567 -- Remove <ctgmath> include from particles.h by JosiahWI
16:38 MTDiscord  <josiah_wi> sfan5, util/container.h line 372 is returning a dangling reference because the ternary operator causes a temporary copy. I will open an issue for it soon; I'm going to try to confirm it with asan. I'm letting you know because your name is on the git blame for that class.
16:39 MTDiscord  <josiah_wi> Soon will be in an hour or two maybe.
18:21 Krock      will merge #14564 and #14558 in 15 minutes
18:21 ShadowBot  https://github.com/minetest/minetest/issues/14564 -- Do not link /latomic on MSVC by JosiahWI
18:21 ShadowBot  https://github.com/minetest/minetest/issues/14558 -- HUD: Text element color support by SmallJoker
18:36 Krock      merging
18:37 Krock      done
22:02 MTDiscord  <josiah_wi> I filed an issue for the MSVC warning: #14569.
22:02 ShadowBot  https://github.com/minetest/minetest/issues/14569 -- Possible dangling reference in ModifySafeMap::get
22:04 MTDiscord  <josiah_wi> This might be the first time I've seen "Unconfirmed Bug" correctly mean unconfirmed.