Time  Nick       Message
08:18 nerzhul    Krock did you get time for my simple MR ?
18:05 Krock      nerzhul: will test soon
18:05 nerzhul    ty
18:53 nerzhul    Krock if i fix style i can merge ? :)
18:53 Krock      yes
21:26 kilbith    rubenwardy: this commit has wrong author: https://github.com/minetest/minetest/commit/08ee9794f
21:27 kilbith    code's been borrowed from https://github.com/minetest/minetest/pull/9569
21:27 rubenwardy I didn't merge that
21:27 rubenwardy I imagine it says m yname because I made suggestions
21:27 kilbith    ah
21:27 kilbith    Krock ^
21:28 rubenwardy you need to be careful with GitHub squashes when you have borrowed code, because it puts the PR author not the commit author as the sqiashed commit author
21:28 rubenwardy sigh that was a long sentence
21:29 kilbith    (I can't stand that runs is in the git log for real)
21:29 Krock      oops
21:30 kilbith    Krock: can you change that?
21:30 Krock      I could but it's too late
21:31 kilbith    rubenwardy, mind you to exclude him from the credits when it's time
21:31 rubenwardy yeah
21:31 MTDiscord  <K​not Abbot> lol
21:32 sfan5      small contributions won't make it to the credits menu if you mean that
21:32 sfan5      and for the changelog it'd make sense to list it with the correct authorship, yes
21:32 rubenwardy Yeah, exactly