| Time |
Nick |
Message |
| 00:17 |
|
Taoki_1 joined #minetest-dev |
| 00:25 |
|
Taoki joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:35 |
|
Fixer joined #minetest-dev |
| 08:36 |
|
calcul0n joined #minetest-dev |
| 08:58 |
|
mizux joined #minetest-dev |
| 09:22 |
|
calcul0n_ joined #minetest-dev |
| 09:30 |
|
Taoki joined #minetest-dev |
| 09:40 |
|
Beton joined #minetest-dev |
| 09:43 |
|
lisac joined #minetest-dev |
| 10:49 |
|
proller joined #minetest-dev |
| 11:39 |
|
pmp-p joined #minetest-dev |
| 11:46 |
|
pmp-p joined #minetest-dev |
| 13:34 |
|
turtleman joined #minetest-dev |
| 13:36 |
|
absurb joined #minetest-dev |
| 13:52 |
|
MTDiscord5 joined #minetest-dev |
| 14:00 |
|
Taoki joined #minetest-dev |
| 15:32 |
|
Taoki joined #minetest-dev |
| 15:48 |
|
NetherEran joined #minetest-dev |
| 16:13 |
|
Flitzpiepe joined #minetest-dev |
| 16:13 |
|
Seirdy joined #minetest-dev |
| 16:42 |
zughy[m] |
rubenwardy: is there any reason this comes before the sao check? I'm asking as every other function check variables after having checked for the entity https://github.com/minetest/minetest/commit/3250b37e32f264db04c1ca449d9feefc22fd38b7#diff-5cdd53776d4918652568f88b8e6a83b016edfffb0029a53e30cd3095f9e14f96R866 |
| 16:42 |
sfan5 |
there is most likely not |
| 16:42 |
sfan5 |
at least I can't think of one |
| 16:42 |
rubenwardy |
It's used by all the branches |
| 16:46 |
zughy[m] |
I've just edited about 700 lines of code and that's the first I've encountered |
| 16:47 |
rubenwardy |
That variable is used by both the two branches, so is above them. It could be below the object get and null check, but it doesn't matter |
| 16:51 |
rubenwardy |
The object get and type checks are next to each other as they're both acting on the same variable, but again it doesn't matter |
| 16:58 |
rubenwardy |
In my game, the Lua API functions are very small - they translate types to cpp, call a function, then translate back to Lua. I quite like having this 3-part way of doing it, plus having that actual functionality separated from Lua |
| 16:58 |
zughy[m] |
"but it doesn't matter": BOI. I'm MarieKondoing that class |
| 16:59 |
zughy[m] |
also, totally unrelated: if you're fine with your edits in the nametag background, it's an easy merge |
| 17:32 |
|
fluxflux joined #minetest-dev |
| 17:51 |
|
homthack joined #minetest-dev |
| 19:46 |
zughy[m] |
sfan5: should I keep this function? It's been there for 8 years, no trace in the lua_api, never called from anywhere. I saw the comment is yours https://github.com/minetest/minetest/blob/master/src/script/lua_api/l_object.cpp#L1104 |
| 19:49 |
sfan5 |
what do you mean "never called from anywhere"? it's exported to lua so could be called from anywhere |
| 19:51 |
pgimeno |
it's not in lua_api.txt |
| 19:51 |
Krock |
perhaps not any more |
| 19:51 |
pgimeno |
"// This method was once added for a bugfix, but never documented" |
| 19:52 |
Krock |
doesn't mean that someone else documented it later on anyway |
| 19:52 |
Krock |
but it looks like that comment still tells the truth |
| 19:52 |
Krock |
removing it should be okay because modders should rtfm |
| 19:53 |
Krock |
i.e. that undocumented functions may be changed or removed at any time |
| 19:54 |
rubenwardy |
if it was never documented then it can be removed |
| 19:55 |
sfan5 |
the log_deprecated has been in since 5.2 so removing it should be fine |
| 20:21 |
|
DS-minetest joined #minetest-dev |
| 21:09 |
MTDiscord |
<Lone_Wolf> Does running player:punch(hitter, nil, {damage_groups = {fleshy = 1}}) inside of minetest.register_on_punchplayer crash without an error for anyone else? |
| 21:11 |
DS-minetest |
crash without error == grey screen? |
| 21:11 |
DS-minetest |
i can imagine that it ends up in a infinite loop |
| 21:13 |
MTDiscord |
<Lone_Wolf> No grey screen |
| 21:13 |
MTDiscord |
<Lone_Wolf> Might be a segfault but I just can't see it on Windows |
| 21:13 |
MTDiscord |
<Lone_Wolf> The hosting client just shuts down when a player punches another player |
| 21:14 |
MTDiscord |
<Lone_Wolf> When I hosted the server with --server it just stopped and didn't log anything to chat |
| 21:18 |
MTDiscord |
<Lone_Wolf> Oh hmm, I wonder if that does start a loop |
| 21:19 |
MTDiscord |
<Lone_Wolf> Would make sense if it did ? |
| 21:30 |
MTDiscord |
<Lone_Wolf> Yep, that was the issue |
| 21:43 |
DS-minetest |
radius 120, minetest.find_node_near: 330 ms; same thing implemented in lua with get_node replaced with ffi version: 440 ms |
| 21:44 |
DS-minetest |
with normal get_node: ca. 6400 ms |
| 22:37 |
|
homthack joined #minetest-dev |
| 22:42 |
|
homthack51 joined #minetest-dev |
| 22:46 |
|
homthack joined #minetest-dev |
| 23:36 |
|
homthack joined #minetest-dev |
