Minetest logo

IRC log for #minetest-dev, 2020-10-06

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
03:29 ircSparky joined #minetest-dev
04:21 Kimapr[m] joined #minetest-dev
04:55 YuGiOhJCJ joined #minetest-dev
06:05 ShadowNinja joined #minetest-dev
06:06 anon5[m]1 joined #minetest-dev
06:09 ircSparky joined #minetest-dev
06:22 basxto joined #minetest-dev
08:00 ShadowNinja joined #minetest-dev
08:22 NetherEran joined #minetest-dev
08:57 calcul0n joined #minetest-dev
09:43 NetherEran joined #minetest-dev
09:57 Fixer joined #minetest-dev
10:30 nore I think #10451 is ready for testing for those who want, the only missing part of it is tooling for the extraction of strings
10:30 ShadowBot https://github.com/minetest/minetest/issues/10451 -- Client-side translations: gettext support by Ekdohibs
10:34 anon5[m]1 joined #minetest-dev
11:00 rubenwardy Nice!
11:00 rubenwardy Merging #10460 in 10
11:00 ShadowBot https://github.com/minetest/minetest/issues/10460 -- Prevent games from setting secure settings by rubenwardy
11:45 turtleman joined #minetest-dev
11:58 bootlegbilly joined #minetest-dev
12:00 Wuzzy joined #minetest-dev
12:56 jas_ joined #minetest-dev
13:09 rubenwardy Do any core developers have MacOS on mac hardware?
13:51 calcul0n_ joined #minetest-dev
15:38 fluxflux joined #minetest-dev
15:59 proller joined #minetest-dev
16:00 turtleman joined #minetest-dev
16:03 MTDiscord <a​ppguru> Might want to revert #10405, it seems to be breaking playeranim & character_anim.
16:03 ShadowBot https://github.com/minetest/minetest/issues/10405 -- Fix short 180 degree rotation when using set_bone_position by appgurueu
16:07 MTDiscord <a​ppguru> It only fixes quite an edge case (setting the bone position of a parent bone but not of it's child bones) anyways and would break fairly popular mods
16:07 MTDiscord <L​one_Wolf> Not something that can be fixed mod-side?
16:07 MTDiscord <a​ppguru> I don't think so
16:15 sfan5 mind opening a PR for that?
17:30 homthack joined #minetest-dev
18:00 NetherEran joined #minetest-dev
18:34 Krock will merge #5680 and #10279 in 15 minutes
18:34 ShadowBot https://github.com/minetest/minetest/issues/5680 -- Add minetest.get_artificial_light and minetest.get_natural_light by HybridDog
18:34 ShadowBot https://github.com/minetest/minetest/issues/10279 -- Improve the `fsaa` setting description by Calinou
18:34 sfan5 ah ninja'd
18:34 sfan5 I was just looking for PRs I could merge
18:34 Krock :3
18:34 sfan5 you can merge #10453 too
18:34 ShadowBot https://github.com/minetest/minetest/issues/10453 -- -Wclass-memaccess only called when GCC > 7 by Zughy
18:35 Krock alright!
18:48 Krock merging
18:51 Krock done.   also what's the deal with #10464? This does not improve anything
18:51 ShadowBot https://github.com/minetest/minetest/issues/10464 -- Pass ContentFeatures as reference to read_content_features. by JosiahWI
18:52 Krock it even weakens the control of the ContentFeatures contents
18:53 Krock and the compiler would likely just re-use the return value without copying - if it's smart enough
19:15 Seirdy joined #minetest-dev
19:30 MTDiscord <j​osiah_wi> It's a minor thing, but making small changes like this will help me get more familiar with the engine code, and if I'm doing these improvements I might as well make a PR.
19:36 Krock I can see your point. It's a way to get started by trying a few things. Though this function is only called a few times (up to 36000x) on startup, a single return value optimization does not change anything there
19:37 sfan5 might or might not help but I like the change
19:39 Krock ¯\_(ツ)_/¯ well then
19:41 MTDiscord <j​osiah_wi> I understand your point that with optimization turned on this won't change the result of the compilation. This is cleaner code though in my opinion, because it puts the initialization of the resource in the function that deletes it (end of scope in this case) and makes it clearer to someone reading the code.
19:47 MTDiscord <j​osiah_wi> You've got my curiosity peaked now; when I have time I'll try compiling both versions with optimization and see what instructions change if any.
20:04 proller joined #minetest-dev
20:23 fluxflux joined #minetest-dev
20:50 proller joined #minetest-dev
21:24 dennisjenkins joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext