Minetest logo

IRC log for #minetest-dev, 2020-09-19

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
06:23 proller joined #minetest-dev
08:00 ShadowNinja joined #minetest-dev
08:26 calcul0n joined #minetest-dev
10:13 Fixer joined #minetest-dev
12:00 absurb joined #minetest-dev
14:33 NetherEran joined #minetest-dev
16:28 lisac joined #minetest-dev
16:52 indiana joined #minetest-dev
17:00 calcul0n_ joined #minetest-dev
17:33 MTDiscord <L​one_Wolf> ACTION[Main]: Server: Shutting down \n terminate called after throwing an instance of 'std::system_error' \n what():  Invalid argument
17:33 MTDiscord <L​one_Wolf> Client crash after a local world shutdown
17:34 MTDiscord <L​one_Wolf> My client is only a few commits behind if it
17:34 MTDiscord <L​one_Wolf> s behind at all
18:00 Krock backtrace would be helpful
18:27 MTDiscord <L​one_Wolf> https://pastebin.com/8LgXKxAj
18:27 MTDiscord <L​one_Wolf> Happens when I close Minetest
18:29 Krock https://github.com/minetest/minetest/blob/master/src/main.cpp#L228
18:30 Krock but g_settings is never deleted
18:34 homthack joined #minetest-dev
18:53 MTDiscord <L​one_Wolf> Hmmm. I'm getting a freeze with no crash now
18:54 MTDiscord <L​one_Wolf> https://pastebin.com/AkzePQ1M
18:54 MTDiscord <L​one_Wolf> I have two clients running at once btw
18:55 MTDiscord <L​one_Wolf> The other one is just in the main menu though
18:59 MTDiscord <a​ppguru> I was getting freezes & crashes with 5.4-dev too
18:59 MTDiscord <a​ppguru> To be precise: It first freezed and crashed later on
19:15 MTDiscord <L​one_Wolf> ooooh got that other error now too https://pastebin.com/rpenXH0W
19:16 MTDiscord <L​one_Wolf> This is with my client compiled at https://github.com/minetest/minetest/pull/10351 btw
19:17 MTDiscord <L​one_Wolf> Been slowly inching back from latest dev to see where it appears
19:40 MTDiscord <L​one_Wolf> I'm getting close 👀
19:42 sfan5 bisecting is less work btw
19:42 NetherEran joined #minetest-dev
19:45 MTDiscord <L​one_Wolf> Not sure what to look for
19:45 sfan5 huh?
19:45 sfan5 with bisect you pick a commit where it worked and a commit where it didn't and git gets you to the buggy change in the least possible steps
19:51 MTDiscord <L​one_Wolf> Ah
19:51 MTDiscord <L​one_Wolf> Too late though, already found the culprit: https://github.com/minetest/minetest/pull/10318
19:52 MTDiscord <L​one_Wolf> To reproduce join a game then exit to OS
19:52 Krock I don't want to touch that code ever again
19:53 Taoki joined #minetest-dev
19:55 sfan5 I'm guessing m_map_settings keeps references to the global object that ends up being cleared before it
19:57 Krock Settings holds a pointer of the global FlagDesc structs
19:58 Krock and also group defaults of inherited default values
19:59 Krock setGroupDefault  copies the group pointer rather than its value
20:04 Krock yes, that's likely the problem
20:04 Krock double-free of Settings *group inside SettingsEntry,, caused by overrideDefaults
20:12 Krock Lone_Wolf: does this fix your issue? https://krock-works.uk.to/u/patches/settings-crash-attempt1.diff
20:19 MTDiscord <L​one_Wolf> Is there an easy way to apply that which I'm not aware of?
23:38 paramat joined #minetest-dev
23:38 paramat merging game#2740
23:38 ShadowBot https://github.com/minetest/minetest_game/issues/2740 -- Update description to manage expectations by paramat
23:44 paramat #10366 and #10247 are both ready, quick and easy to review, and have a big benefit for mainmenu presentation
23:44 ShadowBot https://github.com/minetest/minetest/issues/10366 -- Improve layout of main menu local tab by paramat
23:44 ShadowBot https://github.com/minetest/minetest/issues/10247 -- Give unnamed world names incremental numbers. Format 'world<number>' by paramat

| Channels | #minetest-dev index | Today | | Google Search | Plaintext