Time Nick Message 13:07 ANAND Does anyone have any idea what the wieldmesh coordinates correspond to? For example, the offset is set to 55,-35 by default 13:10 ANAND Or, any idea where the wieldmesh is queued for rendering? 13:40 Krock camera.cpp 13:44 ANAND Camera::drawWieldedTool? 13:45 ANAND I just arrived there :) 13:45 ANAND I was hoping to find some sort of an explanation as to why those numbers were chosen. 13:45 ANAND They don't seem to correspond to any coordinate system at first glance... 13:46 ANAND I used QuickTune to try out wield_offset. I think I'll use it again to figure out the edges. 13:46 Krock the wieldmesh is a mesh that's drawn in the world like an entity 13:46 Krock only difference is that the z-buffer is cleared so that it's always on top 13:47 ANAND And its transformation is also local to the camera, right? 13:49 ANAND i.e. the VP matrix isn't applied to the wieldmesh 13:53 Krock likely yes 15:19 sfan5 pretty minor, easy to review > #9868 15:19 ShadowBot https://github.com/minetest/minetest/issues/9868 -- [NO SQUASH] Three misc changes by sfan5 15:21 sfan5 #9852 would also be important since leveled nodes aren't very usable right now 15:21 ShadowBot https://github.com/minetest/minetest/issues/9852 -- Rework functionality of leveled nodes by Wuzzy2 15:26 Krock summoned. 15:35 PGimeno sfan5: m_packetcounter_timer --> counter ; is that intentional? (I don't know what either is so just making sure, but it's odd to me that 'counter' is a constant 30.f while m_packetcounter_timer is a member) 15:36 sfan5 counter is a float& that references m_packetcounter_timer 15:36 PGimeno ah sorry, ok 15:36 sfan5 (in that scope, at least) 15:37 PGimeno it will always print '30' then 15:38 sfan5 yep 16:50 rubenwardy #8592 is updated and tested on Android 16:50 ShadowBot https://github.com/minetest/minetest/issues/8592 -- Add core.open_url() to main menu API by rubenwardy 16:50 rubenwardy well, on my single Android device 16:50 sfan5 (my approval still stands) 16:50 rubenwardy cool, I'll merge in 10 then 17:16 sfan5 ... 18:08 rubenwardy a while later... 18:18 Krock it's been three years 18:20 * Krock gives rubenwardy sleep 600; paplay /path/to/notification.ogg 19:19 Zughy hey guys, I really want to help you closing some issues so I'm trying to expand my knowledge from Lua to C++. I've been studying on the lua.org site in these days (for the implementation on C++), do you have any other suggestion? 19:20 Zughy or I should simply dive in the code after that? (I know how C++ works, I just lack the practice) 19:21 rubenwardy I found the best way to learn cpp was to do my own projects alongside Mt 19:22 sfan5 merging #9868 in 5m inutes 19:22 ShadowBot https://github.com/minetest/minetest/issues/9868 -- [NO SQUASH] Three misc changes by sfan5 19:37 Krock just dive in. handy to have C-alike knowledge, though. 20:49 Zughy sfan5, IF you want to merge the on_wield PR, please don't as we're implementing the on_unwield as well in the same PR 20:50 Zughy as we speak 20:50 sfan5 one approval isn't enough to merge it anyway 20:50 sfan5 but please mark your PR as WIP when you intend to change it 20:51 Zughy well, we didn't want to, but then people asked for it 20:51 Zughy and it makes sense to us 20:51 Zughy also because we actually need the on_unwield feature too for our server, I simply didn't think about it the first time. My bad 21:19 Zughy Krock, I was having a look at this #8548 . Wouldn't it be better to have it on items instead of crafting recipes? 21:19 ShadowBot https://github.com/minetest/minetest/issues/8548 -- on_craft in crafting definition