Minetest logo

IRC log for #minetest-dev, 2020-02-16

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:52 kilbith joined #minetest-dev
01:00 ANAND joined #minetest-dev
01:26 pmp-p joined #minetest-dev
05:11 fluxflux_ joined #minetest-dev
05:41 ANAND joined #minetest-dev
06:34 Unarelith joined #minetest-dev
06:38 v-rob joined #minetest-dev
06:38 v-rob left #minetest-dev
08:13 mizux joined #minetest-dev
08:38 ShadowNinja joined #minetest-dev
09:00 Beton joined #minetest-dev
09:02 pmp-p joined #minetest-dev
09:22 pmp-p joined #minetest-dev
09:27 pmp-p joined #minetest-dev
11:03 pmp-p joined #minetest-dev
11:10 df458 joined #minetest-dev
11:12 YuGiOhJCJ joined #minetest-dev
11:33 Fixer joined #minetest-dev
12:22 sfan5 some PRs that just need a second look:
12:22 sfan5 #9374
12:22 ShadowBot https://github.com/minetest/minetest/issues/9374 -- Basic model shading by dcbrwn
12:22 sfan5 #9369
12:22 ShadowBot https://github.com/minetest/minetest/issues/9369 -- Fix potential security issue(s), documentation on minetest.deserialize() by luk3yx
12:22 sfan5 #9271
12:22 ShadowBot https://github.com/minetest/minetest/issues/9271 -- Allow texture modifiers in hotbar textures. by Warr1024
12:35 Krock How do I check whether #9374 works? I don't see any difference (shaders enabled)
12:35 ShadowBot https://github.com/minetest/minetest/issues/9374 -- Basic model shading by dcbrwn
12:36 Krock 2020-02-16 13:36:26: ERROR[Main]: Irrlicht: GLSL shader failed to compile
12:36 Krock 2020-02-16 13:36:26: ERROR[Main]: Irrlicht: 0(88) : error C0105: Syntax error in #if
12:36 Krock 0(88) : error C0105: Syntax error in #if
12:37 Krock this probably requires OpenGL > 3.3
12:41 Krock 60bff1e6cb (Lars Hofhansl 2019-11-19 19:42:52 -0800  50)        MATERIAL_TYPE == TILE_MATERIAL_WAVING_LIQUID_OPAQUE || \
12:41 Krock okay. This is PR-unrelated
12:42 sfan5 hm
12:43 calcul0n joined #minetest-dev
12:44 sfan5 I don't think there's supposed to be a visible difference
12:44 kilbith joined #minetest-dev
12:44 Krock okay. Continued lines using "\" do not work in OpenGL 3.3
12:44 Krock the entities are now full-bright. no GLSL errors/warnings
12:45 Krock will check on secondary PC
12:57 Krock > y = max(-10, min(self.object:get_velocity().y, 10)),
12:58 Krock get_velocity somehow returns nil. I suspect that's due to the recent entity invalidation changes
12:59 sfan5 yes https://github.com/pandorabox-io/pandorabox.io/issues/444#issuecomment-585410733
12:59 Krock and builtin/item.lua is broken for unknown nodes
12:59 Krock fixing
13:09 Krock well, I don't know whether the PR works. I don't see any difference.
13:10 Krock Will push the following fixes in ~15 minutes:
13:10 Krock https://krock-works.uk.to/u/patches/0001-Builtin-Fix-error-by-digging-unknown-nodes.patch
13:10 Krock https://krock-works.uk.to/u/patches/0001-Shaders-Fix-OpenGL-4.30.6-compatibility.patch
13:11 sfan5 did you look up that version number somewhere?
13:12 sfan5 I'd have expected the \ stuff being an implementation detail
13:12 sfan5 looks good either way
13:12 Krock https://stackoverflow.com/questions/16426105/does-opengl-and-opengl-es-support-preprocessor-line-continuation-characters
13:13 Krock will edit the commit message to say "4.3" because that's user-friendly
13:13 sfan5 interesting
13:25 Krock pushing
13:49 Krock .. where's V6 in the world selector?
13:51 Krock > mg_flags = nocaves, nodungeons, nolight, nodecorations, nobiomes
13:51 Krock dang. that's some work for me to do
13:51 sfan5 its at the very bottom, not sure why that list is not sorted
13:54 Krock > disallowed_mapgens = v6
13:55 Krock After all I think it might be wise to append the text "(not recommended)" for games rather than removing it entirely from the list
14:07 Krock okay. mapgen flags specified in game minetest.conf files are not applied correctly
14:37 absurb joined #minetest-dev
14:42 pmp-p joined #minetest-dev
14:45 fluxflux_ joined #minetest-dev
15:56 Unarelith joined #minetest-dev
17:01 sfan5 https://travis-ci.org/minetest/minetest/jobs/651145682#L677
17:01 sfan5 ¯\_(ツ)_/¯
17:01 Krock rip travis
17:22 Taoki joined #minetest-dev
17:52 Unarelith joined #minetest-dev
17:58 Wuzzy joined #minetest-dev
19:13 kilbith joined #minetest-dev
19:31 sfan5 merging #9374 in 5m
19:31 ShadowBot https://github.com/minetest/minetest/issues/9374 -- Basic model shading by dcbrwn
20:35 NoctisLa1 joined #minetest-dev
20:46 indiana joined #minetest-dev
20:54 df458 joined #minetest-dev
21:10 indiana joined #minetest-dev
22:01 NoctisLa1 joined #minetest-dev
22:15 erlehmann joined #minetest-dev
23:31 kilbith so about the Jordach sky...
23:32 kilbith what if the core devs could make the changes themselves?
23:32 kilbith s/core devs/reviewers
23:32 kilbith this would be a nice milestone for 5.2
23:34 Fixer_ joined #minetest-dev
23:51 kilbith video[] is cooking... https://i.imgur.com/AqwyA1A.png
23:53 sfan5 > what if the core devs could make the changes themselves?
23:53 sfan5 they can
23:53 sfan5 maybe they should

| Channels | #minetest-dev index | Today | | Google Search | Plaintext