Time Nick Message 18:20 rubenwardy Krock: we need to do a formspec refactor fairly asap 18:21 rubenwardy *cough* and break everything *cough* 18:21 Krock >.< 18:21 rubenwardy the parsing should be a separate responsibility 18:22 Krock oh, that wouldn't be too difficult to implement 18:22 Krock table, function pointer and go 18:22 Krock s/table/struct array7 18:23 Krock remember that this is totally valid formspec code: size[3,3]foo[]]]]]]]]] 18:24 rubenwardy yeah 18:25 rubenwardy how would the parser create elements and field specs? 18:27 rubenwardy I guess - make containers an actual guielement 18:27 rubenwardy with the parent existing in the parserdata 18:27 Krock yes 18:28 rubenwardy have a FormspecParser class which uses a table to call parse methods on FormspecElementParsers, with some way of getting field specs 18:28 rubenwardy is there any other state that fieldspecs and created gui elements now? 18:28 rubenwardy I haven't touched the formspec code since all these changes recently 18:28 rubenwardy *than 18:29 rubenwardy also, fieldspecs suck 18:29 rubenwardy they should be a fancy mapping from formspec names to IrrGUI ids 18:29 rubenwardy not contain tooltips, that should be an IGUI thing 18:30 rubenwardy wait - style and *options 18:31 rubenwardy those could be in the ParserData I guess 18:44 rubenwardy #9358 18:44 ShadowBot https://github.com/minetest/minetest/issues/9358 -- Formspec Refactor 19:51 paramat i will merge trivial #9359 in 3 hours 19:51 ShadowBot https://github.com/minetest/minetest/issues/9359 -- Warn of biome ID re-allocation when unregistering or clearing biomes by paramat 20:56 Thomas-S Some MTG dev attention for game+2436 would be nice. It seems to be a very helpful change for modders. 20:56 Thomas-S * game#2436 20:56 ShadowBot https://github.com/minetest/minetest_game/issues/2436 -- Torch API by MoNTE48