Time  Nick       Message
19:14 Krock      YES fixed it
19:15 Krock      colors will now also work on labels
19:39 Krock      #9187
19:39 ShadowBot  https://github.com/minetest/minetest/issues/9187 -- StaticText/EnrichedString: Styling support by SmallJoker
19:40 Krock      +/- perfectly balanced. Not intended but that's fine, I think.
19:48 rubenwardy we need actual formspec unit tests, argh
19:50 rubenwardy wip thing I closed: #8615
19:50 ShadowBot  https://github.com/minetest/minetest/issues/8615 -- Add formspec rendering automated testing by rubenwardy
19:55 rubenwardy not sure what the best approach would be, the above is basically a fancy hack
19:58 Krock      a tab for each formspec element
19:58 Krock      inside, various combinations of its parameters
19:58 rubenwardy there's no comparison of expected vs actual, and there's no automation to make checking easy
19:58 Krock      and a "meta" formspec element (like checkbox) to control styling
19:59 Krock      after it's done there could be screenshots saved until an automated solution has been found
19:59 rubenwardy the approach in the above PR is to render a bunch of different formspecs to screenshots
19:59 rubenwardy using a fake mainmenu
19:59 rubenwardy and then it would output all the screenshots to a directory
19:59 rubenwardy and then compare those screenshots against accepted screenshots
19:59 rubenwardy outputting and differences to a results dir
20:00 rubenwardy the person would then check the differences, and run a script to commit them if they're correct
20:01 rubenwardy in CI, it would use a virtual X server and simply list any tests that have changed
20:03 rubenwardy Do you think using the mainmenu code to save screenshots is an acceptable hack?
20:03 rubenwardy I could make a different formspec environment
20:04 rubenwardy that could be cleaner
20:12 rubenwardy I've decided that making a new formspec environment would be a lot cleaner
20:13 rubenwardy also, super easy PR to review: #9184
20:13 ShadowBot  https://github.com/minetest/minetest/issues/9184 -- Add Lua builtin unit tests by rubenwardy
20:16 Krock      well yes, it's not clean and a different env would be way better
20:16 Krock      if there's limited time or uncertain design concepts I'd use the mainmenu code to check how well it works
20:19 Krock      how does the tests/*.lua thing work? Does "busted" parse all files it can find?
20:19 Krock      or is "tests" a default path?
20:19 rubenwardy busted searches for *_spec.lua
20:19 rubenwardy https://olivinelabs.com/busted/
20:21 Krock      hmm okay, thanks.
20:24 Krock      some lines are >90 characters. breaking it would make the code harder to read...
21:23 rubenwardy yay!
21:23 rubenwardy I have a formspec rendering in standalone, not in the menu or game
22:06 rubenwardy #9188
22:06 ShadowBot  https://github.com/minetest/minetest/issues/9188 -- Add standalone formspec renderer by rubenwardy
22:31 p_gimeno   nice
23:24 rubenwardy #9189
23:24 ShadowBot  https://github.com/minetest/minetest/issues/9189 -- WIP: Add formspec renderering tests by rubenwardy