Time  Nick       Message
20:03 rubenwardy #7621 is ready for review again
20:03 ShadowBot  https://github.com/minetest/minetest/issues/7621 -- Add secure require() function by rubenwardy
20:28 rubenwardy merging #9087 in 20
20:28 ShadowBot  https://github.com/minetest/minetest/issues/9087 -- Add z-index management to HUD by EvidenceBKidscode
20:33 sfan5      you can also merge 9170
20:34 rubenwardy #9170
20:34 rubenwardy ok
20:34 ShadowBot  https://github.com/minetest/minetest/issues/9170 -- fix android build (untested) by zaoqi
20:34 rubenwardy and #8530
20:34 ShadowBot  https://github.com/minetest/minetest/issues/8530 -- Add scrollbaroptions FormSpec element by v-rob
20:37 rubenwardy We really could utilise more automation
20:38 rubenwardy heh
20:44 rubenwardy I'd like something to handle state
20:45 rubenwardy WIP -> Ready for Review -> action needed -> etc
20:47 rubenwardy It would also be nice to be able to go from full PR to WIP PR like you can on GItlab
20:48 rubenwardy merging...
20:51 rubenwardy done
20:56 rubenwardy I propose amending our code style to say:  "structs shouldn't contain any methods. If it contains methods, make it a class"
20:56 rubenwardy or something
20:56 rubenwardy to have a useful distinction between the two
20:57 sfan5      hmm
20:57 sfan5      i don't agree entirely
20:58 rubenwardy well, what do you think about this: https://github.com/minetest/minetest/pull/9032/files#diff-84b4a6f43e14b267d1826ad88e471032
20:59 sfan5      I think struct as more of "data storage with some helper methods" while class is a full-blown object
20:59 sfan5      in that example texture should be a class
20:59 rubenwardy ok
21:53 rubenwardy hmmm  https://rwdy.uk/5OAmt.png
22:03 rubenwardy I've marked a lot of PRs as "Possible close" which haven't been updated in a few months and are either "WIP" or "Action/change needed"
22:06 rubenwardy either unlabel or close at your pleasure
22:07 rubenwardy also, Github now supports a split permission model
22:07 rubenwardy meaning that you can let people triage issues without having push access
22:08 rubenwardy might be useful for people who are knowledgable in minetest but not as good with C++. Obviously, they should only label/close duplicates/etc
22:16 rubenwardy It's annoying how Github doesn't allow issues in multiple milestones
22:17 rubenwardy call them deliverables instead
23:18 rubenwardy here's an easy one to review: #9173
23:18 ShadowBot  https://github.com/minetest/minetest/issues/9173 -- Run luacheck in travis by rubenwardy
23:39 rubenwardy the above passes travis, and the logs confirm correct behaviour. Will take less than 10 minutes to review
23:39 rubenwardy logs: https://travis-ci.org/minetest/minetest/jobs/621836582?utm_medium=notification&utm_source=github_status