Time  Nick       Message
02:08 paramat    !tell Krock concerning PR 9093, i changed the value to 10 as you suggested
02:08 ShadowBot  paramat: O.K.
02:08 paramat    merging #9093
02:08 ShadowBot  https://github.com/minetest/minetest/issues/9093 -- Tunnels: Completely disable generation when 'cave width' >= 10 by paramat
03:01 paramat    merging trivial #9095
03:01 ShadowBot  https://github.com/minetest/minetest/issues/9095 -- Silence invalid Clang Format report by paramat
03:03 paramat    see related #9074 , any more opinions?
03:04 ShadowBot  https://github.com/minetest/minetest/issues/9074 -- Clang Format: Whitelist all files and use in a new way to avoid the problems
03:04 paramat    #9016
03:04 ShadowBot  https://github.com/minetest/minetest/issues/9016 -- Display true/false for states of bools instead of enabled/disabled in 'All Settings' menu
03:07 paramat    please can core devs give feedback on issues i open? there are many with little or no feedback, it is odd
10:38 nerzhul    hello !
10:38 nerzhul    i just pushed the apk v24 (5.1.0 on github). It's not valid on the play store. We need  to have 64b support in the apk now
10:38 nerzhul    https://github.com/minetest/minetest/releases/tag/5.1.0
10:38 nerzhul    the apk is working well, people who whats to test it can gather it on github
10:38 nerzhul    it's just not pusheable yet :D
10:39 Krock      at least it's a start. thank you.
10:39 Krock      looking forward to a G Play version
11:16 nerzhul    i'm porting a multi arch fix on the build.gradle, build is in progress, will try to push that after
11:35 Krock      InvRef:add_item does not respect stack_max >.<
11:39 rubenwardy nerzhul: you pushed to the wrong branch
11:40 rubenwardy Oh nevermind
11:40 rubenwardy You pushed to both
11:48 nerzhul    rubenwardy yes, pushed to stable-5 then ported
11:51 nerzhul    i just pushed a second fix for 64bit support, but it's not sufficient yet
11:55 nerzhul    then we are currently stucked on the deploy on the play store unfortunately
12:36 sfan5      Krock: I think that's on purpoise
12:36 sfan5      -i
12:37 ANAND      And it should remain that way, IMHO
12:37 Krock      well, handle_node_drops is broken in that case
12:38 sfan5      add_item could have an additional parameter that makes it respect stack size and handle_node_drops could then use that
12:38 Krock      opened an issue because I wasn't sure about it anyway
12:38 ANAND      IIRC we just recently had an issue for wanting to use add_item to bypass stack_max :)
12:38 sfan5      btw, anyone mind reviewing my CSM pr?
12:38 Krock      ANAND: ikr, but I couldn't find it
12:38 Krock      sfan5: mods usually add "/logic.lua" after get_modpath(), why is it not needed for CSM?
12:38 Krock      looks like the paths are different (tailing DIR_DELIM)
12:39 sfan5      get_modpath returns "modname:" which is also documented that way
12:39 sfan5      would be nice if it worked identically but DIR_DELIM is not ':' so that's not possible
12:39 ANAND      Aha, #8519
12:39 ShadowBot  https://github.com/minetest/minetest/issues/8519 -- Revert e6a9e60 by ClobberXD
12:40 Krock      that's a confusing difference
12:40 Krock      modname:/lua_file.lua should be valid too in that case
12:40 ANAND      Krock: #8518
12:40 Krock      i.e. trim first DIR_DELIM if there's any
12:40 ShadowBot  https://github.com/minetest/minetest/issues/8518 -- Allow exceeding 'stack_max' with '/give(me)'
12:40 Krock      thnaks ANAND
12:41 ANAND      ;)
12:42 sfan5      I guess it could do that, will look at it later
12:44 Krock      ANAND: won't reopen the old issues, but provided a history of "bugfixes" and "bugs"
12:45 ANAND      lol
12:45 ANAND      Endless cycle of fix and reverts :P
12:45 ANAND      > Caused by #8519 which reverted #5774, which itself fixed #5773 which is in conflict to #8518.
12:45 ShadowBot  https://github.com/minetest/minetest/issues/8519 -- Revert e6a9e60 by ClobberXD
12:45 ShadowBot  https://github.com/minetest/minetest/issues/5774 -- Make addItem for empty ItemStacks respect max stack size by nybble41
12:45 ShadowBot  https://github.com/minetest/minetest/issues/5773 -- ItemStack::addItem does not enforce stack size limit when ItemStack is empty
12:45 ShadowBot  https://github.com/minetest/minetest/issues/8518 -- Allow exceeding 'stack_max' with '/give(me)'
12:45 ANAND      Uh oh, sorry
12:46 ANAND      sfan5's idea of optional param for add_item sounds good to me
12:46 Krock      indeed
12:49 Krock      So std::string(size, 0) is the replacement of char[size] and memset()?
12:49 Krock      apparently.
13:25 sfan5      yes https://en.cppreference.com/w/cpp/string/basic_string/basic_string
13:25 sfan5      see constructor (2)
14:10 Krock      sfan5: other than DIR_DELIM and the single comment in the CSM PR there's nothing else. Looks good.
14:11 sfan5      <Krock> modname:/lua_file.lua should be valid too in that case
14:11 sfan5      ^ I'm about to push a commit for this
14:11 Krock      great :)
14:12 Krock      I'm aware about the second constructor. Just wondered whether that's the C++ way of doing it. Answered my question, though.
14:15 sfan5      using an automatically managed string instead of manually managed memory is certainly more C++-like
14:17 sfan5      PR updated
15:03 sfan5      merging #9092 in 5 minutes
15:03 ShadowBot  https://github.com/minetest/minetest/issues/9092 -- Some CSM changes by sfan5
19:19 paramat    i will merge trivial #9094 in 4 hours
19:19 ShadowBot  https://github.com/minetest/minetest/issues/9094 -- Randomwalk caves: Extend beyond mapchunk vertically also by paramat
20:07 Krock      thanks paramat. those issues were not that popular so it's probably best to close them until someone insists on reopening