Time Nick Message 11:32 sfan5 merging game#2486 in 10m 11:32 ShadowBot https://github.com/minetest/minetest_game/issues/2486 -- Add German translation by Wuzzy2 18:52 Krock in order to solve the "base pack overriding other texture packs' textures" problem, it would be possible to rename it to .base/ 18:52 Krock because the directory listing ignores that, and as a fallback it could manually be included 18:53 Krock however, how many references outside Minetest are there? I could adjust all Minetest paths, but the docs and tutorials outside do not 18:53 Krock and checking whether the path is /path/to/base/pack is quite error-prone on Windows since \ and / are valid 18:54 Krock but if the case of C:/path/to/base/pack on Windows can be ignored, then it's likely a two-liner change 18:54 Krock opinions? 18:58 Krock weird. I started coding without actually testing the bug first. Wuzzy: How did you manage to let the builtin textures override yours? 18:59 Krock enabled a mod as described but overriding works just fine 19:10 paramat odd, will test 19:14 Krock I see. this happens when no texture pack is selected 19:18 paramat for my test i didn't have a texture pack selected 19:19 paramat and reproduced the bug, see https://github.com/minetest/minetest/issues/8955#issuecomment-533909507 19:21 Krock testing patch 19:25 Krock easy fix 19:32 Wuzzy ah nice to see you already solved it without my help ? 19:32 paramat +1 for #8971 i think 'message' is fine 19:32 ShadowBot https://github.com/minetest/minetest/issues/8971 -- Rename "private messages" to "messages" by Calinou 19:32 Wuzzy i always like problems that magically solve themselves ? 19:37 Krock Wuzzy: well yeah. I had real struggle to find out why it didn't work for you; falsely assuming you were using a texture pack 19:38 Krock #8974 19:38 ShadowBot https://github.com/minetest/minetest/issues/8974 -- Textures: Load base pack only as last fallback by SmallJoker 19:38 paramat thanks for that will test 19:40 Krock in case you'd like to test with a texture pack enabled: that'll be pointless, none of that area was touched 19:40 Krock just for information 19:48 paramat merging game#2490 19:48 ShadowBot https://github.com/minetest/minetest_game/issues/2490 -- add bar door and trapdoor by TumeniNodes 19:49 paramat er, after i look through it 19:50 paramat one small error, won't merge yet 19:50 Krock you could adjust that during merge 19:50 Calinou paramat: most people seem to want "direct message" so I'll change it 19:51 Calinou let's not spend too much time choosing :P 19:53 paramat another error, don't merge yet 19:54 paramat core devs should decide for the message PR 19:54 Krock it's indeed not that private so the term is valid 20:00 Calinou "DM" is relatively common these days, look at Twitter or Discord 20:01 paramat i don't care about discord =) 20:02 paramat sfan5 approved this as 'message', you should go with core dev opinions not non core dev opinons 20:03 sfan5 I don't care whether it says "direct message" or "message" 20:04 paramat ok 20:05 paramat Krock are you ok with DM? 20:08 Krock yes 20:08 Krock both's fine 20:09 sfan5 merging #8959 #8960 in a few minutes 20:09 ShadowBot https://github.com/minetest/minetest/issues/8959 -- Punchwear (improved) by sfan5 20:09 ShadowBot https://github.com/minetest/minetest/issues/8960 -- Move the code for meta formspec into Game::nodePlacement by DS-Minetest 20:12 sfan5 done 20:15 paramat punchwear at last 20:16 sfan5 you might want to look into the values the code "makes up" for the existing tools in mtg 20:16 sfan5 e.g. 10 uses for a wooden sword strikes me as very low 20:17 Calinou does punchwear scale with the damage actually dealt? 20:17 Calinou so hitting enemies too fast doesn't wear down your sword 20:17 Calinou (when it deals 0 damage) 20:17 sfan5 it doesn't scale with damage 20:17 Calinou :( 20:17 sfan5 but it does with full_punch_interval so your concern is still addressed 20:17 Calinou ah, right 20:17 Calinou that's good enough to me then :) 20:18 sfan5 though doing 0 damage doesn't mean your sword won't wear 20:18 sfan5 so better learn to punch correctly ;) 20:47 paramat merging #8971 , one good thing about this is that 'DM' = Dungeon Master :) 20:47 ShadowBot https://github.com/minetest/minetest/issues/8971 -- Rename "private messages" to "direct messages" by Calinou 20:47 Calinou :D 20:47 Calinou thanks :) 20:50 tumeninodes paramat: what's the error? 21:24 paramat hi, see thread 21:25 tumeninodes will tend to them at once, thank you 21:32 paramat number of sword uses seems ok to me, they're consistent with all other tools, in fact, a little more generous 21:57 paramat thanks, merging game#2490 21:57 ShadowBot https://github.com/minetest/minetest_game/issues/2490 -- add bar door and trapdoor by TumeniNodes 21:57 tumeninodes Thank you 22:23 sfan5 oh I forgot to rebase punchwear after Krock's PR was merged 22:23 sfan5 and now the build is broken