| Time |
Nick |
Message |
| 00:10 |
|
fluxflux joined #minetest-dev |
| 00:24 |
|
Cornelia joined #minetest-dev |
| 01:17 |
|
Cornelia joined #minetest-dev |
| 02:02 |
|
nepugia joined #minetest-dev |
| 02:03 |
|
Cornelia joined #minetest-dev |
| 04:49 |
|
luk3yx joined #minetest-dev |
| 04:54 |
|
JTE joined #minetest-dev |
| 05:15 |
|
Cornelia joined #minetest-dev |
| 05:25 |
|
sofar joined #minetest-dev |
| 06:59 |
|
proller joined #minetest-dev |
| 07:38 |
|
Krock joined #minetest-dev |
| 08:09 |
|
Wuzzy joined #minetest-dev |
| 08:36 |
|
ShadowNinja joined #minetest-dev |
| 09:31 |
|
Fixer joined #minetest-dev |
| 10:12 |
|
lisac_ joined #minetest-dev |
| 11:18 |
|
Krock joined #minetest-dev |
| 11:52 |
|
DS-minetest joined #minetest-dev |
| 12:13 |
|
DS-minetest joined #minetest-dev |
| 12:23 |
|
tomraceror joined #minetest-dev |
| 12:41 |
DS-minetest |
Krock: why did you make the version_backup for fs prepends in your fs version PR a bool? |
| 12:41 |
DS-minetest |
it has to be a u16 |
| 13:24 |
|
Krock joined #minetest-dev |
| 13:25 |
Krock |
DS-minetest: nice catch, thank you. I copy-pasted. that's the issue |
| 13:31 |
Krock |
will fix soon |
| 14:03 |
|
tomraceror joined #minetest-dev |
| 14:06 |
|
DS-minetest joined #minetest-dev |
| 14:36 |
|
Cornelia joined #minetest-dev |
| 14:53 |
|
Kimapr joined #minetest-dev |
| 15:12 |
|
Cornelia joined #minetest-dev |
| 15:16 |
DS-minetest |
thanks to formspec version, I was able to make #8740 a non-breaking change |
| 15:16 |
ShadowBot |
https://github.com/minetest/minetest/issues/8740 -- Make formspec elements real elements for draw order and clipping by DS-Minetest |
| 15:19 |
|
Cornelia joined #minetest-dev |
| 15:21 |
DS-minetest |
should I keep the old buggy bgcolor behaviour in version < 2 in PR #8716? |
| 15:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/8716 -- Fix the bgcolor formspec element by DS-Minetest |
| 15:22 |
rubenwardy |
argh, I need to learn how Irrlicht GUI reference counting works |
| 15:22 |
DS-minetest |
(the change only breaks a bit of the look) |
| 15:23 |
rubenwardy |
why can't it use smart pointers |
| 15:23 |
DS-minetest |
http://irrlicht.sourceforge.net/docu/classirr_1_1_i_reference_counted.html |
| 15:25 |
|
Kimapr joined #minetest-dev |
| 15:27 |
Krock |
e->drop(); |
| 15:27 |
Krock |
if dropping fails, don't drop it. |
| 15:28 |
DS-minetest |
new and create… does grab |
| 15:30 |
rubenwardy |
so, new X will create two references - one for the caller, and one for the parent? |
| 15:30 |
rubenwardy |
I imagine it is grabbed in the constructor when attaching to the parent |
| 15:30 |
rubenwardy |
I'm opening my IDE and Irrlicht's source files |
| 15:31 |
DS-minetest |
the reference counter is initialized with 1, which is why new does grab |
| 15:31 |
rubenwardy |
yeah, but then it's also grabbed when attaching to the parent/environment, right? |
| 15:32 |
rubenwardy |
resulting in a reference coutner of 2 |
| 15:32 |
DS-minetest |
yes |
| 15:32 |
DS-minetest |
one for you and one for the env |
| 15:33 |
rubenwardy |
then I suppose Environment->addX will only create one for the env, hence why the code is grabbed |
| 15:33 |
DS-minetest |
(the env will eventually drop it itself) |
| 15:33 |
rubenwardy |
yeah, in clearAllElements or whatever |
| 15:33 |
rubenwardy |
manual reference counting is disgusting |
| 15:33 |
DS-minetest |
(minetest does the same with forceloading) |
| 15:40 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 15:45 |
|
Calinou joined #minetest-dev |
| 15:52 |
rubenwardy |
this is a nice PR |
| 15:57 |
rubenwardy |
merging trivial bug fix in 10: https://github.com/rubenwardy/minetest/commit/1ea9bfc6f75316e8de852c3a529541b5c800b367 |
| 15:57 |
rubenwardy |
Krock ^ |
| 16:01 |
rubenwardy |
will also merge #8716 |
| 16:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/8716 -- Fix the bgcolor formspec element by DS-Minetest |
| 16:02 |
DS-minetest |
yey |
| 16:08 |
DS-minetest |
regarding #8740: if the prepend uses version < 2 and includes images or item images and the not-prepend formspec uses version >= 2, the images and item images are not drawn in front |
| 16:08 |
ShadowBot |
https://github.com/minetest/minetest/issues/8740 -- Make formspec elements real elements for draw order and clipping by DS-Minetest |
| 16:08 |
* DS-minetest |
hopes this edge case is not a problem |
| 16:08 |
rubenwardy |
that's fine |
| 16:09 |
rubenwardy |
the prepends shouldn't contain actual elements really |
| 16:09 |
DS-minetest |
good |
| 16:14 |
rubenwardy |
merging.. |
| 16:14 |
rubenwardy |
done |
| 16:26 |
|
tomraceror joined #minetest-dev |
| 16:32 |
Krock |
nice, thanks rubenwardy. |
| 16:32 |
rubenwardy |
oh wow, (argc > 1 ? a : b) = 1; |
| 16:32 |
rubenwardy |
this is valid |
| 16:32 |
rubenwardy |
TIL |
| 16:33 |
|
DS-minetest joined #minetest-dev |
| 16:34 |
Krock |
I see profits |
| 16:35 |
|
ensonic joined #minetest-dev |
| 16:43 |
|
paramat joined #minetest-dev |
| 16:50 |
|
nepugia joined #minetest-dev |
| 17:16 |
|
DS-minetest joined #minetest-dev |
| 18:14 |
|
Cornelia joined #minetest-dev |
| 18:34 |
|
Cornelia joined #minetest-dev |
| 19:30 |
|
Lia joined #minetest-dev |
| 20:22 |
|
Cornelia joined #minetest-dev |
| 20:29 |
|
troller joined #minetest-dev |
| 20:29 |
|
paramat joined #minetest-dev |
| 20:51 |
|
troller joined #minetest-dev |
| 21:09 |
|
proller joined #minetest-dev |
| 21:20 |
|
Cornelia joined #minetest-dev |
| 21:25 |
paramat |
#8928 is ready, but not essential for 5.1.0 |
| 21:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/8928 -- Randomwalk caves: Add parameters for number and flooding by paramat |
| 21:54 |
paramat |
game#2481 simple and works |
| 21:54 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2481 -- Set fuel percentage to decrease by An0n3m0us |
| 22:16 |
|
Cornelia joined #minetest-dev |
| 22:21 |
sofar |
rubenwardy: valid but unethical |
| 22:23 |
rubenwardy |
huh? |
| 22:23 |
rubenwardy |
ah |
| 22:50 |
|
fluxflux joined #minetest-dev |
| 22:56 |
|
Cornelia joined #minetest-dev |
| 23:28 |
|
Cornelia joined #minetest-dev |
| 23:32 |
|
AntumDeluge joined #minetest-dev |
| 23:42 |
|
Cornelia joined #minetest-dev |
