Time  Nick        Message
06:53 ANAND       #8746
06:53 ShadowBot   https://github.com/minetest/minetest/issues/8746 -- Use `InteractAction` enum to denote interaction actions by ClobberXD
08:19 ANAND       #8747 :)
08:19 ShadowBot   https://github.com/minetest/minetest/issues/8747 -- Make settingtypes.txt great (again!)
08:20 ANAND       (It's an issue not a PR, btw :P)
09:34 ANAND       #8749
09:34 ShadowBot   https://github.com/minetest/minetest/issues/8749 -- Tweak near_plane setting to prevent abuse by ClobberXD
12:13 Krock       > CM: animated meshes (far)
12:13 Krock       > count of "faraway=true" passes to MapBlockMesh::animate()
12:13 Krock       > faraway unused
12:14 Krock       it's lovely how much effort was put into these profiles but half of them do not show anything useful
12:17 rubenwardy  I hate the mainmenu code so much
12:17 rubenwardy  send help
12:21 rubenwardy  so, my plan with the main menu is to make tabview a generic pager element
12:21 rubenwardy  so that it doesn't depend on a particular rendering metho
12:22 rubenwardy  then it can be customised by games by changing a layouter like     ui:get("main_tabs").layouter = tabview_layouts.classic
12:22 rubenwardy  letting games customise tab content is slightly more painful
12:25 rubenwardy  then game selection will be active for all tabs, and changed using a different dialog like  https://user-images.githubusercontent.com/2122943/60210596-201e2780-9855-11e9-8afd-1ac18884273a.png
12:51 ANAND       Travis' broken Xcode build is fixed, but now there are 3 other builds consistently failing in before_install.sh
12:52 ANAND       Looks like some issues with apt
12:54 red-045     rubenwardy: how do you plan to sandbox mainmenu lua?
12:54 ANAND       Hello red :)
12:55 rubenwardy  red-045: there's a PR for that
12:56 rubenwardy  #8619
12:56 ShadowBot   https://github.com/minetest/minetest/issues/8619 -- Add Lua sandbox to main menu by rubenwardy
12:58 red-045     so you want to run game supplied code in the same lua_state as bultin mainmenu code?
13:00 rubenwardy  haven't decided on that yet
13:00 rubenwardy  It could also be in another lua sandbox, with further limitations on API
13:00 rubenwardy  but a C sandbox would be the bare minimum
13:01 rubenwardy  games are a lower risk factor than mods, as they tend to be installed less willy nilly than mods
13:01 red-045     I was wondering if it would be possible to run it in a different lua_state and use mod messages to communicate with the mainmenu
13:01 rubenwardy  that's overengineered
13:16 red-045     that's fair
13:19 red-045     maybe it would be a good idea to allow users to also restrict direct network access to parts of the builtin code that need it
13:20 red-045     don't really see the use case for game code having that apart from checking for updates
13:22 rubenwardy  what are you referring to?
13:22 rubenwardy  oh, the main menu
13:22 red-045     could do that in the lua sandbox you suggested
13:23 red-045     it's not as serious as access to secure settings
14:02 sfan5       merging #8709 in 10m
14:02 ShadowBot   https://github.com/minetest/minetest/issues/8709 -- Unify OpenGL ES to be a platform-independent cmake switch by sfan5
14:13 sfan5       done
16:53 Krock       whereas the idea is nice, this looks horrible. https://user-images.githubusercontent.com/2122943/62418633-ef0bf080-b665-11e9-9d85-32f648a91f5f.png
16:53 rubenwardy  did you see the WIP label?
16:54 Krock       oh, I thought the design choices were definitive yet, so a bit weird to see it like this
16:54 Krock       but if that's WIP as well then sorry for these words (too harsh?)
16:55 Krock       but finally a nice formspec is incoming :D
16:58 rubenwardy  I prefer the vertical format
16:59 rubenwardy  which would look a lot better with rounded edges
16:59 Krock       or framed borders
17:11 red-045     Krock: the rest of the PR looks really nice
17:12 red-045     is that like meant to be the start menu?
17:12 Krock       it does indeed
17:14 rubenwardy  https://github.com/minetest/minetest/issues/6733#issuecomment-507847097
17:15 rubenwardy  the idea is to have the game's background too with that, and different button theming
17:55 DS-minetest #8752
17:55 ShadowBot   https://github.com/minetest/minetest/issues/8752 -- Add a detailed_description to items by DS-Minetest
18:00 Krock       time to leave. I've seen everything now
18:00 DS-minetest ¿
18:01 Krock       I don't see a need to make this a builtin special meta field
18:01 Krock       any mod can read out the meta of any item if the want to. or they can even provide an API to register such fields
18:02 DS-minetest but mods can't show tooltips
18:02 DS-minetest (at least not as good)
18:09 Krock       - while (true) {// while for break
18:09 Krock       + while (true) {// break for a while
18:10 Krock       bumping the version is not needed. it's backwards compatible the way you added it
18:10 Krock       pays of that I left these two comments there
18:11 Krock       *off
18:11 DS-minetest but maybe that was referring to the minimum version (6)
18:12 DS-minetest oops, forget the last thing I wrote
18:13 DS-minetest the comment was indeed helpful :)
18:40 sfan5       pushing https://a.uguu.se/Ny7muisvlFDj_2LXxoqO.txt in 5 minutes
18:40 sfan5       (1-line fix)
18:42 rubenwardy  lgtm